Merge pull request #268 from DevFactory/release/redundant-field-initializer-fix-1

Code quality fix - Redundant Field Initializer

Author: matzew

src/main/java/com/notnoop/apns/ApnsServiceBuilder.java

@@ -90,8 +90,8 @@ public class ApnsServiceBuilder {
 
     private SSLContext sslContext;
 
-    private int readTimeout = 0;
-    private int connectTimeout = 0;
+    private int readTimeout;
+    private int connectTimeout;
 
     private String gatewayHost;
     private int gatewayPort = -1;
@@ -101,23 +101,23 @@ public class ApnsServiceBuilder {
     private int pooledMax = 1;
     private int cacheLength = ApnsConnection.DEFAULT_CACHE_LENGTH;
     private boolean autoAdjustCacheLength = true;
-    private ExecutorService executor = null;
+    private ExecutorService executor;
 
     private ReconnectPolicy reconnectPolicy = ReconnectPolicy.Provided.EVERY_HALF_HOUR.newObject();
-    private boolean isQueued = false;
-    private ThreadFactory queueThreadFactory = null;
+    private boolean isQueued;
+    private ThreadFactory queueThreadFactory;
 
-    private boolean isBatched = false;
+    private boolean isBatched;
     private int batchWaitTimeInSec;
     private int batchMaxWaitTimeInSec;
-    private ScheduledExecutorService batchThreadPoolExecutor = null;
+    private ScheduledExecutorService batchThreadPoolExecutor;
 
     private ApnsDelegate delegate = ApnsDelegate.EMPTY;
-    private Proxy proxy = null;
-    private String proxyUsername = null;
-    private String proxyPassword = null;
+    private Proxy proxy;
+    private String proxyUsername;
+    private String proxyPassword;
     private boolean errorDetection = true;
-    private ThreadFactory errorDetectionThreadFactory = null;
+    private ThreadFactory errorDetectionThreadFactory;
 
     /**
      * Constructs a new instance of {@code ApnsServiceBuilder}

src/main/java/com/notnoop/apns/EnhancedApnsNotification.java

@@ -112,7 +112,7 @@ public int getExpiry() {
         return expiry;
     }
 
-    private byte[] marshall = null;
+    private byte[] marshall;
     /**
      * Returns the binary representation of the message as expected by the
      * APNS server.

src/main/java/com/notnoop/apns/SimpleApnsNotification.java

@@ -97,7 +97,7 @@ public byte[] getPayload() {
         return Utilities.copyOf(payload);
     }
 
-    private byte[] marshall = null;
+    private byte[] marshall;
     /**
      * Returns the binary representation of the message as expected by the
      * APNS server.

src/test/java/com/notnoop/apns/ApnsServerSocketBuilder.java

@@ -70,7 +70,7 @@ public class ApnsServerSocketBuilder {
 	private SSLContext sslContext;
 	private int gatewayPort = -1;
 	private int feedbackPort = -1;
-	private ExecutorService executor = null;
+	private ExecutorService executor;
 	private ApnsServerService serverService = ApnsServerService.EMPTY;
 	private ApnsServerExceptionDelegate exceptionDelegate = ApnsServerExceptionDelegate.EMPTY;
 

src/test/java/com/notnoop/apns/internal/ApnsFeedbackParsingUtils.java

@@ -70,7 +70,7 @@ static byte[] pack(byte[]... args) {
                    || (Arrays.equals(firstDevice, thirdDevice)));
     }
 
-    static int simpleDate = 0;
+    static int simpleDate;
     public static byte[] simple = pack(
             /* time_t */  new byte[] {0, 0, 0, 0},
             /* length */  new byte[] { 0, 32 },

src/test/java/com/notnoop/apns/utils/ApnsServerStub.java

@@ -83,7 +83,7 @@ public static ApnsServerStub prepareAndStartServer() {
     private final int feedbackPort;
     private int effectiveGatewayPort;
     private int effectiveFeedbackPort;
-    private OutputStream gatewayOutputStream = null;
+    private OutputStream gatewayOutputStream;
 
     public ApnsServerStub(ServerSocketFactory sslFactory) {
         this(sslFactory, 0, 0);