add eslint to pre commit, add pre commit to test pipeline, lint

Author: ThatcherT

.github/workflows/ci.yaml

@@ -25,37 +25,35 @@ jobs:
         with:
           python-version: "3.12"
 
-      - name: Install Next.js dependencies
+      - name: Install dependencies
         run: |
-          cd nextjs
-          npm ci
+          pip install pre-commit
+          cd nextjs && npm ci
 
-      - name: Run ESLint
-        run: |
-          cd nextjs
-          npm run lint
+      - name: Run pre-commit
+        run: pre-commit run --all-files
+
+  template-checks:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
 
       - name: Verify setup script syntax
-        run: |
-          python -m py_compile setup_project.py
+        run: python -m py_compile setup_project.py
 
       - name: Verify template config is valid JSON
-        run: |
-          python -c "import json; json.load(open('template.config.json'))"
+        run: python -c "import json; json.load(open('template.config.json'))"
 
-      - name: Check for template variable consistency
+      - name: Check template variable consistency
         run: |
-          echo "Checking that all template variables in code have mappings in setup script..."
-          # Extract variables from setup_project.py
+          echo "Checking template variables..."
           grep -oP '"\{\{[A-Z_]+\}\}"' setup_project.py | sort -u > /tmp/defined_vars.txt
-          # Extract variables used in codebase (excluding setup files and templates dir for this check)
           grep -roh '\{\{[A-Z_]*\}\}' --include="*.py" --include="*.yaml" --include="*.ts" --include="*.tsx" --include="*.conf" --include="Makefile" . 2>/dev/null | \
-            grep -v "\.State\." | \
-            sort -u | \
-            sed 's/^/"/;s/$/"/' > /tmp/used_vars.txt || true
-          # Compare (used vars should be subset of defined vars)
-          echo "Defined variables:"
-          cat /tmp/defined_vars.txt
-          echo ""
-          echo "Used variables:"
-          cat /tmp/used_vars.txt
+            grep -v "\.State\." | sort -u | sed 's/^/"/;s/$/"/' > /tmp/used_vars.txt || true
+          echo "Defined: $(cat /tmp/defined_vars.txt | wc -l) | Used: $(cat /tmp/used_vars.txt | wc -l)"

.github/workflows/pre-commit.yaml

@@ -19,6 +19,16 @@ repos:
         types: [file]
         files: '\.(js|jsx|ts|tsx|json|yaml|md|css|html)$'
 
+  # eslint for nextjs
+  - repo: local
+    hooks:
+      - id: eslint
+        name: eslint
+        entry: bash -c 'cd nextjs && npm run lint'
+        language: system
+        files: '\.(js|jsx|ts|tsx)$'
+        pass_filenames: false
+
   # python linter and formatter
   - repo: https://github.com/psf/black
     rev: 25.1.0

.pre-commit-config.yaml

@@ -14,7 +14,7 @@ import { useRouter, useSearchParams } from "next/navigation";
 import { useState } from "react";
 
 export default function RegisterPage() {
-  const { loading, error, clearError, refreshUser } = useAuth();
+  const { error, clearError, refreshUser } = useAuth();
   const [email, setEmail] = useState("");
   const [password, setPassword] = useState("");
   const [passwordConfirm, setPasswordConfirm] = useState("");

nextjs/src/app/(auth)/register/page.tsx

@@ -23,7 +23,7 @@ import { useRouter } from "next/navigation";
 import { useState } from "react";
 
 export default function SettingsPage() {
-  const { user, refreshUser } = useAuth();
+  const { user } = useAuth();
   const router = useRouter();
 
   // Change password state

nextjs/src/app/(dashboard)/dashboard/settings/page.tsx

@@ -11,6 +11,30 @@ on:
       - develop
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "lts/hydrogen"
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+
+      - name: Install dependencies
+        run: |
+          pip install pre-commit
+          cd nextjs && npm ci
+
+      - name: Run pre-commit
+        run: pre-commit run --all-files
+
   test:
     runs-on: ubuntu-latest
     steps: