chore: remove XCM destination generator logic (moved to feat/xcm_destination_generator)

Author: stepanLav

src/renderer/app/bootstrap/index.ts

@@ -1,7 +1,3 @@
-/* eslint-disable import-x/max-dependencies */
-
-import { chainsService } from '@/shared/api/network';
-import { spellXcmService } from '@/shared/api/xcm/service/spellXcmService';
 import { kernelModel } from '@/shared/core';
 import { createFeature, registerFeatures } from '@/shared/feature';
 import { isWeb } from '@/shared/lib/utils';
@@ -55,20 +51,6 @@ const populate = async () => {
   portfolioModel.populate();
   balanceModel.populate();
 
-  // Initialize XCM whitelist from nova-utils (non-blocking)
-  chainsService
-    .getChainsData()
-    .then((chains) => {
-      if (chains && chains.length > 0) {
-        spellXcmService.initializeXcmWhitelist(chains).catch((error) => {
-          console.warn('Failed to initialize XCM whitelist in bootstrap:', error);
-        });
-      }
-    })
-    .catch((error) => {
-      console.warn('Failed to load chains for XCM whitelist initialization:', error);
-    });
-
   // TODO rework as populate effects
   kernelModel.events.appStarted();
   assetsSettingsModel.events.assetsStarted();

src/renderer/shared/api/xcm/service/constants.ts

@@ -1,4 +1,4 @@
-import { type Chain, type ChainId } from '@/shared/core';
+import { type ChainId } from '@/shared/core';
 
 export type XcmDestinationBlacklistEntry = {
   sourceChainId?: ChainId | null;
@@ -12,27 +12,6 @@ export type XcmDestinationWhitelistEntry = {
   destinationAsset?: string;
 };
 
-/**
- * Gets the XCM whitelist entries.
- *
- * This function will attempt to load from nova-utils, falling back to legacy
- * hardcoded list.
- *
- * @param chains - Array of all available chains (required for nova-utils
- *   loading)
- *
- * @returns Promise resolving to whitelist entries
- */
-export async function getXcmWhitelist(chains: Chain[]): Promise<XcmDestinationWhitelistEntry[]> {
-  try {
-    const { loadXcmWhitelistFromNovaUtils } = await import('./xcmWhitelistService');
-    return await loadXcmWhitelistFromNovaUtils(chains);
-  } catch (error) {
-    console.warn('Failed to load XCM whitelist from nova-utils, using legacy whitelist:', error);
-    return XCM_DESTINATION_WHITELIST_LEGACY;
-  }
-}
-
 export const XCM_DESTINATION_BLACKLIST: XcmDestinationBlacklistEntry[] = [
   {
     sourceChainId: '0x48239ef607d7928874027a43a67689209727dfb3d3dc5e5b03a39bdc2eda771a', // Kusama Asset Hub
@@ -155,12 +134,7 @@ export const XCM_DESTINATION_BLACKLIST: XcmDestinationBlacklistEntry[] = [
   },
 ];
 
-/**
- * Legacy hardcoded whitelist (kept as fallback).
- *
- * This will be replaced by data from nova-utils repository
- */
-export const XCM_DESTINATION_WHITELIST_LEGACY: XcmDestinationWhitelistEntry[] = [
+export const XCM_DESTINATION_WHITELIST: XcmDestinationWhitelistEntry[] = [
   {
     sourceChainId: '0xfc41b9bd8ef8fe53d58c7ea67c794c7ec9a73daf05e6d54b14ff6342c99ba64c', // Acala
     destinationChainId: '0x9eb76c5184c4ab8679d2d5d819fdf90b9c001403e9e17da2e14b6d8aec4029c6', // Astar

src/renderer/shared/api/xcm/service/spellXcmService.ts

@@ -7,13 +7,7 @@ import { type Asset, type Chain, type ChainId, AssetType } from '@/shared/core';
 import { CHAIN_ID_TO_SPELL_NAME_MAP, isEthereumAccountId, nonNullable, toAddress } from '@/shared/lib/utils';
 import { type AccountId } from '@/shared/polkadotjs-schemas';
 
-import {
-  type XcmDestinationBlacklistEntry,
-  type XcmDestinationWhitelistEntry,
-  XCM_DESTINATION_BLACKLIST,
-  XCM_DESTINATION_WHITELIST_LEGACY,
-  getXcmWhitelist,
-} from './constants';
+import { type XcmDestinationBlacklistEntry, XCM_DESTINATION_BLACKLIST, XCM_DESTINATION_WHITELIST } from './constants';
 import { normalizeXcmError } from './xcm-error-utils';
 
 type XcmTransferParams = {
@@ -111,55 +105,13 @@ function isRouteBlacklisted(sourceChainId: ChainId, destinationChainId: ChainId)
   });
 }
 
-let cachedWhitelistEntries: XcmDestinationWhitelistEntry[] | null = null;
-let whitelistLoadingPromise: Promise<XcmDestinationWhitelistEntry[]> | null = null;
-
-/**
- * Gets whitelist entries, loading from nova-utils if not already cached
- */
-async function getWhitelistEntries(chains: Chain[]): Promise<XcmDestinationWhitelistEntry[]> {
-  if (cachedWhitelistEntries) {
-    return cachedWhitelistEntries;
-  }
-
-  if (whitelistLoadingPromise) {
-    return whitelistLoadingPromise;
-  }
-
-  whitelistLoadingPromise = getXcmWhitelist(chains).then((entries) => {
-    cachedWhitelistEntries = entries;
-    whitelistLoadingPromise = null;
-    return entries;
-  });
-
-  return whitelistLoadingPromise;
-}
-
-/**
- * Synchronous version that uses cached whitelist or falls back to legacy
- */
-function getWhitelistEntriesSync(): XcmDestinationWhitelistEntry[] {
-  if (cachedWhitelistEntries) {
-    return cachedWhitelistEntries;
-  }
-  // Fallback to legacy whitelist if nova-utils hasn't loaded yet
-  return XCM_DESTINATION_WHITELIST_LEGACY;
-}
-
 function isRouteWhitelisted(
   sourceChainId: ChainId,
   destinationChainId: ChainId,
   sourceAssetSymbol?: string,
   destinationAssetSymbol?: string,
-  whitelistEntries?: XcmDestinationWhitelistEntry[],
 ): boolean {
-  const entries = whitelistEntries || getWhitelistEntriesSync();
-
-  if (!entries || entries.length === 0) {
-    return false;
-  }
-
-  return entries.some((entry) => {
+  return XCM_DESTINATION_WHITELIST.some((entry) => {
     if (entry.sourceChainId !== sourceChainId || entry.destinationChainId !== destinationChainId) {
       return false;
     }
@@ -532,25 +484,6 @@ async function buildTransfer(params: XcmTransferParams): Promise<XcmTransferResu
   };
 }
 
-/**
- * Initializes the XCM whitelist by loading it from nova-utils This should be
- * called early in the application lifecycle when chains are available
- *
- * @param chains - Array of all available chains
- */
-async function initializeXcmWhitelist(chains: Chain[]): Promise<void> {
-  if (cachedWhitelistEntries) {
-    return;
-  }
-
-  try {
-    const entries = await getWhitelistEntries(chains);
-    console.log(`✅ XCM whitelist loaded from nova-utils: ${entries.length} entries`);
-  } catch (error) {
-    console.warn('Failed to initialize XCM whitelist from nova-utils, using legacy whitelist:', error);
-  }
-}
-
 function getAvailableTransfers(fromChain: Chain, asset: Asset): string[] {
   const fromChainName = getSpellChainName(fromChain);
   if (!fromChainName) {
@@ -571,7 +504,6 @@ function getAvailableTransfers(fromChain: Chain, asset: Asset): string[] {
         return false;
       }
 
-      // Use cached whitelist synchronously (will fallback to legacy if not loaded yet)
       return isRouteWhitelisted(fromChain.chainId, destinationChainId, asset.symbol);
     });
     return filteredDestinations;
@@ -593,5 +525,4 @@ export const spellXcmService = {
   detectHopChains,
   buildXcmTransferBuilder,
   createBuilderConfig,
-  initializeXcmWhitelist,
 };