fix

Author: kogeler

.github/actions/install/action.yml

@@ -100,6 +100,11 @@ runs:
       with:
         bundler-cache: true
 
+    - name: Setup Python
+      uses: actions/setup-python@v4
+      with:
+        python-version: "3.x"
+
     - name: Ensure SPM directory exists
       if: inputs.minimal_mode != 'true'
       shell: bash

.github/scripts/update_build_number.py

@@ -0,0 +1,119 @@
+#!/usr/bin/env python3
+"""
+Simple script for updating CURRENT_PROJECT_VERSION (build number) in Xcode project file.
+Can either increment the current build number or set it to a specific value.
+"""
+
+import argparse
+import os
+import re
+import sys
+
+
+def update_build_number(pbxproj_path, config_name, build_number=None):
+    """
+    Update CURRENT_PROJECT_VERSION in specific build configuration.
+
+    Args:
+        pbxproj_path: Path to project.pbxproj file
+        config_name: Configuration name (e.g., 'Release', 'DevCI')
+        build_number: If provided, set to this value. If None, increment current value.
+
+    Returns:
+        Tuple of (success: bool, new_build_number: int)
+    """
+    if not os.path.isfile(pbxproj_path):
+        raise FileNotFoundError(f"Xcode project file not found at {pbxproj_path}")
+
+    with open(pbxproj_path, "r", encoding="utf-8", errors="ignore") as f:
+        content = f.read()
+
+    # Find configuration block by name
+    # Pattern: <config_id> /* <config_name> */ = { ... };
+    config_pattern = (
+        rf"(\w{{24}}\s*/\*\s*{re.escape(config_name)}\s*\*/\s*=\s*\{{[^}}]*?\}})"
+    )
+    config_match = re.search(config_pattern, content, re.DOTALL)
+
+    if not config_match:
+        raise ValueError(f"Could not find configuration block for '{config_name}'")
+
+    # Find current build number in the config block
+    config_block = config_match.group(0)
+    build_match = re.search(r"CURRENT_PROJECT_VERSION\s*=\s*(\d+);", config_block)
+
+    if not build_match:
+        raise ValueError(
+            f"Could not find CURRENT_PROJECT_VERSION in {config_name} configuration"
+        )
+
+    current_build = int(build_match.group(1))
+
+    if build_number is not None:
+        # Set to specific value
+        new_build = build_number
+        action = "Set"
+    else:
+        # Increment current value
+        new_build = current_build + 1
+        action = "Incremented"
+
+    # Update build number in the configuration block
+    def update_block(match):
+        block = match.group(0)
+        block = re.sub(
+            r"(CURRENT_PROJECT_VERSION\s*=\s*)\d+;", rf"\g<1>{new_build};", block
+        )
+        return block
+
+    new_content = re.sub(config_pattern, update_block, content, flags=re.DOTALL)
+
+    with open(pbxproj_path, "w", encoding="utf-8") as f:
+        f.write(new_content)
+
+    print(
+        f"{action} CURRENT_PROJECT_VERSION: {current_build} -> {new_build} in {config_name} configuration"
+    )
+    return True, new_build
+
+
+def main():
+    parser = argparse.ArgumentParser(
+        description="Update CURRENT_PROJECT_VERSION in Xcode project"
+    )
+    parser.add_argument("pbxproj", help="Path to project.pbxproj file")
+    parser.add_argument(
+        "--config-name",
+        required=True,
+        help="Configuration name (e.g., 'Release', 'DevCI')",
+    )
+    parser.add_argument(
+        "--build-number",
+        type=int,
+        help="Set build number to this value (if not provided, will increment current value)",
+    )
+    parser.add_argument(
+        "--output-github",
+        action="store_true",
+        help="Output in GitHub Actions format to GITHUB_OUTPUT",
+    )
+
+    args = parser.parse_args()
+
+    try:
+        success, new_build = update_build_number(
+            args.pbxproj, args.config_name, args.build_number
+        )
+
+        if args.output_github and os.environ.get("GITHUB_OUTPUT"):
+            with open(os.environ["GITHUB_OUTPUT"], "a") as f:
+                f.write(f"new_build={new_build}\n")
+                f.write(f"build_updated=true\n")
+
+    except Exception as e:
+        print(f"Error: {e}", file=sys.stderr)
+        sys.exit(1)
+
+
+if __name__ == "__main__":
+    main()

.github/workflows/pull_request.yml

@@ -2,9 +2,6 @@ name: Build and Test on PR
 
 on:
   pull_request:
-  push:
-    branches:
-      - "feat/fastlane-ci"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}

.github/workflows/push_develop.yml

@@ -1,12 +1,22 @@
-name: Distribute to Firebase (develop)
+name: Distribute to Firebase
 
 on:
   push:
-    branches: [develop]
+    branches: 
+      - 'develop'
+      - 'feat/fastlane-ci'
 
 env:
+  IOS_BUNDLE_ID: "io.novafoundation.novawallet.dev"
+  IOS_EXTENSION_BUNDLE_ID: "io.novafoundation.novawallet.dev.NovaPushNotificationServiceExtension"
+  PROVISIONING_PROFILE_SPECIFIER: "match AdHoc io.novafoundation.novawallet.dev"
+  EXTENSION_PROVISIONING_PROFILE_SPECIFIER: "match AdHoc io.novafoundation.novawallet.dev.NovaPushNotificationServiceExtension"
+  CODE_SIGN_IDENTITY: "Apple Distribution"
+  EXPORT_METHOD: "ad-hoc"
+  FASTLANE_CONFIGURATION: "Dev"
   BUILD_NUMBER: ${{ github.run_number }}
-  FIREBASE_GROUPS: dev-team
+  #FIREBASE_GROUPS: dev-team
+  FIREBASE_GROUPS: ci-test 
   RELEASE_NOTES: ${{ github.event.head_commit.message }}
   RUN_IN_CI: true
 
@@ -27,11 +37,16 @@ jobs:
           scw_default_project_id: ${{ secrets.SCW_DEFAULT_PROJECT_ID }}
           scw_default_organization_id: ${{ secrets.SCW_DEFAULT_ORGANIZATION_ID }}
 
-      - name: Set app version if missing
+      - name: Update build number
+        env:
+          PBXPROJ_PATH: novawallet.xcodeproj/project.pbxproj
         run: |
-          if [ -z "$APP_VERSION" ] && [ -n "$IOS_APP_VERSION" ]; then
-            echo "APP_VERSION=$IOS_APP_VERSION" >> $GITHUB_ENV
-          fi
+          set -euo pipefail
+
+          echo "Setting build number to ${{ env.BUILD_NUMBER }} in Dev configuration..."
+          python3 .github/scripts/update_build_number.py "${PBXPROJ_PATH}" \
+            --config-name "Dev" \
+            --build-number ${{ env.BUILD_NUMBER }}
 
       - name: Distribute to Firebase via fastlane
         run: bundle exec fastlane distribute_app_to_firebase release_notes:"${{ env.RELEASE_NOTES }}"