Skip to content

Commit 08f4299

Browse files
committed
fix: Passing custom suggestors on when recursin over suggestor definitions
1 parent a4f0072 commit 08f4299

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

ProcessOptimizer/XpyriMentor/suggestors/suggestor_factory.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import logging
2+
from functools import partial
23
from typing import Any, Union, Optional
34

45
import numpy as np
@@ -61,6 +62,9 @@ def suggestor_factory(
6162
* suggestors [`dict[str, CreatableSuggestor] | None`]:
6263
A dictionary of available suggestors. The built-in suggestors will be added.
6364
"""
65+
# To make sure we supply the correct suggestors when recursing. All other inputs
66+
# could conceivably change, so we only fix suggestors.
67+
forward_suggestor_factory = partial(suggestor_factory, suggestors=suggestors)
6468
if suggestors is None:
6569
suggestors = {}
6670
# For the keys not present in suggestors, add the built-in suggestors
@@ -84,7 +88,7 @@ def suggestor_factory(
8488
raise ValueError(f"Unknown suggestor name: {suggestor_type}")
8589
return suggestors[suggestor_type].create_from_definition(
8690
space=space,
87-
suggestor_factory=suggestor_factory,
91+
suggestor_factory=forward_suggestor_factory,
8892
definition=definition,
8993
n_objectives=n_objectives,
9094
rng=rng,

0 commit comments

Comments
 (0)