Fix YAML importer to preserve shell control structures as template literals

Author: noxify

.changeset/shell-control-structures.md

@@ -0,0 +1,30 @@
+---
+"@noxify/gitlab-ci-builder": patch
+---
+
+Fix script parser to preserve shell control structures
+
+The YAML importer now correctly detects and preserves shell control structures (if/then/else/fi, for/do/done, while/do/done, until/do/done, case/esac) as template literals instead of splitting them into separate array elements.
+
+Previously, multi-line scripts with control structures were incorrectly split:
+
+```typescript
+// Before (incorrect)
+script: ['if [ "$VAR" = "true" ]; then', 'echo "yes"', "else", 'echo "no"', "fi"]
+```
+
+Now they are preserved as cohesive blocks:
+
+```typescript
+// After (correct)
+script: [
+  `if [ "$VAR" = "true" ]; then
+  echo "yes"
+else
+  echo "no"
+fi
+`,
+]
+```
+
+This ensures shell scripts with control flow are generated correctly and maintain their intended structure.

src/import.ts

@@ -213,9 +213,19 @@ function formatScriptValue(value: unknown): string {
     /(?<!<)<(?!<)/, // Redirect input (but not <<) - negative lookbehind and lookahead
   ]
 
+  // Check for shell control structures (if/then/else/fi, case/esac, for/do/done, while/do/done)
+  const shellControlStructures = [
+    /\bif\b.*\bthen\b/s, // if-then
+    /\bcase\b.*\besac\b/s, // case-esac
+    /\bfor\b.*\bdo\b/s, // for-do
+    /\bwhile\b.*\bdo\b/s, // while-do
+    /\buntil\b.*\bdo\b/s, // until-do
+  ]
+
   const hasShellOperators = shellOperatorPatterns.some((pattern) => pattern.test(value))
+  const hasControlStructure = shellControlStructures.some((pattern) => pattern.test(value))
 
-  if (hasShellOperators) {
+  if (hasShellOperators || hasControlStructure) {
     // Keep as template literal to preserve exact formatting
     // Escape backticks and ${} in the string
     const escaped = value.replace(/`/g, "\\`").replace(/\$\{/g, "\\${")
@@ -311,8 +321,16 @@ function formatValue(value: unknown, indentLevel: number, addExtraIndent = false
                   /&>/, // Redirect both
                   /(?<!<)<(?!<)/, // Redirect input (but not <<)
                 ]
+                const shellControlStructures = [
+                  /\bif\b.*\bthen\b/s, // if-then
+                  /\bcase\b.*\besac\b/s, // case-esac
+                  /\bfor\b.*\bdo\b/s, // for-do
+                  /\bwhile\b.*\bdo\b/s, // while-do
+                  /\buntil\b.*\bdo\b/s, // until-do
+                ]
                 const hasShellOperators = shellOperatorPatterns.some((p) => p.test(item))
-                if (!hasShellOperators) {
+                const hasControlStructure = shellControlStructures.some((p) => p.test(item))
+                if (!hasShellOperators && !hasControlStructure) {
                   const linesSplit = item
                     .split("\n")
                     .map((l) => l.trim())

tests/import.test.ts

@@ -274,6 +274,70 @@ build:
       expect(ts).toContain('"npm run build"')
       expect(ts).toContain('echo \\"Done\\"')
     })
+
+    it("should preserve shell control structures (if/then/else/fi)", () => {
+      const yaml = `
+deploy:
+  script:
+    - |
+      if [ "$MANUAL_PROD_DEPLOYMENT" = "true" ]; then
+        echo "🚨 MANUAL PRODUCTION DEPLOYMENT TRIGGERED 🚨"
+      else
+        echo "📦 Automated production deployment via changeset release"
+      fi
+`
+
+      const ts = fromYaml(yaml)
+
+      expect(ts).toContain('config.job("deploy",')
+      // Should be preserved as a template literal, not split into array
+      expect(ts).toContain("if [")
+      expect(ts).toContain("then")
+      expect(ts).toContain("else")
+      expect(ts).toContain("fi")
+      // Should be in a single script item (template literal in array)
+      expect(ts).toMatch(/script: \[`[\s\S]*if \[[\s\S]*then[\s\S]*else[\s\S]*fi[\s\S]*`\]/)
+    })
+
+    it("should preserve shell for loops", () => {
+      const yaml = `
+job:
+  script:
+    - |
+      for i in 1 2 3; do
+        echo "Item $i"
+      done
+`
+
+      const ts = fromYaml(yaml)
+
+      expect(ts).toContain("for i in")
+      expect(ts).toContain("do")
+      expect(ts).toContain("done")
+      expect(ts).toMatch(/script: \[`[\s\S]*for[\s\S]*do[\s\S]*done[\s\S]*`\]/)
+    })
+
+    it("should preserve shell case statements", () => {
+      const yaml = `
+job:
+  script:
+    - |
+      case $ENV in
+        prod)
+          echo "Production"
+          ;;
+        dev)
+          echo "Development"
+          ;;
+      esac
+`
+
+      const ts = fromYaml(yaml)
+
+      expect(ts).toContain("case")
+      expect(ts).toContain("esac")
+      expect(ts).toMatch(/script: \[`[\s\S]*case[\s\S]*esac[\s\S]*`\]/)
+    })
   })
 
   describe("importYamlFile()", () => {