Fix YAML import to flatten multi-line script blocks and prevent nested arrays

Author: noxify

.changeset/fix-script-nested-array.md

@@ -0,0 +1,8 @@
+---
+"@noxify/gitlab-ci-builder": patch
+---
+
+Fix regression in YAML import script formatting where multi-line simple script blocks produced a nested array structure (`script: [[...]]`) instead of a flat array (`script: [ ... ]`).
+
+The importer now flattens multi-line simple commands correctly and preserves template literals only when shell operators (pipes, heredoc, redirects, continuations) are present.
+

src/import.ts

@@ -234,10 +234,59 @@ function formatValue(value: unknown, indentLevel: number): string {
       // Special handling for script-related properties
       const scriptProperties = ["script", "before_script", "after_script"]
       if (scriptProperties.includes(k)) {
-        // For script arrays, format each element intelligently
+        // For script arrays, format each element intelligently and FLATTEN
         if (Array.isArray(v)) {
-          const formattedScripts = v.map((item) => formatScriptValue(item))
-          return `${indent}${key}: [${formattedScripts.join(", ")}]`
+          const flattened: string[] = []
+          for (const item of v) {
+            if (typeof item === "string") {
+              // Detect simple multi-line string without shell operators and split into lines
+              const hasNewline = item.includes("\n")
+              if (hasNewline) {
+                const shellOperatorPatterns = [
+                  /\\\n/, // Line continuation
+                  /<</, // Heredoc
+                  /(?<!\|)\|(?!\|)/, // Pipe (but not ||)
+                  />>?/, // Redirect output
+                  /2>/, // Redirect stderr
+                  /&>/, // Redirect both
+                  /(?<!<)<(?!<)/, // Redirect input (but not <<)
+                ]
+                const hasShellOperators = shellOperatorPatterns.some((p) => p.test(item))
+                if (!hasShellOperators) {
+                  const linesSplit = item
+                    .split("\n")
+                    .map((l) => l.trim())
+                    .filter((l) => l.length > 0)
+                  if (linesSplit.length > 0) {
+                    for (const line of linesSplit) {
+                      flattened.push(JSON.stringify(line))
+                    }
+                    continue
+                  }
+                }
+              }
+            }
+            const formatted = formatScriptValue(item)
+            // If formatted result itself looks like an array literal ["..."] we should expand it
+            if (/^\[(?:.|\n)*\]$/.test(formatted)) {
+              // Attempt to parse safely by wrapping in JSON (replace single backticks/template etc.)
+              try {
+                // Replace trailing commas if any and parse as JSON after ensuring double quotes
+                const jsonCandidate = formatted
+                const parsed = JSON.parse(jsonCandidate)
+                if (Array.isArray(parsed)) {
+                  for (const inner of parsed) {
+                    flattened.push(JSON.stringify(inner))
+                  }
+                  continue
+                }
+              } catch {
+                // Fallback: just push formatted string literal as is
+              }
+            }
+            flattened.push(formatted)
+          }
+          return `${indent}${key}: [${flattened.join(", ")}]`
         }
         return `${indent}${key}: ${formatScriptValue(v)}`
       }

tests/script-formatting.test.ts

@@ -23,9 +23,8 @@ test:
       echo "step3"
 `
     const result = fromYaml(yaml)
-    expect(result).toContain(
-      'script: [["echo \\"step1\\"", "echo \\"step2\\"", "echo \\"step3\\""]]',
-    )
+    expect(result).toContain('script: ["echo \\"step1\\"", "echo \\"step2\\"", "echo \\"step3\\""]')
+    expect(result).not.toContain("script: [[")
   })
 
   it("should preserve line continuation with backslash as template literal", () => {
@@ -105,8 +104,9 @@ test:
 `
     const result = fromYaml(yaml)
     expect(result).toContain('script: ["echo \\"simple\\"",')
-    expect(result).toContain('["echo \\"multi1\\"", "echo \\"multi2\\""]')
+    expect(result).toContain('"echo \\"multi1\\"", "echo \\"multi2\\""')
     expect(result).toContain("`complex")
+    expect(result).not.toContain("script: [[")
   })
 
   it("should handle before_script with shell operators", () => {
@@ -120,7 +120,9 @@ test:
 `
     const result = fromYaml(yaml)
     expect(result).toContain("before_script:")
-    expect(result).toContain('["mkdir ~/.npm-global", "export PATH=$PATH:~/.npm-global/bin"')
+    expect(result).toContain(
+      '"mkdir ~/.npm-global", "export PATH=$PATH:~/.npm-global/bin", "npm i -g [email protected]"',
+    )
   })
 
   it("should handle after_script with continuations", () => {