Stop include data source connection string in service provider hashcode (#3501)

Fixes #3498

Author: roji

src/EFCore.PG/Infrastructure/Internal/NpgsqlOptionsExtension.cs

@@ -486,11 +486,6 @@ public override int GetServiceProviderHashCode()
                     hashCode.Add(userRangeDefinition);
                 }
 
-                if (Extension.DataSource is not null)
-                {
-                    hashCode.Add(Extension.DataSource.ConnectionString);
-                }
-
                 hashCode.Add(Extension.AdminDatabase);
                 hashCode.Add(Extension.PostgresVersion);
                 hashCode.Add(Extension.UseRedshift);

test/EFCore.PG.Tests/NpgsqlDbContextOptionsExtensionsTest.cs

@@ -116,5 +116,19 @@ public void Service_collection_extension_method_can_configure_npgsql_options(boo
         }
     }
 
+    [ConditionalFact]
+    public void Varying_data_source_connection_strings_do_not_cause_multiple_service_providers()
+    {
+        for (var i = 0; i < 21; i++)
+        {
+            var optionsBuilder = new DbContextOptionsBuilder<DbContext>();
+            var dataSource = NpgsqlDataSource.Create($"Host=localhost;Database={i};Include Error Detail=true;Username=admin;Password=admin");
+            optionsBuilder.UseNpgsql(dataSource);
+
+            using var context = new ApplicationDbContext(optionsBuilder.Options);
+            _ = context.Model;
+        }
+    }
+
     private class ApplicationDbContext(DbContextOptions options) : DbContext(options);
 }