Crashing when adding multiple effects

[macramole]

Hi, long time since my last message. I hope everything is ok.

I have an array of Patchable called effects where each one is actually an effect (BasiVerb, VAFilter, etc). So it represents a "daisy chain" of effects.

I'm adding and removing effects on the fly and when adding I experiment random crashes. My guess is some method I'm using is not thread safe.

The code is pretty simple:

void AudioEffects::addEffect(EffectUI *newEffect)
{
    effects.push_back(newEffect);

    if ( effects.size() == 1 ) {
        nodeIn0.disconnectOut();
        nodeIn1.disconnectOut();
        nodeOut0.disconnectIn();
        nodeOut1.disconnectIn();

        nodeIn0 >> effects[0]->channelOut(0) >> nodeOut0;
        nodeIn1 >> effects[0]->channelOut(1) >> nodeOut1;
    } else {
        int last = effects.size() - 1;
        effects[ last - 1 ]->disconnectOut();
        nodeOut0.disconnectIn();
        nodeOut1.disconnectIn();

        effects[ last - 1 ]->channelOut(0) >> effects[ last ]->channelIn(0);
        effects[ last - 1 ]->channelOut(1) >> effects[ last ]->channelIn(1);

        effects[ last ]->channelOut(0) >> nodeOut0;
        effects[ last ]->channelOut(1) >> nodeOut1;
    }
}

nodeIn0 and nodeIn1 are just PatchNodes.
AudioEffects is also a Patchable and is part of a larger pipeline that includes two Samplers and multiple Amps

I've tried:

• unpatching everything and then patching again
• stopping audio engine and restarting. This prevent crashes but has two issues: a short hiccup and JACK being disconnected and connected causing manually set "virtual cables" to not reconnect.

I hope you can point me in the right direction, thanks

[npisanti]

I'm sorry but there is no solution for this, as the patch operator >> is not thread-safe, just a few ofxPDSP methods are (only for metering and control).

Making patching thread-safe would require pretty much a big rewrite of ofxPDSP that is not currently planned.

[macramole]

I understand. Thanks a lot for the reply

…

-- leandrogarber.info El lun, 16 ago 2021 a las 13:17, Nicola Pisanti ***@***.***>) escribió:

I'm sorry but there is no solution for this, as the patch operator >> is not thread-safe, just a few ofxPDSP methods are (only for metering and control). Making patching thread-safe would require pretty much a big rewrite of ofxPDSP that is not currently planned. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#70 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWH6OLUG62RKZNADZQJZGTT5E22FANCNFSM5A43BZQA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .