fix: logs and env urls empty on finishing a deployment (#3)

* fix: logs and environment url

* fix: logs and environment url

Author: radiantspace

dist/index.js

@@ -3603,7 +3603,7 @@ function run() {
                 break;
             case 'finish':
                 try {
-                    yield finish_1.finish(client, Number(deploymentId), status, logsUrl, environmentUrl);
+                    yield finish_1.finish(client, Number(deploymentId), status);
                 }
                 catch (error) {
                     core.error(error);
@@ -3658,9 +3658,12 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.finish = void 0;
 const github_1 = __webpack_require__(469);
-function finish(client, deploymentId, status, logUrl, environmentUrl) {
+function finish(client, deploymentId, status) {
     return __awaiter(this, void 0, void 0, function* () {
-        const statusResult = yield client.repos.createDeploymentStatus(Object.assign(Object.assign({}, github_1.context.repo), { deployment_id: deploymentId, state: status, log_url: logUrl, environment_url: environmentUrl }));
+        const statuses = yield client.repos.listDeploymentStatuses(Object.assign(Object.assign({}, github_1.context.repo), { deployment_id: deploymentId }));
+        const lastStatus = statuses.data.sort((a, b) => a.id - b.id).slice(-1)[0];
+        console.log(`last status for deployment_id '${deploymentId}': ${JSON.stringify(lastStatus, null, 2)}`);
+        const statusResult = yield client.repos.createDeploymentStatus(Object.assign(Object.assign({}, github_1.context.repo), { deployment_id: deploymentId, state: status, environment_url: lastStatus.environment_url, log_url: lastStatus.log_url }));
         console.log(`created deployment status: ${JSON.stringify(statusResult.data, null, 2)}`);
     });
 }
@@ -8668,7 +8671,7 @@ function invalidatePreviousDeployments(client, environment) {
             // invalidate the deployment
             if ((lastStatus === null || lastStatus === void 0 ? void 0 : lastStatus.state) === 'success') {
                 console.log(`invalidating deployment: ${JSON.stringify(deployment, null, 2)}`);
-                yield client.repos.createDeploymentStatus(Object.assign(Object.assign({}, github_1.context.repo), { deployment_id: deployment.id, state: 'inactive' }));
+                yield client.repos.createDeploymentStatus(Object.assign(Object.assign({}, github_1.context.repo), { deployment_id: deployment.id, state: 'inactive', environment_url: lastStatus.environment_url, log_url: lastStatus.log_url }));
             }
         })));
     });

src/create.ts

@@ -33,7 +33,9 @@ async function invalidatePreviousDeployments (
         await client.repos.createDeploymentStatus({
           ...context.repo,
           deployment_id: deployment.id,
-          state: 'inactive'
+          state: 'inactive',
+          environment_url: lastStatus.environment_url,
+          log_url: lastStatus.log_url
         })
       }
     })

src/finish.ts

@@ -4,16 +4,28 @@ import { DeploymentStatus } from './deployment-status'
 export async function finish (
   client: GitHub,
   deploymentId: number,
-  status: DeploymentStatus,
-  logUrl: string,
-  environmentUrl: string
+  status: DeploymentStatus
 ): Promise<void> {
+  const statuses = await client.repos.listDeploymentStatuses({
+    ...context.repo,
+    deployment_id: deploymentId
+  })
+
+  const lastStatus = statuses.data.sort((a, b) => a.id - b.id).slice(-1)[0]
+  console.log(
+    `last status for deployment_id '${deploymentId}': ${JSON.stringify(
+      lastStatus,
+      null,
+      2
+    )}`
+  )
+
   const statusResult = await client.repos.createDeploymentStatus({
     ...context.repo,
     deployment_id: deploymentId,
     state: status,
-    log_url: logUrl,
-    environment_url: environmentUrl
+    environment_url: lastStatus.environment_url,
+    log_url: lastStatus.log_url
   })
   console.log(`created deployment status: ${JSON.stringify(statusResult.data, null, 2)}`)
 }

src/main.ts

@@ -102,9 +102,7 @@ export async function run (): Promise<void> {
         await finish(
           client,
           Number(deploymentId),
-          status,
-          logsUrl,
-          environmentUrl
+          status
         )
       } catch (error) {
         core.error(error)

tests/main.test.ts

@@ -85,7 +85,7 @@ describe('create', () => {
 
     const postDeployment = nock('https://api.github.com')
       .post('/repos/owner/repo/deployments')
-      .reply(400, {"resource":"DeploymentStatus","code":"custom","field":"environment_url","message":"environment_url must use http(s) scheme"})
+      .reply(400, { "resource": "DeploymentStatus", "code": "custom", "field": "environment_url", "message": "environment_url must use http(s) scheme" })
 
     // act
     try {
@@ -114,6 +114,7 @@ describe('finish', () => {
     inputs = {
       'token': 'fake-token',
       'type': 'finish',
+      'deployment_id': '42'
     }
     inputSpy = jest.spyOn(core, 'getInput')
     inputSpy.mockImplementation(name => inputs[name])
@@ -130,14 +131,19 @@ describe('finish', () => {
 
   it('200', async () => {
     // arrange
+    const listDeploymentStatus = nock('https://api.github.com')
+      .get('/repos/owner/repo/deployments/42/statuses')
+      .reply(200, [{ id: 10, environment_url: 'http://env.url', log_url: 'http://logs.url' }])
+
     const postDeploymentStatus = nock('https://api.github.com')
-      .post('/repos/owner/repo/deployments/0/statuses')
+      .post('/repos/owner/repo/deployments/42/statuses')
       .reply(200, postStatusReply)
 
     // act
     await main.run()
 
     // assert
+    listDeploymentStatus.done()
     postDeploymentStatus.done()
   })
 })