attempt to fix flag output changes

Author: reggi

docs/lib/index.js

@@ -62,7 +62,7 @@ const getCommandByDoc = (docFile, docExt, commandLoader = defaultCommandLoader)
   if (name === 'npm') {
     return {
       name,
-      definitions: {},
+      definitions: [],
       usage: 'npm',
     }
   }

docs/test/index.js

@@ -812,7 +812,7 @@ description: Test command without params
     const commandLoader = createCommandLoader({
       'testcmd-empty-defs': {
         usage: ['<pkg>'],
-        definitions: {},
+        definitions: [],
       },
     })
 

lib/base-cmd.js

@@ -68,7 +68,6 @@ class BaseCommand {
     }
 
     if (cmdDefs) {
-      const cmdDefsKeys = new Set(cmdDefs.map(d => d.key))
       let results = ''
       let line = ''
       for (const def of cmdDefs) {
@@ -101,9 +100,6 @@ class BaseCommand {
       if (cmdDefs.length > 0 && includeDescriptions) {
         fullUsage.push('')
         for (const def of cmdDefs) {
-          if (seenExclusive.has(def.key) && !cmdDefsKeys.has(def.key)) {
-            continue
-          }
           if (def.description) {
             const desc = def.description.trim().split('\n')[0]
             const shortcuts = def.short ? `-${def.short}|` : ''

tap-snapshots/test/lib/commands/install.js.test.cjs

@@ -134,7 +134,7 @@ silly logfile done cleaning log files
 verbose stack Error: The developer of this package has specified the following through devEngines
 verbose stack Invalid devEngines.runtime
 verbose stack Invalid name "nondescript" does not match "node" for "runtime"
-verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:273:27)
+verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:244:27)
 verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:310:7)
 verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:209:9)
 error code EBADDEVENGINES
@@ -199,7 +199,7 @@ warn EBADDEVENGINES }
 verbose stack Error: The developer of this package has specified the following through devEngines
 verbose stack Invalid devEngines.runtime
 verbose stack Invalid name "nondescript" does not match "node" for "runtime"
-verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:273:27)
+verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:244:27)
 verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:310:7)
 verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:209:9)
 error code EBADDEVENGINES
@@ -225,7 +225,7 @@ silly logfile done cleaning log files
 verbose stack Error: The developer of this package has specified the following through devEngines
 verbose stack Invalid devEngines.runtime
 verbose stack Invalid name "nondescript" does not match "node" for "runtime"
-verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:273:27)
+verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:244:27)
 verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:310:7)
 verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:209:9)
 error code EBADDEVENGINES

workspaces/config/test/index.js

@@ -57,7 +57,7 @@ t.equal(typeDefs, RealConfig.typeDefs, 'exposes type definitions')
 t.test('construct with no settings, get default values for stuff', t => {
   const npmPath = t.testdir()
   const c = new Config({
-    definitions: {},
+    definitions: [],
     npmPath,
   })