fix: adds registry.publish

Author: reggi

mock-registry/lib/index.js

@@ -351,13 +351,30 @@ class MockRegistry {
   }
 
   // full unpublish of an entire package
-  async unpublish ({ manifest }) {
+  unpublish ({ manifest }) {
     let nock = this.nock
     const spec = npa(manifest.name)
     nock = nock.delete(this.fullPath(`/${spec.escapedName}/-rev/${manifest._rev}`)).reply(201)
     return nock
   }
 
+  publish (name, {
+    packageJson, access, noPut, putCode, manifest, packuments,
+  } = {}) {
+    // this getPackage call is used to get the latest semver version before publish
+    if (manifest) {
+      this.getPackage(name, { code: 200, resp: manifest })
+    } else if (packuments) {
+      this.getPackage(name, { code: 200, resp: this.manifest({ name, packuments }) })
+    } else {
+      // assumes the package does not exist yet and will 404 x2 from pacote.manifest
+      this.getPackage(name, { times: 2, code: 404 })
+    }
+    if (!noPut) {
+      this.putPackage(name, { code: putCode, packageJson, access })
+    }
+  }
+
   getPackage (name, { times = 1, code = 200, query, resp = {} }) {
     let nock = this.nock
     nock = nock.get(`/${npa(name).escapedName}`).times(times)
@@ -372,6 +389,48 @@ class MockRegistry {
     this.nock = nock
   }
 
+  putPackage (name, { code = 200, resp = {}, ...putPackagePayload }) {
+    this.nock.put(`/${npa(name).escapedName}`, body => {
+      return this.#tap.match(body, this.putPackagePayload({ name, ...putPackagePayload }))
+    }).reply(code, resp)
+  }
+
+  putPackagePayload (opts) {
+    const pkg = opts.packageJson
+    const name = opts.name || pkg?.name
+    const registry = opts.registry || pkg?.publishConfig?.registry || 'https://registry.npmjs.org'
+    const access = opts.access || null
+
+    const nameProperties = !name ? {} : {
+      _id: name,
+      name: name,
+    }
+
+    const packageProperties = !pkg ? {} : {
+      'dist-tags': { latest: pkg.version },
+      versions: {
+        [pkg.version]: {
+          _id: `${pkg.name}@${pkg.version}`,
+          dist: {
+            shasum: /\.*/,
+            tarball:
+    `http://${new URL(registry).host}/${pkg.name}/-/${pkg.name}-${pkg.version}.tgz`,
+          },
+          ...pkg,
+        },
+      },
+      _attachments: {
+        [`${pkg.name}-${pkg.version}.tgz`]: {},
+      },
+    }
+
+    return {
+      access,
+      ...nameProperties,
+      ...packageProperties,
+    }
+  }
+
   getTokens (tokens) {
     return this.nock.get('/-/npm/v1/tokens')
       .reply(200, {

test/fixtures/mock-npm.js

@@ -2,7 +2,6 @@ const os = require('node:os')
 const fs = require('node:fs').promises
 const fsSync = require('node:fs')
 const path = require('node:path')
-const npmFetch = require('npm-registry-fetch')
 const tap = require('tap')
 const mockLogs = require('./mock-logs.js')
 const mockGlobals = require('@npmcli/mock-globals')
@@ -464,74 +463,8 @@ function workspaceMock (t, opts) {
   }
 }
 
-const mockNpmRegistryFetch = (tags) => {
-  const fetchOpts = {}
-  const getRequest = async (url, opts) => {
-    if (fetchOpts[url]) {
-      fetchOpts[url].push(opts)
-    } else {
-      fetchOpts[url] = [opts]
-    }
-    const find = ({ ...tags })[url]
-    if (!find) {
-      throw new Error(`no npm-registry-fetch mock for ${url}`)
-    }
-    if (typeof find === 'function') {
-      return find()
-    }
-    return find
-  }
-  const nrf = async (url, opts) => {
-    return {
-      json: () => getRequest(url, opts),
-    }
-  }
-  const mock = Object.assign(nrf, npmFetch, { json: getRequest })
-  const mocks = { 'npm-registry-fetch': mock }
-  const getOpts = (url) => fetchOpts[url]
-  return { mocks, mock, fetchOpts, getOpts }
-}
-
-const putPackagePayload = (opts) => {
-  const package = opts.packageJson
-  const name = opts.name || package?.name
-  const registry = opts.registry || package?.publishConfig?.registry || 'https://registry.npmjs.org'
-  const access = opts.access || null
-
-  const nameProperties = !name ? {} : {
-    _id: name,
-    name: name,
-  }
-
-  const packageProperties = !package ? {} : {
-    'dist-tags': { latest: package.version },
-    versions: {
-      [package.version]: {
-        _id: `${package.name}@${package.version}`,
-        dist: {
-          shasum: /\.*/,
-          tarball:
-  `http://${new URL(registry).host}/${package.name}/-/${package.name}-${package.version}.tgz`,
-        },
-        ...package,
-      },
-    },
-    _attachments: {
-      [`${package.name}-${package.version}.tgz`]: {},
-    },
-  }
-
-  return {
-    access,
-    ...nameProperties,
-    ...packageProperties,
-  }
-}
-
 module.exports = setupMockNpm
 module.exports.load = setupMockNpm
 module.exports.setGlobalNodeModules = setGlobalNodeModules
 module.exports.loadNpmWithRegistry = loadNpmWithRegistry
 module.exports.workspaceMock = workspaceMock
-module.exports.mockNpmRegistryFetch = mockNpmRegistryFetch
-module.exports.putPackagePayload = putPackagePayload