chore: convert all test to mockNpm

This also uses more consistent snapshot cleaning where possible.

Note that this is an iterative step for our tests and does not implement
`MockRegistry` for them, so many of them still mock important
functionality that should be tested. This refactor to `mockNpm` should
make it easier to adopt `MockRegistry` as we see fit.

Author: lukekarrys

tap-snapshots/test/lib/commands/audit.js.test.cjs

@@ -123,7 +123,7 @@ audited 1 package in xxx
 
 1 package has an invalid registry signature:
 
-@npmcli/[email protected] (https://verdaccio-clone.org)
+@npmcli/[email protected] (https://verdaccio-clone.org/)
 
 Someone might have tampered with this package since it was published on the registry!
 
@@ -134,7 +134,7 @@ audited 1 package in xxx
 
 1 package has a missing registry signature but the registry is providing signing keys:
 
-@npmcli/[email protected] (https://verdaccio-clone.org)
+@npmcli/[email protected] (https://verdaccio-clone.org/)
 `
 
 exports[`test/lib/commands/audit.js TAP audit signatures third-party registry with keys and signatures > must match snapshot 1`] = `

tap-snapshots/test/lib/commands/config.js.test.cjs

@@ -354,7 +354,6 @@ exports[`test/lib/commands/config.js TAP config list with publishConfig > output
 ; "cli" config from command line options
 
 cache = "{NPMDIR}/test/lib/commands/tap-testdir-config-config-list-with-publishConfig-sandbox/cache" 
-location = "project" 
 prefix = "{LOCALPREFIX}" 
 userconfig = "{HOME}/.npmrc" 
 

tap-snapshots/test/lib/commands/dist-tag.js.test.cjs

@@ -10,8 +10,7 @@ exports[`test/lib/commands/dist-tag.js TAP add new tag > should return success m
 `
 
 exports[`test/lib/commands/dist-tag.js TAP add using valid semver range as name > should return success msg 1`] = `
-dist-tag add 1.0.0 to @scoped/[email protected] 
-
+dist-tag add 1.0.0 to @scoped/[email protected]
 `
 
 exports[`test/lib/commands/dist-tag.js TAP ls in current package > should list available tags for current package 1`] = `
@@ -21,8 +20,7 @@ latest: 1.0.0
 `
 
 exports[`test/lib/commands/dist-tag.js TAP ls on missing package > should log no dist-tag found msg 1`] = `
-dist-tag ls Couldn't get dist-tag data for foo@* 
-
+dist-tag ls Couldn't get dist-tag data for foo@*
 `
 
 exports[`test/lib/commands/dist-tag.js TAP ls on named package > should list tags for the specified package 1`] = `
@@ -44,24 +42,21 @@ latest: 2.0.0
 `
 
 exports[`test/lib/commands/dist-tag.js TAP remove existing tag > should log remove info 1`] = `
-dist-tag del c from @scoped/another 
-
+dist-tag del c from @scoped/another
 `
 
 exports[`test/lib/commands/dist-tag.js TAP remove existing tag > should return success msg 1`] = `
 -c: @scoped/[email protected]
 `
 
 exports[`test/lib/commands/dist-tag.js TAP remove non-existing tag > should log error msg 1`] = `
-dist-tag del nonexistent from @scoped/another 
-dist-tag del nonexistent is not a dist-tag on @scoped/another 
-
+dist-tag del nonexistent from @scoped/another
+dist-tag del nonexistent is not a dist-tag on @scoped/another
 `
 
 exports[`test/lib/commands/dist-tag.js TAP set existing version > should log warn msg 1`] = `
-dist-tag add b to @scoped/[email protected] 
-dist-tag add b is already set to version 0.6.0 
-
+dist-tag add b to @scoped/[email protected]
+dist-tag add b is already set to version 0.6.0
 `
 
 exports[`test/lib/commands/dist-tag.js TAP workspaces no args > printed the expected output 1`] = `

tap-snapshots/test/lib/commands/doctor.js.test.cjs

@@ -6,50 +6,50 @@
  */
 'use strict'
 exports[`test/lib/commands/link.js TAP hash character in working directory path > should create a global link to current pkg, even within path with hash 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-hash-character-in-working-directory-path/global-prefix/lib/node_modules/test-pkg-link -> {CWD}/test/lib/commands/tap-testdir-link-hash-character-in-working-directory-path/i_like_#_in_my_paths/test-pkg-link
+{CWD}/global/node_modules/test-pkg-link -> {CWD}/other/i_like_#_in_my_paths/test-pkg-link
 
 `
 
 exports[`test/lib/commands/link.js TAP link global linked pkg to local nm when using args > should create a local symlink to global pkg 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/my-project/node_modules/@myscope/bar -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/global-prefix/lib/node_modules/@myscope/bar
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/my-project/node_modules/@myscope/linked -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/scoped-linked
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/my-project/node_modules/a -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/global-prefix/lib/node_modules/a
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/my-project/node_modules/link-me-too -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/link-me-too
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/my-project/node_modules/test-pkg-link -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-nm-when-using-args/test-pkg-link
+{CWD}/prefix/node_modules/@myscope/bar -> {CWD}/global/node_modules/@myscope/bar
+{CWD}/prefix/node_modules/@myscope/linked -> {CWD}/other/scoped-linked
+{CWD}/prefix/node_modules/a -> {CWD}/global/node_modules/a
+{CWD}/prefix/node_modules/link-me-too -> {CWD}/other/link-me-too
+{CWD}/prefix/node_modules/test-pkg-link -> {CWD}/other/test-pkg-link
 
 `
 
 exports[`test/lib/commands/link.js TAP link global linked pkg to local workspace using args > should create a local symlink to global pkg 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/my-project/node_modules/@myscope/bar -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/global-prefix/lib/node_modules/@myscope/bar
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/my-project/node_modules/@myscope/linked -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/scoped-linked
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/my-project/node_modules/a -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/global-prefix/lib/node_modules/a
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/my-project/node_modules/link-me-too -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/link-me-too
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/my-project/node_modules/test-pkg-link -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/test-pkg-link
-{CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/my-project/node_modules/x -> {CWD}/test/lib/commands/tap-testdir-link-link-global-linked-pkg-to-local-workspace-using-args/my-project/packages/x
+{CWD}/prefix/node_modules/@myscope/bar -> {CWD}/global/node_modules/@myscope/bar
+{CWD}/prefix/node_modules/@myscope/linked -> {CWD}/other/scoped-linked
+{CWD}/prefix/node_modules/a -> {CWD}/global/node_modules/a
+{CWD}/prefix/node_modules/link-me-too -> {CWD}/other/link-me-too
+{CWD}/prefix/node_modules/test-pkg-link -> {CWD}/other/test-pkg-link
+{CWD}/prefix/node_modules/x -> {CWD}/prefix/packages/x
 
 `
 
 exports[`test/lib/commands/link.js TAP link pkg already in global space > should create a local symlink to global pkg 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-link-pkg-already-in-global-space/my-project/node_modules/@myscope/linked -> {CWD}/test/lib/commands/tap-testdir-link-link-pkg-already-in-global-space/scoped-linked
+{CWD}/prefix/node_modules/@myscope/linked -> {CWD}/other/scoped-linked
 
 `
 
 exports[`test/lib/commands/link.js TAP link pkg already in global space when prefix is a symlink > should create a local symlink to global pkg 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-link-pkg-already-in-global-space-when-prefix-is-a-symlink/my-project/node_modules/@myscope/linked -> {CWD}/test/lib/commands/tap-testdir-link-link-pkg-already-in-global-space-when-prefix-is-a-symlink/scoped-linked
+{CWD}/prefix/node_modules/@myscope/linked -> {CWD}/other/scoped-linked
 
 `
 
 exports[`test/lib/commands/link.js TAP link to globalDir when in current working dir of pkg and no args > should create a global link to current pkg 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-link-to-globalDir-when-in-current-working-dir-of-pkg-and-no-args/global-prefix/lib/node_modules/test-pkg-link -> {CWD}/test/lib/commands/tap-testdir-link-link-to-globalDir-when-in-current-working-dir-of-pkg-and-no-args/test-pkg-link
+{CWD}/global/node_modules/test-pkg-link -> {CWD}/prefix
 
 `
 
 exports[`test/lib/commands/link.js TAP link ws to globalDir when workspace specified and no args > should create a global link to current pkg 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-link-ws-to-globalDir-when-workspace-specified-and-no-args/global-prefix/lib/node_modules/a -> {CWD}/test/lib/commands/tap-testdir-link-link-ws-to-globalDir-when-workspace-specified-and-no-args/test-pkg-link/packages/a
+{CWD}/global/node_modules/a -> {CWD}/prefix/packages/a
 
 `
 
 exports[`test/lib/commands/link.js TAP test linked installed as symlinks > linked package should not be installed 1`] = `
-{CWD}/test/lib/commands/tap-testdir-link-test-linked-installed-as-symlinks/prefix/node_modules/mylink -> {CWD}/test/lib/commands/tap-testdir-link-test-linked-installed-as-symlinks/other/mylink
+{CWD}/prefix/node_modules/mylink -> {CWD}/other/mylink
 
 `