Lint and format all code with same configs

Author: lukekarrys

.eslintrc.js

@@ -1,7 +1,8 @@
 module.exports = {
   root: true,
-  ignorePatterns: ['cli/', '.cache/', 'public/'],
+  ignorePatterns: ['.cache/', 'public/'],
   extends: [
+    '@npmcli',
     'react-app',
     // 'react-app/jest',
     'eslint:recommended',
@@ -13,6 +14,7 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    'max-len': 'off',
     'react/prop-types': 'off',
     'primer-react/no-system-props': ['error', {includeUtilityComponents: true}],
   },

.prettierignore

@@ -1,8 +1,9 @@
 **/template-oss/*.json
 **/template-oss/*.yml
-content/
-cli/
-.github/
-package-lock.json
-SECURITY.md
-.reuse/
+/content/
+/.github/
+/package-lock.json
+/SECURITY.md
+/.reuse/
+.nyc_output/
+coverage/

cli/.eslintrc.js

@@ -1,7 +1,7 @@
-const { resolve, relative, join } = require('path')
-const { spawnSync } = require('child_process')
+const {resolve, relative, join} = require('path')
+const {spawnSync} = require('child_process')
 const build = require('../lib/build.js')
-const { nwo } = require('../lib/gh')
+const {nwo} = require('../lib/gh')
 
 // check only build with the current versions instead of checking the registry
 // and also fails if any changes are detected. this is used in CI to make sure
@@ -13,7 +13,7 @@ const contentPath = join(ROOT, 'content/cli')
 const navPath = join(ROOT, 'content/nav.yml')
 
 const checkContent = () => {
-  const status = spawnSync('git', ['status', '--porcelain', contentPath], { encoding: 'utf-8' })
+  const status = spawnSync('git', ['status', '--porcelain', contentPath], {encoding: 'utf-8'})
   if (status.stdout) {
     const msg = [
       `The following untracked changes to ${relative(process.cwd(), contentPath)} were found:`,
@@ -38,7 +38,7 @@ build({
     }
     return console.log('DONE')
   })
-  .catch((e) => {
+  .catch(e => {
     console.error(e)
     process.exit(1)
   })

cli/bin/build.js

@@ -1,4 +1,4 @@
-const { posix } = require('path')
+const {posix} = require('path')
 const fs = require('fs').promises
 const yaml = require('yaml')
 const semver = require('semver')
@@ -8,25 +8,24 @@ const log = require('./log')
 
 const DOCS_PATH = 'cli'
 
-const updateNav = async (updates, { nav, path }) => {
-  const variants = updates.map((release) => ({
+const updateNav = async (updates, {nav, path}) => {
+  const variants = updates.map(release => ({
     title: release.title,
     shortName: release.id,
     url: release.url,
     default: release.default,
     children: release.nav,
   }))
 
-  const index = nav.contents.items
-    .findIndex(n => posix.basename(n.get('url')) === DOCS_PATH)
+  const index = nav.contents.items.findIndex(n => posix.basename(n.get('url')) === DOCS_PATH)
   const key = [index, 'variants']
   const current = nav.getIn(key)
 
   if (!current) {
     nav.setIn(key, nav.createNode(variants))
   } else {
     for (const variant of variants) {
-      const vIndex = current.items.findIndex((n) => n.get('url') === variant.url)
+      const vIndex = current.items.findIndex(n => n.get('url') === variant.url)
       if (vIndex === -1) {
         nav.addIn(key, nav.createNode(variant))
       } else {
@@ -38,29 +37,24 @@ const updateNav = async (updates, { nav, path }) => {
   return fs.writeFile(path, nav.toString(), 'utf-8')
 }
 
-const getCurrentVersions = (nav) => {
+const getCurrentVersions = nav => {
   // the only place the current versions are stored is in the nav
   const currentSections = nav.find(s => s.url === `/${DOCS_PATH}`).variants
 
-  const currentVersions = currentSections.map((v) => {
-    const version = v.title?.match(/^Version\s(.*?)\s/)[1]
-    return version
-  }).sort(semver.compare)
+  const currentVersions = currentSections
+    .map(v => {
+      const version = v.title?.match(/^Version\s(.*?)\s/)[1]
+      return version
+    })
+    .sort(semver.compare)
 
   return {
     versions: currentVersions,
     latest: currentVersions[currentVersions.length - 1],
   }
 }
 
-const main = async ({
-  loglevel,
-  releases: rawReleases,
-  useCurrent,
-  navPath,
-  contentPath,
-  prerelease,
-}) => {
+const main = async ({loglevel, releases: rawReleases, useCurrent, navPath, contentPath, prerelease}) => {
   /* istanbul ignore next */
   if (loglevel) {
     log.on(loglevel)
@@ -72,32 +66,40 @@ const main = async ({
 
   const pack = useCurrent
     ? getCurrentVersions(navData)
-    : await pacote.packument('npm', { preferOnline: true }).then(p => ({
-      versions: Object.keys(p.versions),
-      latest: p['dist-tags'].latest,
-    }))
-
-  const releaseVersions = rawReleases.map(release => {
-    const major = Number(release.id.replace(/^v/, ''))
-    const range = `>=${major}.0.0-a <${major + 1}.0.0` // include all prereleases
-    const version = semver.parse(semver.maxSatisfying(pack.versions, range))
-
-    return version && {
-      ...release,
-      version: version.toString(),
-      // the default release is always controlled by the latest dist-tag
-      default: semver.eq(version, pack.latest),
-      prerelease: version.prerelease.length > 0,
-    }
-  }).filter(Boolean)
-
-  const latestRelease = releaseVersions.find(r => r.default) ??
+    : await pacote.packument('npm', {preferOnline: true}).then(p => ({
+        versions: Object.keys(p.versions),
+        latest: p['dist-tags'].latest,
+      }))
+
+  const releaseVersions = rawReleases
+    .map(release => {
+      const major = Number(release.id.replace(/^v/, ''))
+      const range = `>=${major}.0.0-a <${major + 1}.0.0` // include all prereleases
+      const version = semver.parse(semver.maxSatisfying(pack.versions, range))
+
+      return (
+        version && {
+          ...release,
+          version: version.toString(),
+          // the default release is always controlled by the latest dist-tag
+          default: semver.eq(version, pack.latest),
+          prerelease: version.prerelease.length > 0,
+        }
+      )
+    })
+    .filter(Boolean)
+
+  const latestRelease =
+    releaseVersions.find(r => r.default) ??
     releaseVersions.slice(0).sort((a, b) => semver.compare(b.version, a.version))[0]
 
-  const releases = releaseVersions.map((release) => {
-    const type = release.default ? 'Latest Release'
-      : release.prerelease ? 'Prerelease'
-      : semver.gt(release.version, latestRelease.version) ? 'Current Release'
+  const releases = releaseVersions.map(release => {
+    const type = release.default
+      ? 'Latest Release'
+      : release.prerelease
+      ? 'Prerelease'
+      : semver.gt(release.version, latestRelease.version)
+      ? 'Current Release'
       : 'Legacy Release'
 
     return {
@@ -110,12 +112,10 @@ const main = async ({
   })
 
   const updates = await Promise.all(
-    releases.map((r) =>
-      extractRelease(r, { contentPath, baseNav: navData, prerelease })
-    )
-  ).then((r) => r.filter(Boolean))
+    releases.map(r => extractRelease(r, {contentPath, baseNav: navData, prerelease})),
+  ).then(r => r.filter(Boolean))
 
-  await updateNav(updates, { nav: navDoc, path: navPath })
+  await updateNav(updates, {nav: navDoc, path: navPath})
 }
 
 module.exports = main