[Fix Accessibility]: Add tabIndex to VariantItem for improved accessibility #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpg619
commented
Oct 6, 2025
| const VariantItem = ({title, shortName, url, active}) => { | ||
| return ( | ||
| <ActionList.Item state={{scrollUpdate: false}} id={shortName} active={active}> | ||
| <ActionList.Item state={{scrollUpdate: false}} id={shortName} active={active} tabIndex={null}> |
There was a problem hiding this comment.
This is often more reliable for preventing React components from adding unwanted tabindex attributes.
There was a problem hiding this comment.
Pull Request Overview
Fixes accessibility issue with keyboard navigation in the CLI version selector by adding tabIndex attribute to VariantItem components to prevent duplicate focus events.
- Add tabIndex={null} to ActionList.Item to improve keyboard focus order
- Resolves issue where keyboard focus was moving twice on version list items
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
owlstronaut
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshare.-.2025-10-06.10_16_14.AM.mp4