fix(cp): implement errors

Author: everett1992

lib/cp/polyfill.js

@@ -13,28 +13,27 @@
 'use strict';
 
 const {
-  codes: {
-    ERR_FS_CP_DIR_TO_NON_DIR,
-    ERR_FS_CP_EEXIST,
-    ERR_FS_CP_EINVAL,
-    ERR_FS_CP_FIFO_PIPE,
-    ERR_FS_CP_NON_DIR_TO_DIR,
-    ERR_FS_CP_SOCKET,
-    ERR_FS_CP_SYMLINK_TO_SUBDIRECTORY,
-    ERR_FS_CP_UNKNOWN,
-    ERR_FS_EISDIR,
-  },
-} = require('internal/errors');
+  ERR_FS_CP_DIR_TO_NON_DIR,
+  ERR_FS_CP_EEXIST,
+  ERR_FS_CP_EINVAL,
+  ERR_FS_CP_FIFO_PIPE,
+  ERR_FS_CP_NON_DIR_TO_DIR,
+  ERR_FS_CP_SOCKET,
+  ERR_FS_CP_SYMLINK_TO_SUBDIRECTORY,
+  ERR_FS_CP_UNKNOWN,
+  ERR_FS_EISDIR,
+} = require('../errors.js')
+
 const {
-  os: {
+  constants: {
     errno: {
       EEXIST,
       EISDIR,
       EINVAL,
       ENOTDIR,
     }
   }
-} = internalBinding('constants');
+} = require('os')
 const {
   chmod,
   copyFile,
@@ -56,7 +55,7 @@ const {
   sep,
 } = require('path');
 
-async function cpFn(src, dest, opts) {
+async function cp(src, dest, opts) {
   // Warn about using preserveTimestamps on 32-bit node
   if (opts.preserveTimestamps && process.arch === 'ia32') {
     const warning = 'Using the preserveTimestamps option in 32-bit ' +
@@ -375,8 +374,4 @@ async function copyLink(resolvedSrc, dest) {
   return symlink(resolvedSrc, dest);
 }
 
-module.exports = {
-  areIdentical,
-  cpFn,
-  isSrcSubdir,
-};
+module.exports = cp

lib/errors.js

@@ -0,0 +1,107 @@
+'use strict'
+
+// adapted from node's internal/errors
+// https://github.com/nodejs/node/blob/c8a04049be96d2a6d625d4417df095fc0f3eaa7b/lib/internal/errors.js
+
+// close copy of node's internal SystemError class.
+class SystemError {
+  constructor(code, prefix, context) {
+    // XXX context.code is undefined in all constructors used in cp/polyfill
+    // that may be a bug copied from node
+    // await require('fs/promises').cp('error.ts', 'error.ts')
+    //
+    //     Uncaught:
+    //     SystemError [ERR_FS_CP_EINVAL]: Invalid src or dest: cp returned undefined (src and dest cannot be the same) error.ts
+    // maybe the constructor should use `code` not `errno`?
+    // nodejs/node#41104
+    let message = `${prefix}: ${context.syscall} returned ` +
+                  `${context.code} (${context.message})`
+
+    if (context.path !== undefined)
+      message += ` ${context.path}`
+    if (context.dest !== undefined)
+      message += ` => ${context.dest}`
+
+    this.code = code
+    Object.defineProperties(this, {
+      name: {
+        value: 'SystemError',
+        enumerable: false,
+        writable: true,
+        configurable: true,
+      },
+      message: {
+        value: message,
+        enumerable: false,
+        writable: true,
+        configurable: true,
+      },
+      info: {
+        value: context,
+        enumerable: true,
+        configurable: true,
+        writable: false,
+      },
+      errno: {
+        get() { return context.errno },
+        set(value) { context.errno = value },
+        enumerable: true,
+        configurable: true,
+      },
+      syscall: {
+        get() { return context.syscall },
+        set(value) { context.syscall = value },
+        enumerable: true,
+        configurable: true,
+      },
+    })
+
+    if (context.path !== undefined) {
+      Object.defineProperty(this, 'path', {
+        get() { return context.path },
+        set(value) { context.path = value },
+        enumerable: true,
+        configurable: true
+      })
+    }
+
+    if (context.dest !== undefined) {
+      Object.defineProperty(this, 'dest', {
+        get() { return context.dest },
+        set(value) { context.dest = value },
+        enumerable: true,
+        configurable: true
+      })
+    }
+  }
+
+  toString() {
+    return `${this.name} [${this.code}]: ${this.message}`
+  }
+
+  [Symbol.for('nodejs.util.inspect.custom')](_recurseTimes, ctx) {
+    return lazyInternalUtilInspect().inspect(this, {
+      ...ctx,
+      getters: true,
+      customInspect: false
+    })
+  }
+}
+
+function E (code, message) {
+  module.exports[code] = class NodeError extends SystemError {
+    constructor(ctx) {
+      super(code, message, ctx)
+    }
+  }
+}
+
+E('ERR_FS_CP_DIR_TO_NON_DIR', 'Cannot overwrite directory with non-directory')
+E('ERR_FS_CP_EEXIST', 'Target already exists')
+E('ERR_FS_CP_EINVAL', 'Invalid src or dest')
+E('ERR_FS_CP_FIFO_PIPE', 'Cannot copy a FIFO pipe')
+E('ERR_FS_CP_NON_DIR_TO_DIR', 'Cannot overwrite non-directory with directory')
+E('ERR_FS_CP_SOCKET', 'Cannot copy a socket file')
+E('ERR_FS_CP_SYMLINK_TO_SUBDIRECTORY', 'Cannot overwrite symlink in subdirectory of self')
+E('ERR_FS_CP_UNKNOWN', 'Cannot copy an unknown file type')
+E('ERR_FS_EISDIR', 'Path is a directory')