Skip to content

Commit b788931

Browse files
authored
feat: remove custom promisification in favor of fs/promises (#54)
BREAKING CHANGE: this package no longer exports the full set of core fs functions
1 parent e666309 commit b788931

File tree

11 files changed

+32
-58
lines changed

11 files changed

+32
-58
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ polyfills, and extensions, of the core `fs` module.
44

55
## Features
66

7-
- all exposed functions return promises
87
- `fs.cp` polyfill for node < 16.7.0
98
- `fs.withTempDir` added
109

lib/cp/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const fs = require('../fs.js')
1+
const fs = require('fs/promises')
22
const getOptions = require('../common/get-options.js')
33
const node = require('../common/node.js')
44
const polyfill = require('./polyfill.js')

lib/cp/polyfill.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const {
4545
symlink,
4646
unlink,
4747
utimes,
48-
} = require('../fs.js')
48+
} = require('fs/promises')
4949
const {
5050
dirname,
5151
isAbsolute,

lib/fs.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

lib/index.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1+
'use strict'
2+
3+
const cp = require('./cp/index.js')
4+
const withTempDir = require('./with-temp-dir.js')
5+
16
module.exports = {
2-
...require('./fs.js'),
3-
cp: require('./cp/index.js'),
4-
withTempDir: require('./with-temp-dir.js'),
7+
cp,
8+
withTempDir,
59
}

lib/with-temp-dir.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const { join, sep } = require('path')
22

33
const getOptions = require('./common/get-options.js')
4-
const { mkdir, mkdtemp, rm } = require('./fs.js')
4+
const { mkdir, mkdtemp, rm } = require('fs/promises')
55

66
// create a temp directory, ensure its permissions match its parent, then call
77
// the supplied function passing it the path to the directory. clean up after

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"tap": "^16.0.1"
3535
},
3636
"dependencies": {
37-
"@gar/promisify": "^1.1.3",
3837
"semver": "^7.3.5"
3938
},
4039
"engines": {

test/common/file-url-to-path.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

test/cp/index.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
const { stat } = require('fs/promises')
12
const { join } = require('path')
23
const t = require('tap')
34

4-
const fs = require('../../')
5+
const cp = require('../../lib/cp/index.js')
56

67
t.test('can copy a file', async (t) => {
78
const dir = t.testdir({
@@ -10,9 +11,10 @@ t.test('can copy a file', async (t) => {
1011
const src = join(dir, 'file')
1112
const dest = join(dir, 'dest')
1213

13-
await fs.cp(src, dest)
14+
await cp(src, dest)
1415

15-
t.equal(await fs.exists(dest), true, 'dest exits')
16+
const exists = await stat(dest).then(() => true).catch(() => false)
17+
t.equal(exists, true, 'dest exits')
1618
})
1719

1820
t.test('can copy a directory', async (t) => {
@@ -22,7 +24,8 @@ t.test('can copy a directory', async (t) => {
2224
const src = join(dir, 'directory')
2325
const dest = join(dir, 'dest')
2426

25-
await fs.cp(src, dest, { recursive: true })
27+
await cp(src, dest, { recursive: true })
2628

27-
t.equal(await fs.exists(dest), true, 'dest exists')
29+
const exists = await stat(dest).then(() => true).catch(() => false)
30+
t.equal(exists, true, 'dest exists')
2831
})

test/fs.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)