ping: response all data even an error exists (#149)

PR-URL: #149
Credit: @watilde
Reviewed-By: @zkat

Author: watilde

lib/ping.js

@@ -11,11 +11,9 @@ function ping (uri, params, cb) {
   var auth = params.auth
   assert(auth && typeof auth === 'object', 'must pass auth to ping')
 
-  this.request(url.resolve(uri, '-/ping?write=true'), { auth: auth }, function (er, fullData) {
-    if (er) {
-      cb(er)
-    } else if (fullData) {
-      cb(null, fullData)
+  this.request(url.resolve(uri, '-/ping?write=true'), { auth: auth }, function (er, fullData, data, response) {
+    if (er || fullData) {
+      cb(er, fullData, data, response)
     } else {
       cb(new Error('No data received'))
     }

test/ping.js

@@ -74,3 +74,27 @@ test('ping', function (t) {
     t.end()
   })
 })
+
+test('ping 404', function (t) {
+  server.expect('GET', '/-/ping?write=true', function (req, res) {
+    t.equal(req.method, 'GET')
+    res.statusCode = 404
+    res.json({
+      statusCode: 404,
+      error: 'Not Found'
+    })
+  })
+
+  client.ping(common.registry, PARAMS, function (error, found, data, res) {
+    t.same(error.message, 'Not Found : -/ping')
+    var wanted = {
+      statusCode: 404,
+      error: 'Not Found'
+    }
+    t.same(found, wanted)
+    t.same(data, JSON.stringify(wanted))
+    t.same(res.body.toString(), JSON.stringify(wanted))
+    server.close()
+    t.end()
+  })
+})