Skip to content

Commit 777f3dc

Browse files
committed
update impl description
Signed-off-by: Brian DeHamer <[email protected]>
1 parent 7da3739 commit 777f3dc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

accepted/0000-sbom-command.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ While you can effectively generate the same output we’re proposing with this c
5252

5353
## Implementation
5454

55-
The `npm-sbom` command is similar in function to `npm-ls` command and will likely utilize a similar implementation. We’ll use <code>[arborist](https://github.com/npm/cli/tree/latest/workspaces/arborist)</code> to construct the dependency tree and the <code>[treeverse](https://github.com/isaacs/treeverse)</code> library to traverse the tree and assemble the SBOM.
55+
The `npm-sbom` command will use <code>[arborist](https://github.com/npm/cli/tree/latest/workspaces/arborist)</code> to construct the dependency tree for the current project and then invoke `querySelectorAll` to select the set of nodes to be included in the SBOM.
5656

5757
### Errors
5858

59-
When using the `node_modules` to render the SBOM (i.e. when NOT using the `--package-lock-only` flag) and of the following conditions will cause an error to be reported and prevent the SBOM from being generated:
59+
When using the `node_modules` to render the SBOM (i.e. when NOT using the `--package-lock-only` flag) any of the following conditions will cause an error to be reported and prevent the SBOM from being generated:
6060

6161
- Any missing dependencies which are NOT marked as optional
6262
- Any invalid dependencies (e.g. a mismatch between the `package-lock.json` and the `node_modules`)

0 commit comments

Comments
 (0)