Skip to content

Commit d1bb033

Browse files
committed
minor changes to spibar0.xml (descriptions and control)
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com>
1 parent 4a328da commit d1bb033

File tree

1 file changed

+24
-23
lines changed

1 file changed

+24
-23
lines changed

chipsec/cfg/8086/SPI/spibar0.xml

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -77,34 +77,34 @@
7777
</register>
7878

7979
<register name="PR0" type="mmio" bar="SPIBAR" offset="0x84" size="4" desc="Protected Range 0">
80-
<field name="PRB" bit="0" size="15"/>
81-
<field name="RPE" bit="15" size="1"/>
82-
<field name="PRL" bit="16" size="15"/>
83-
<field name="WPE" bit="31" size="1"/>
80+
<field name="PRB" bit="0" size="15" desc="Protected Range Base"/>
81+
<field name="RPE" bit="15" size="1" desc="Read Protection Enabled"/>
82+
<field name="PRL" bit="16" size="15" desc="Protected Range Limit"/>
83+
<field name="WPE" bit="31" size="1" desc="Write Protection Enabled"/>
8484
</register>
8585
<register name="PR1" type="mmio" bar="SPIBAR" offset="0x88" size="4" desc="Protected Range 1">
86-
<field name="PRB" bit="0" size="15"/>
87-
<field name="RPE" bit="15" size="1"/>
88-
<field name="PRL" bit="16" size="15"/>
89-
<field name="WPE" bit="31" size="1"/>
86+
<field name="PRB" bit="0" size="15" desc="Protected Range Base"/>
87+
<field name="RPE" bit="15" size="1" desc="Read Protection Enabled"/>
88+
<field name="PRL" bit="16" size="15" desc="Protected Range Limit"/>
89+
<field name="WPE" bit="31" size="1" desc="Write Protection Enabled"/>
9090
</register>
9191
<register name="PR2" type="mmio" bar="SPIBAR" offset="0x8C" size="4" desc="Protected Range 2">
92-
<field name="PRB" bit="0" size="15"/>
93-
<field name="RPE" bit="15" size="1"/>
94-
<field name="PRL" bit="16" size="15"/>
95-
<field name="WPE" bit="31" size="1"/>
92+
<field name="PRB" bit="0" size="15" desc="Protected Range Base"/>
93+
<field name="RPE" bit="15" size="1" desc="Read Protection Enabled"/>
94+
<field name="PRL" bit="16" size="15" desc="Protected Range Limit"/>
95+
<field name="WPE" bit="31" size="1" desc="Write Protection Enabled"/>
9696
</register>
9797
<register name="PR3" type="mmio" bar="SPIBAR" offset="0x90" size="4" desc="Protected Range 3">
98-
<field name="PRB" bit="0" size="15"/>
99-
<field name="RPE" bit="15" size="1"/>
100-
<field name="PRL" bit="16" size="15"/>
101-
<field name="WPE" bit="31" size="1"/>
98+
<field name="PRB" bit="0" size="15" desc="Protected Range Base"/>
99+
<field name="RPE" bit="15" size="1" desc="Read Protection Enabled"/>
100+
<field name="PRL" bit="16" size="15" desc="Protected Range Limit"/>
101+
<field name="WPE" bit="31" size="1" desc="Write Protection Enabled"/>
102102
</register>
103103
<register name="PR4" type="mmio" bar="SPIBAR" offset="0x94" size="4" desc="Protected Range 4">
104-
<field name="PRB" bit="0" size="15"/>
105-
<field name="RPE" bit="15" size="1"/>
106-
<field name="PRL" bit="16" size="15"/>
107-
<field name="WPE" bit="31" size="1"/>
104+
<field name="PRB" bit="0" size="15" desc="Protected Range Base"/>
105+
<field name="RPE" bit="15" size="1" desc="Read Protection Enabled"/>
106+
<field name="PRL" bit="16" size="15" desc="Protected Range Limit"/>
107+
<field name="WPE" bit="31" size="1" desc="Write Protection Enabled"/>
108108
</register>
109109
<register name="FDOC" type="mmio" bar="SPIBAR" offset="0xB4" size="4" desc="Flash Descriptor Observability Control Register">
110110
<field name="FDSI" bit="2" size="10" desc="Flash Descriptor Section Index"/>
@@ -113,7 +113,7 @@
113113
<register name="FDOD" type="mmio" bar="SPIBAR" offset="0xB8" size="4" desc="Flash Descriptor Observability Data Register">
114114
<field name="FDSD" bit="0" size="32" desc="Flash Descriptor Section Data"/>
115115
</register>
116-
<register name="LVSCC" type="mmio" bar="SPIBAR" offset="0xC4" size="4" desc="Vendor Specific Component Capabilities">
116+
<register name="LVSCC" type="mmio" bar="SPIBAR" offset="0xC4" size="4" desc="Lower Vendor Specific Component Capabilities">
117117
<field name="WG" bit="2" size="1" desc="Write Granularity"/>
118118
<field name="WSR" bit="3" size="1" desc="Write Status Required"/>
119119
<field name="WEWS" bit="4" size="1" desc="Write Enable on Write Status"/>
@@ -129,7 +129,7 @@
129129
<field name="VCL" bit="30" size="1" desc="Vendor Component Lock"/>
130130
<field name="CPPTV" bit="31" size="1" desc="Component Property Parameter Table Valid"/>
131131
</register>
132-
<register name="UVSCC" type="mmio" bar="SPIBAR" offset="0xC8" size="4" desc="Vendor Specific Component Capabilities">
132+
<register name="UVSCC" type="mmio" bar="SPIBAR" offset="0xC8" size="4" desc="Upper Vendor Specific Component Capabilities">
133133
<field name="WG" bit="2" size="1" desc="Write Granularity"/>
134134
<field name="WSR" bit="3" size="1" desc="Write Status Required"/>
135135
<field name="WEWS" bit="4" size="1" desc="Write Enable on Write Status"/>
@@ -149,6 +149,7 @@
149149
<register name="BIOS_PTDATA" type="mmio" bar="SPIBAR" offset="0xD0" size="4" desc="Parameter Table Data"/>
150150
</registers>
151151
<controls>
152-
<control name="FlashLockDown" register="HSFS" field="FLOCKDN" desc="Flash Configuration Lock-Down"/>
152+
<control name="FlashLockDown" register="HSFS" field="FLOCKDN" desc="Flash Configuration Lock-Down"/>
153+
<control name="SpiWriteStatusDis" register="HSFS" field="WRSDIS" desc="Write Status Disable"/>
153154
</controls>
154155
</configuration>

0 commit comments

Comments
 (0)