minor fixes

npodbielski · npodbielski · commit f11ee61e88d7 · 2017-01-26T07:29:52.000+01:00
diff --git a/.gitignore b/.gitignore
@@ -32,3 +32,4 @@ Nuget/lib
 Platforms/NETCore/DelegatesFactory/**/*.cs
 Platforms/NETCore/DelegatesTest/**/*.cs
 Platforms/NETStandard/DelegatesTest/**/*.cs
+**/project.fragment.lock.json
diff --git a/Platforms/NETCore/DelegatesFactory/Nuget.nuspec b/Platforms/NETCore/DelegatesFactory/Nuget.nuspec
@@ -28,16 +28,22 @@
     <file src="..\..\NET35\DelegatesFactory\bin\Release\**.pdb" target="lib\NET35" />
     <file src="..\..\NET35\DelegatesFactory\bin\Release\**.xml" target="lib\NET35" />
     <file src="..\..\NET4\DelegatesFactory\bin\Release\**.dll" target="lib\NET4" />
+	<file src="..\..\NET4\DelegatesFactory\bin\Release\**.pdb" target="lib\NET4" />
     <file src="..\..\NET4\DelegatesFactory\bin\Release\**.xml" target="lib\NET4" />
     <file src="..\..\NET45\DelegatesFactory\bin\Release\**.dll" target="lib\NET45" />
+	<file src="..\..\NET45\DelegatesFactory\bin\Release\**.pdb" target="lib\NET45" />
     <file src="..\..\NET45\DelegatesFactory\bin\Release\**.xml" target="lib\NET45" />
     <file src="..\..\NET46\DelegatesFactory\bin\Release\**.dll" target="lib\NET46" />
+	<file src="..\..\NET46\DelegatesFactory\bin\Release\**.pdb" target="lib\NET46" />
     <file src="..\..\NET46\DelegatesFactory\bin\Release\**.xml" target="lib\NET46" />
     <file src="..\..\NETCore\DelegatesFactory\bin\Release\netstandard1.6\**.dll" target="lib\NETCore" />
+	<file src="..\..\NETCore\DelegatesFactory\bin\Release\netstandard1.6\**.pdb" target="lib\NETCore" />
     <file src="..\..\NETCore\DelegatesFactory\bin\Release\netstandard1.6\**.xml" target="lib\NETCore" />
     <file src="..\..\NETPortable\DelegatesFactory\bin\Release\**.dll" target="lib\portable-net45+sl50+netcore45+wpa81+wp8" />
+	<file src="..\..\NETPortable\DelegatesFactory\bin\Release\**.pdb" target="lib\portable-net45+sl50+netcore45+wpa81+wp8" />
     <file src="..\..\NETPortable\DelegatesFactory\bin\Release\**.xml" target="lib\portable-net45+sl50+netcore45+wpa81+wp8" />
     <file src="..\..\NETStandard\DelegatesFactory\bin\Release\**.dll" target="lib\netstandard1.5" />
+	<file src="..\..\NETStandard\DelegatesFactory\bin\Release\**.pdb" target="lib\netstandard1.5" />
     <file src="..\..\NETStandard\DelegatesFactory\bin\Release\**.xml" target="lib\netstandard1.5" />
     <file src="CustomDelegates\**\*.cs" target="src\CustomDelegates" />
     <file src="Extensions\**\*.cs" target="src\Extensions" />
diff --git a/Platforms/NETCore/DelegatesFactory/pack-publish.bat b/Platforms/NETCore/DelegatesFactory/pack-publish.bat
@@ -1,2 +1,2 @@
 nuget pack Nuget.nuspec -symbols -properties Configuration=Release -outputdirectory bin\Release
---nuget push .\bin\Release\DelegateFactory.1.0.0.nupkg -Source https://www.nuget.org/api/v2/package
+nuget push .\bin\Release\DelegatesFactory.1.0.0.nupkg -Source https://www.nuget.org/api/v2/package
diff --git a/src/DelegatesTest/DelegateFactoryTests_Constructors.cs b/src/DelegatesTest/DelegateFactoryTests_Constructors.cs
@@ -26,6 +26,7 @@ public class DelegateFactoryTests_Constructors
         private static readonly Type TestClassType = typeof(TestClass);
         private static readonly Type TestStructType = typeof(TestStruct);
 
+        //TODO: tests for delegate return type. it cannot be void
         [TestMethod]
         public void ConstructorByDelegateWithType_BoolParam()
         {
diff --git a/src/DelegatesTest/DelegateFactoryTests_InstanceMethods.cs b/src/DelegatesTest/DelegateFactoryTests_InstanceMethods.cs
@@ -2789,13 +2789,6 @@ public void Public_Method_ByObjects_WithConversion_NoVoidDelegate_For_VoidMethod
                 _testClassType.InstanceMethod("PublicMethodVoid", typeof(string)));
         }
 
-        [TestMethod]
-        public void Incorrect_TDelegate_For_InstanceGenericMethod()
-        {
-            AssertHelper.ThrowsException<ArgumentException>(() =>
-                _testClassType.InstanceGenericMethod<Action>("PublicMethodVoid", null, new[] { typeof(string) }));
-        }
-
         [TestMethod]
         public void CustomDelegate_ByTypes_Void_NoParams()
         {
diff --git a/src/DelegatesTest/DelegateFactoryTests_InstanceMethods_Generic.cs b/src/DelegatesTest/DelegateFactoryTests_InstanceMethods_Generic.cs
@@ -810,5 +810,12 @@ public void InterfaceMethod_Generic_ByObjects()
             var result = m(_interfaceImpl, new object[] { TestValue });
             Assert.AreEqual(TestValue, result);
         }
+
+        [TestMethod]
+        public void Incorrect_TDelegate_For_InstanceGenericMethod()
+        {
+            AssertHelper.ThrowsException<ArgumentException>(() =>
+                _testClassType.InstanceGenericMethod<Action>("PublicMethodVoid", null, new[] { typeof(string) }));
+        }
     }
 }
diff --git a/src/DelegatesTest/DelegateFactoryTests_StaticMethods.cs b/src/DelegatesTest/DelegateFactoryTests_StaticMethods.cs
@@ -2225,10 +2225,10 @@ public void Public_Method_ByObjects_NoVoidDelegate_For_VoidMethod()
         }
 
         [TestMethod]
-        public void Incorrect_TDelegate_For_InstanceGenericMethod()
+        public void Incorrect_TDelegate_For_StaticcMethod()
         {
             AssertHelper.ThrowsException<ArgumentException>(() =>
-                _testClassType.InstanceGenericMethod<Action>("StaticVoidPublic", null, new[] { typeof(string) }));
+                _testClassType.StaticMethod<Action>("StaticVoidPublic", null, new[] { typeof(string) }));
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`nuget pack Nuget.nuspec -symbols -properties Configuration=Release -outputdirectory bin\Release`
`2`		`---nuget push .\bin\Release\DelegateFactory.1.0.0.nupkg -Source https://www.nuget.org/api/v2/package`
	`2`	`+nuget push .\bin\Release\DelegatesFactory.1.0.0.nupkg -Source https://www.nuget.org/api/v2/package`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ public class DelegateFactoryTests_Constructors`
`26`	`26`	`private static readonly Type TestClassType = typeof(TestClass);`
`27`	`27`	`private static readonly Type TestStructType = typeof(TestStruct);`
`28`	`28`
	`29`	`+ //TODO: tests for delegate return type. it cannot be void`
`29`	`30`	`[TestMethod]`
`30`	`31`	`public void ConstructorByDelegateWithType_BoolParam()`
`31`	`32`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2789,13 +2789,6 @@ public void Public_Method_ByObjects_WithConversion_NoVoidDelegate_For_VoidMethod`
`2789`	`2789`	`_testClassType.InstanceMethod("PublicMethodVoid", typeof(string)));`
`2790`	`2790`	`}`
`2791`	`2791`
`2792`		`- [TestMethod]`
`2793`		`- public void Incorrect_TDelegate_For_InstanceGenericMethod()`
`2794`		`- {`
`2795`		`- AssertHelper.ThrowsException<ArgumentException>(() =>`
`2796`		`- _testClassType.InstanceGenericMethod<Action>("PublicMethodVoid", null, new[] { typeof(string) }));`
`2797`		`- }`
`2798`		`-`
`2799`	`2792`	`[TestMethod]`
`2800`	`2793`	`public void CustomDelegate_ByTypes_Void_NoParams()`
`2801`	`2794`	`{`
Original file line number	Diff line number	Diff line change
`@@ -810,5 +810,12 @@ public void InterfaceMethod_Generic_ByObjects()`
`810`	`810`	`var result = m(_interfaceImpl, new object[] { TestValue });`
`811`	`811`	`Assert.AreEqual(TestValue, result);`
`812`	`812`	`}`
	`813`	`+`
	`814`	`+ [TestMethod]`
	`815`	`+ public void Incorrect_TDelegate_For_InstanceGenericMethod()`
	`816`	`+ {`
	`817`	`+ AssertHelper.ThrowsException<ArgumentException>(() =>`
	`818`	`+ _testClassType.InstanceGenericMethod<Action>("PublicMethodVoid", null, new[] { typeof(string) }));`
	`819`	`+ }`
`813`	`820`	`}`
`814`	`821`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2225,10 +2225,10 @@ public void Public_Method_ByObjects_NoVoidDelegate_For_VoidMethod()`
`2225`	`2225`	`}`
`2226`	`2226`
`2227`	`2227`	`[TestMethod]`
`2228`		`- public void Incorrect_TDelegate_For_InstanceGenericMethod()`
	`2228`	`+ public void Incorrect_TDelegate_For_StaticcMethod()`
`2229`	`2229`	`{`
`2230`	`2230`	`AssertHelper.ThrowsException<ArgumentException>(() =>`
`2231`		`- _testClassType.InstanceGenericMethod<Action>("StaticVoidPublic", null, new[] { typeof(string) }));`
	`2231`	`+ _testClassType.StaticMethod<Action>("StaticVoidPublic", null, new[] { typeof(string) }));`
`2232`	`2232`	`}`
`2233`	`2233`	`}`
`2234`	`2234`	`}`