Merge #62

62: Fix the default LED matrix levels for micro:bit v1 r=therealprof a=hargoniX

The micro:bit v1 Board constructor turns all LEDs on the board on per
default at the moment, we don't want that. Tested on a micro:bit v1.5.

Co-authored-by: Henrik Böving <[email protected]>

Author: bors[bot]

CHANGELOG.md

@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Add a simple speaker demo for micro:bit V2.
 - Add Board struct following the pattern used in other nrf board support crates.
 - Add magnetometer example.
+- LEDs on the micro:bit V1 are now turned off per default
 
 ## [0.10.1] - 2021-05-25
 

microbit-common/src/display/blocking.rs

@@ -77,8 +77,6 @@ impl Display {
             rows,
             cols,
         };
-        // This is needed to reduce flickering on reset
-        retval.clear();
         retval
     }
 

microbit-common/src/v1/board.rs

@@ -119,18 +119,18 @@ impl Board {
                 p0_29: p0parts.p0_29,
             },
             display_pins: DisplayPins {
-                row1: p0parts.p0_13.into_push_pull_output(Level::High),
-                row2: p0parts.p0_14.into_push_pull_output(Level::High),
-                row3: p0parts.p0_15.into_push_pull_output(Level::High),
-                col1: p0parts.p0_04.into_push_pull_output(Level::Low),
-                col2: p0parts.p0_05.into_push_pull_output(Level::Low),
-                col3: p0parts.p0_06.into_push_pull_output(Level::Low),
-                col4: p0parts.p0_07.into_push_pull_output(Level::Low),
-                col5: p0parts.p0_08.into_push_pull_output(Level::Low),
-                col6: p0parts.p0_09.into_push_pull_output(Level::Low),
-                col7: p0parts.p0_10.into_push_pull_output(Level::Low),
-                col8: p0parts.p0_11.into_push_pull_output(Level::Low),
-                col9: p0parts.p0_12.into_push_pull_output(Level::Low),
+                row1: p0parts.p0_13.into_push_pull_output(Level::Low),
+                row2: p0parts.p0_14.into_push_pull_output(Level::Low),
+                row3: p0parts.p0_15.into_push_pull_output(Level::Low),
+                col1: p0parts.p0_04.into_push_pull_output(Level::High),
+                col2: p0parts.p0_05.into_push_pull_output(Level::High),
+                col3: p0parts.p0_06.into_push_pull_output(Level::High),
+                col4: p0parts.p0_07.into_push_pull_output(Level::High),
+                col5: p0parts.p0_08.into_push_pull_output(Level::High),
+                col6: p0parts.p0_09.into_push_pull_output(Level::High),
+                col7: p0parts.p0_10.into_push_pull_output(Level::High),
+                col8: p0parts.p0_11.into_push_pull_output(Level::High),
+                col9: p0parts.p0_12.into_push_pull_output(Level::High),
             },
             buttons: Buttons {
                 button_a: p0parts.p0_17.into_floating_input(),