Merge #329

329: Fix TWIS is_done() always returns true r=jonas-schievink a=kalkyl

Noticed there was a mistake in the `Transfer`  `is_done()` of the TWIS module, it always returns true.

Co-authored-by: Henrik Alsér <[email protected]>

Author: bors[bot]

CHANGELOG.md

@@ -2,7 +2,11 @@
 
 ## Unreleased
 
-(no changes)
+### Fixes
+
+- Fix TWIS transfer `is_done()` always returns true ([#329]).
+
+[#329]: https://github.com/nrf-rs/nrf-hal/pull/329
 
 ## [0.12.2]
 
@@ -126,9 +130,9 @@
 - Also return owned `Pins` from `Usart::free()` ([#261]).
 
 ¹ _A trait can be sealed by making a private trait a supertrait. That way, no
-  downstream crates can implement it (since they can't name the supertrait).
-  This is just to make sure the trait isn't implemented by types that shouldn't
-  implement it._
+downstream crates can implement it (since they can't name the supertrait).
+This is just to make sure the trait isn't implemented by types that shouldn't
+implement it._
 
 ### Internal Improvements
 

nrf-hal-common/src/twis.rs

@@ -518,8 +518,7 @@ impl<T: Instance, B> Transfer<T, B> {
             .inner
             .as_mut()
             .unwrap_or_else(|| unsafe { core::hint::unreachable_unchecked() });
-        inner.twis.is_done();
-        true
+        inner.twis.is_done()
     }
 }
 
@@ -561,4 +560,4 @@ mod _twis1 {
     impl Instance for TWIS1 {
         const INTERRUPT: Interrupt = Interrupt::SPIM1_SPIS1_TWIM1_TWIS1_SPI1_TWI1;
     }
-}
+}