Skip to content

Commit 08da36c

Browse files
committed
[mrp] Increase default retry interval for Thread
The current 800ms is not enough in real setups, where Thread routers must serve as intermediate hops for many parallel conversations. Bump this to 2s. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
1 parent c9acb13 commit 08da36c

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

src/messaging/ReliableMessageProtocolConfig.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ namespace chip {
5151
*/
5252
#ifndef CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL
5353
#if CHIP_ENABLE_OPENTHREAD && !CHIP_DEVICE_LAYER_TARGET_LINUX
54-
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (800_ms32)
54+
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (2000_ms32)
5555
#else
5656
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (300_ms32)
5757
#endif
@@ -77,7 +77,7 @@ namespace chip {
7777
*/
7878
#ifndef CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL
7979
#if CHIP_ENABLE_OPENTHREAD && !CHIP_DEVICE_LAYER_TARGET_LINUX
80-
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (800_ms32)
80+
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (2000_ms32)
8181
#else
8282
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (300_ms32)
8383
#endif
@@ -161,7 +161,7 @@ namespace chip {
161161
*/
162162
#ifndef CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST
163163
#if CHIP_ENABLE_OPENTHREAD && !CHIP_DEVICE_LAYER_TARGET_LINUX
164-
#define CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST (500_ms)
164+
#define CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST (1500_ms)
165165
#endif
166166
#endif // CHIP_CONFIG_MRP_RETRY_INTERVAL_SENDER_BOOST && !CHIP_DEVICE_LAYER_TARGET_LINUX
167167

src/platform/nrfconnect/CHIPPlatformConfig.h

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -95,19 +95,14 @@
9595
#define CHIP_CONFIG_LOG_MODULE_Support_PROGRESS 0
9696
#endif
9797

98-
// Set MRP retry intervals for Thread and Wi-Fi to test-proven values.
9998
#ifndef CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL
100-
#if CHIP_ENABLE_OPENTHREAD
101-
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (800_ms32)
102-
#else
99+
#ifndef CONFIG_NET_L2_OPENTHREAD
103100
#define CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL (1000_ms32)
104-
#endif // CHIP_ENABLE_OPENTHREAD
101+
#endif // CONFIG_NET_L2_OPENTHREAD
105102
#endif // CHIP_CONFIG_MRP_LOCAL_ACTIVE_RETRY_INTERVAL
106103

107104
#ifndef CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL
108-
#if CHIP_ENABLE_OPENTHREAD
109-
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (800_ms32)
110-
#else
105+
#ifndef CONFIG_NET_L2_OPENTHREAD
111106
#define CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL (1000_ms32)
112-
#endif // CHIP_ENABLE_OPENTHREAD
107+
#endif // CONFIG_NET_L2_OPENTHREAD
113108
#endif // CHIP_CONFIG_MRP_LOCAL_IDLE_RETRY_INTERVAL

0 commit comments

Comments
 (0)