Skip to content

Commit 9d33e97

Browse files
cecillehastyfessehaeveKishokGnivi-apple
authored andcommitted
[nrf fromtree] [HVAC] Implement TC-TSTAT-2.2 (#36023) (#37515)
* Initial generated test * Fixed and compared against test plan * Remove unused TC-TSTAT-2.2 yaml * Apply suggestions from code review * Update TC_TSTAT_2_2.py fixed below mentioned discrepancies on the code: Step-3c: The test plan expects a Success response, but the script is checking for a ConstraintError. If the value does not violate any conditions, the response should be Success. In such cases, the test will fail. Step-4c: If the AUTO feature is enabled, the script writes the UnoccupiedCoolingSetpoint attribute with MaxCoolSetpointLimitValue and checks for a ConstraintError response, which is not required. Step-5c: The script should check the following condition when the AUTO feature is enabled: Min(MaxHeatSetpointLimit, (UnoccupiedCoolingSetpoint - MinSetpointDeadBand)). However, this condition is missing in the script, and it incorrectly checks for a ConstraintError response. Step-7a: The write and read verification is missing. Step-9b: The script incorrectly writes the attribute value using AbsMinCoolSetpointLimitValue instead of MinCoolSetpointLimitValue. Step-9c: A duplicate read check has been removed. * Python linter fix for TC_TSTAT_2_2 * Update src/python_testing/TC_TSTAT_2_2.py * Restore setpoints to original values at end of test * Use get_endpoint method to find active endpoint * Update CI Test Arguments to the apparent new style --------- Co-authored-by: Hasty Granbery <[email protected]> Co-authored-by: fesseha-eve <[email protected]> Co-authored-by: Kishok G <[email protected]> Co-authored-by: Nivi Sarkar <[email protected]> (cherry picked from commit 87e088ea7572c3d29bfc66abd89f4135a8624735) Signed-off-by: Adrian Gielniewski <[email protected]>
1 parent 20281ec commit 9d33e97

File tree

2 files changed

+796
-2005
lines changed

2 files changed

+796
-2005
lines changed

0 commit comments

Comments
 (0)