[nrf toup] simplify Key/Value Get function #577
Conversation
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
from
0b32254 to
831b1e2
Compare
| ReadEntry entry{ value, value_size, 0, CHIP_ERROR_PERSISTED_STORAGE_VALUE_NOT_FOUND }; | ||
| settings_load_subtree_direct(fullKey, LoadEntryCallback, &entry); | ||
| // Found requested key. | ||
| const ssize_t bytesRead = settings_load_one(fullKey, value, value_size); |
There was a problem hiding this comment.
If value_size < kEmptyValueSize, this function will fail even though it should be possible to get empty value even with value_size == 0.
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
2 times, most recently
from
048b54b to
7293889
Compare
|
should be merged after this one nrfconnect/sdk-zephyr#2615 |
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
3 times, most recently
from
eab34c5 to
0f562e4
Compare
| char fullKey[SETTINGS_MAX_NAME_LEN + 1]; | ||
| ReturnErrorOnFailure(MakeFullKey(fullKey, key)); | ||
|
|
||
| printk("Riadh Put %s size %u\n", fullKey, value_size); |
There was a problem hiding this comment.
Debugging log leftover
| if (len > 0) | ||
| { | ||
| *val_len = len; | ||
| return true;; |
There was a problem hiding this comment.
| return true;; | |
| return true; |
| { | ||
| ssize_t bytesRead = settings_load_one(fullkey, dest_buf, dest_size); | ||
|
|
||
| printk("Riadh loading key %s bytesRead %u\n", fullkey, bytesRead); |
There was a problem hiding this comment.
Debugging log leftover
| *read_bytes_size = entry.readSize; | ||
| *read_bytes_size = readSize; | ||
| } | ||
| printk("Riadh result : %" CHIP_ERROR_FORMAT "\n", result.Format()); |
There was a problem hiding this comment.
Sorry for that, all debug logs leftover fixed
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
3 times, most recently
from
3db67c8 to
195ea4c
Compare
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
from
195ea4c to
9757f61
Compare
|
@rghaddab you were missing the sdk-nrf PR link in a PR description to run the unit tests on your sdk-zephyr changes. Damian has added it for you, but you have to force push/re-run failing test to make it green. |
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
from
9757f61 to
e965680
Compare
|
@rghaddab I've analyzed the logs from unit tests. Actually it shows the failure related to your change. But unfortunately the log was truncated, so I had to download the package and analyze it locally. Here are the failures: First And second |
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
from
e965680 to
a8f01b1
Compare
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
from
a8f01b1 to
02ae23e
Compare
Use settings_load_one function to load one key/value settings entry instead of settings_load_subtree_direct. This will avoid loading all the keys for some storage backends. Simplify as well the Delete function by using settings_get_val_len() function. Signed-off-by: Riadh Ghaddab <[email protected]>
To maintain backward compatibility, keep the support for the legacy ZMS backend for Settings. Signed-off-by: Riadh Ghaddab <[email protected]>
rghaddab
force-pushed
the
rghaddab/use-settings-load-one
branch
from
02ae23e to
5aae50c
Compare
4 participants
use settings_load_one function to load one key/value settings entry instead of settings_load_subtree_direct.
This will avoid loading all the keys for some storage backends. Simplify as well the Delete function by skipping loading the value before deleting it.
NCS PR: nrfconnect/sdk-nrf/pull/20691