Skip to content

Commit 78c73f7

Browse files
de-nordicjukkar
authored andcommitted
[nrf noup] boot: Use NCS_ prefix for sdk-nrf specific Kconfigs
nrf-squash! [nrf noup] boot: Add retry for image verification Use NCS_ prefix, for Kconfigs added in noups, to avoid collisions. The NRF_ prefix will remain reserved for Kconfigs related to products or sdk-nrf subsystems. Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 30e7326)
1 parent bbc18bc commit 78c73f7

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

boot/bootutil/src/loader.c

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@
5757

5858
#ifdef __ZEPHYR__
5959
#include <zephyr/sys/reboot.h>
60-
#if defined(CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS)
60+
#if defined(CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS)
6161
#include <zephyr/kernel.h>
62-
#endif /* CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS */
62+
#endif /* CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS */
6363
#endif
6464

6565
#if defined(CONFIG_SOC_NRF5340_CPUAPP) && defined(PM_CPUNET_B0N_ADDRESS) && defined(CONFIG_PCD_APP)
@@ -768,10 +768,10 @@ boot_image_check(struct boot_loader_state *state, struct image_header *hdr,
768768
}
769769
#endif
770770

771-
for (int i = 1; i <= CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT; i++ ) {
772-
#if CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
773-
BOOT_LOG_DBG("Image validation attempt %d/%d", i, CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT);
774-
#endif /* CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
771+
for (int i = 1; i <= CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT; i++ ) {
772+
#if CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
773+
BOOT_LOG_DBG("Image validation attempt %d/%d", i, CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT);
774+
#endif /* CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
775775

776776
#if defined(MCUBOOT_SWAP_USING_OFFSET) && defined(MCUBOOT_SERIAL_RECOVERY)
777777
FIH_CALL(bootutil_img_validate, fih_rc, state, hdr, fap, tmpbuf, BOOT_TMPBUF_SZ,
@@ -782,25 +782,25 @@ boot_image_check(struct boot_loader_state *state, struct image_header *hdr,
782782
#endif
783783

784784
if (FIH_EQ(fih_rc, FIH_SUCCESS)) {
785-
#if CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
786-
BOOT_LOG_DBG("Image validation attempt %d/%d success", i, CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT);
787-
#endif /* CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
785+
#if CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
786+
BOOT_LOG_DBG("Image validation attempt %d/%d success", i, CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT);
787+
#endif /* CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
788788
break;
789789
} else {
790-
#if CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
790+
#if CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
791791
BOOT_LOG_WRN("Image validation attempt %d/%d failure: %d",
792792
i,
793-
CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT, fih_rc);
794-
#endif /* CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
793+
CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT, fih_rc);
794+
#endif /* CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
795795

796-
if (i < CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT) {
797-
#if defined(CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS)
798-
#if CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
796+
if (i < CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT) {
797+
#if defined(CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS)
798+
#if CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
799799
BOOT_LOG_DBG("Waiting %d ms before next attempt",
800-
CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS);
801-
#endif /* CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
802-
k_busy_wait(CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS * 1000);
803-
#endif /* CONFIG_NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS */
800+
CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS);
801+
#endif /* CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1 */
802+
k_busy_wait(CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS * 1000);
803+
#endif /* CONFIG_NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS */
804804
}
805805
}
806806
}

boot/zephyr/Kconfig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1365,7 +1365,7 @@ config MCUBOOT_VERIFY_IMG_ADDRESS
13651365
also be useful when BOOT_DIRECT_XIP is enabled, to ensure that the image
13661366
linked at the correct address is loaded.
13671367

1368-
config NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT
1368+
config NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT
13691369
int "Number of image validation attempts"
13701370
default 1
13711371
help
@@ -1374,9 +1374,9 @@ config NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT
13741374
This can prevent erasing an image when initial validation fails.
13751375
Wait time is controlled by MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS.
13761376

1377-
config NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS
1377+
config NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_WAIT_MS
13781378
int "Time between image validation attempts"
1379-
depends on NRF_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
1379+
depends on NCS_MCUBOOT_IMG_VALIDATE_ATTEMPT_COUNT > 1
13801380
default 5000
13811381
help
13821382
Time between image validation attempts, in milliseconds.

0 commit comments

Comments
 (0)