SonarQube findings resolution

adsz-nordic · adsz-nordic · commit d8924581e06a · 2025-09-12T11:58:54.000+02:00
"volatile" types should not be used in compound operations Issue link: https://sonarcloud.io/project/issues?open=AZWum4f1vizSu0tgQ8GT&id=nrfconnect_sdk-mcuboot Ref: NCSDK-35334 Signed-off-by: Adam Szczygieł <adam.szczygiel@nordicsemi.no>
diff --git a/boot/bootutil/include/bootutil/fault_injection_hardening.h b/boot/bootutil/include/bootutil/fault_injection_hardening.h
@@ -160,7 +160,9 @@ int fih_delay(void)
 
     delay = fih_delay_random_uchar();
 
-    for (volatile int i = 0; i < delay; i++) {
+    for (volatile int i = 0; i < delay;) {
+        int tmp = i;
+        i = tmp + 1;
         foo++;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,9 @@ int fih_delay(void)`
`160`	`160`
`161`	`161`	`delay = fih_delay_random_uchar();`
`162`	`162`
`163`		`- for (volatile int i = 0; i < delay; i++) {`
	`163`	`+ for (volatile int i = 0; i < delay;) {`
	`164`	`+ int tmp = i;`
	`165`	`+ i = tmp + 1;`
`164`	`166`	`foo++;`
`165`	`167`	`}`
`166`	`168`