lib: bm_zms: check input parameters in bm_zms_register

Adds input parameter checks.

Signed-off-by: Mirko Covizzi <[email protected]>

Author: MirkoCovizzi

doc/nrf-bm/release_notes/release_notes_changelog.rst

@@ -52,7 +52,9 @@ No changes since the latest nRF Connect SDK Bare Metal release.
 Libraries
 =========
 
-No changes since the latest nRF Connect SDK Bare Metal release.
+* :ref:`lib_bm_zms` library:
+
+   * Updated the :c:func:`bm_zms_register` function to return ``-EINVAL`` when passing ``NULL`` input parameters.
 
 Samples
 =======

include/bm_zms.h

@@ -112,6 +112,7 @@ typedef void (*bm_zms_cb_t)(bm_zms_evt_t const *p_evt);
  *
  * @retval 0 on success.
  * @retval -ENOMEM if no more callback slots are available.
+ * @retval -EINVAL if @p fs or @p cb are NULL.
  */
 int bm_zms_register(struct bm_zms_fs *fs, bm_zms_cb_t cb);
 

lib/bm_zms/bm_zms.c

@@ -322,6 +322,10 @@ int bm_zms_register(struct bm_zms_fs *fs, bm_zms_cb_t cb)
 {
 	int i;
 
+	if (!fs || !cb) {
+		return -EINVAL;
+	}
+
 	for (i = 0; i < CONFIG_BM_ZMS_MAX_USERS; i++) {
 		if (zms_cb_table[i] == NULL) {
 			break;

tests/lib/bm_zms/src/main.c

@@ -116,6 +116,12 @@ ZTEST_F(bm_zms, test_bm_zms_register)
 {
 	int err;
 
+	err = bm_zms_register(NULL, &bm_zms_test_handler);
+	zassert_true(err == -EINVAL, "bm_zms_register unexpected failure");
+
+	err = bm_zms_register(&fixture->fs, NULL);
+	zassert_true(err == -EINVAL, "bm_zms_register unexpected failure");
+
 	err = bm_zms_register(&fixture->fs, &bm_zms_test_handler);
 	zassert_true(err == 0, "bm_zms_register call failure");
 }