bluetooth: subsys: samples: clarify BMS auth code Kconfig scope

The BMS authorization code configuration has been aligned with its
actual usage by making it sample‑specific.
CONFIG_BLE_BMS_AUTHORIZATION_CODE (and BLE_BMS_AUTHORIZATION_CODE) was
previously defined at the BMS library level even though it is only
used by the BLE BMS sample. This change clarifies the configuration
scope and avoids confusion for users by ensuring the authorization
code setting is defined and documented where it is actually applied.

Signed-off-by: Martynas Smilingis <martynas.smilingis@nordicsemi.no>

Author: PizzaAllTheWay

doc/nrf-bm/release_notes/release_notes_changelog.rst

@@ -104,6 +104,7 @@ Bluetooth LE Services
 
 * Renamed the ``ble_hrs_central`` service to the :ref:`lib_ble_service_hrs_client` sample.
 * Updated all services to return errors from the SoftDevice directly.
+* Removed the BMS authorization code Kconfig options (:kconfig:option:`CONFIG_BLE_BMS_AUTHORIZATION_CODE` and :kconfig:option:`CONFIG_BLE_BMS_USE_AUTHORIZATION_CODE`) from the service library, as they are only used by the BMS sample.
 
 Libraries for NFC
 -----------------
@@ -137,6 +138,10 @@ Samples
 Bluetooth LE samples
 --------------------
 
+* :ref:`ble_bms_sample`:
+
+   * Added sample-specific Kconfig options for the BMS authorization code by moving them from the service library scope and renaming them from :kconfig:option:`CONFIG_BLE_BMS_AUTHORIZATION_CODE` and :kconfig:option:`CONFIG_BLE_BMS_USE_AUTHORIZATION_CODE` to :kconfig:option:`CONFIG_APP_BLE_BMS_AUTHORIZATION_CODE` and :kconfig:option:`CONFIG_APP_BLE_BMS_USE_AUTHORIZATION_CODE`.
+
 * :ref:`ble_hids_keyboard_sample`:
 
    * Added support for boot mode.

samples/bluetooth/ble_bms/Kconfig

@@ -14,6 +14,14 @@ config SAMPLE_BLE_BMS_PEERS_TO_DELETE_ON_DISCONNECT_MAX
 	int "Maximum number of peers to delete upon a peer disconnect"
 	default 10
 
+config SAMPLE_BLE_BMS_USE_AUTHORIZATION_CODE
+	bool "Use authorization code"
+	default y
+
+config SAMPLE_BLE_BMS_AUTHORIZATION_CODE
+	string "Authorization code"
+	default "ABCD"
+
 module=SAMPLE_BLE_BMS
 module-str=BLE Bond Management Service Sample
 source "$(ZEPHYR_BASE)/subsys/logging/Kconfig.template.log_config"

samples/bluetooth/ble_bms/README.rst

@@ -109,7 +109,17 @@ Testing
 #. Reconnect the devices and verify that the connection security is not updated.
 #. Bond both devices again.
 #. Write ``06 41 42 43 44`` to the Bond Management Service Control Point Characteristic.
-   ``06`` is the command to delete all bonds on the server, followed by the authorization code ``ABCD``.
+   ``06`` is the command to delete all bonds on the server, followed by the authorization code ``ABCD`` (ASCII ``0x41 0x42 0x43 0x44``).
 #. Disconnect the device to trigger the bond deletion procedures.
 #. Delete the bond information of the central device again.
 #. Reconnect the devices again and verify that the connection security is not updated.
+
+.. note::
+   The default authorization code ``ABCD`` (ASCII ``0x41 0x42 0x43 0x44``) is configurable through the :kconfig:option:`CONFIG_SAMPLE_BLE_BMS_AUTHORIZATION_CODE` Kconfig option.
+   The maximum allowed length is :c:macro:`BLE_BMS_AUTH_CODE_MAX_LEN` (127 bytes), which comes from the BMS control point definition.
+
+   Authorization codes up to **127 bytes** are supported.
+   You may configure the code to any value within this limit as needed.
+
+   If this security feature is not required, it can be enabled or disabled using the :kconfig:option:`CONFIG_SAMPLE_BLE_BMS_USE_AUTHORIZATION_CODE` Kconfig option.
+   After changing the configuration, rebuild the sample and test how bond deletion behaves with or without an authorization code.

samples/bluetooth/ble_bms/src/main.c

@@ -414,10 +414,10 @@ void bms_evt_handler(struct ble_bms *bms, struct ble_bms_evt *evt)
 		break;
 	case BLE_BMS_EVT_AUTH:
 		LOG_DBG("Authorization request.");
-#if defined(CONFIG_BLE_BMS_USE_AUTHORIZATION_CODE)
-		if ((evt->auth.auth_code.len != strlen(CONFIG_BLE_BMS_AUTHORIZATION_CODE)) ||
-		    (memcmp(CONFIG_BLE_BMS_AUTHORIZATION_CODE, evt->auth.auth_code.code,
-			    strlen(CONFIG_BLE_BMS_AUTHORIZATION_CODE)) != 0)) {
+#if defined(CONFIG_SAMPLE_BLE_BMS_USE_AUTHORIZATION_CODE)
+		if ((evt->auth.auth_code.len != strlen(CONFIG_SAMPLE_BLE_BMS_AUTHORIZATION_CODE)) ||
+		    (memcmp(CONFIG_SAMPLE_BLE_BMS_AUTHORIZATION_CODE, evt->auth.auth_code.code,
+			    strlen(CONFIG_SAMPLE_BLE_BMS_AUTHORIZATION_CODE)) != 0)) {
 			is_authorized = false;
 		}
 #endif
@@ -575,7 +575,7 @@ int main(void)
 
 	struct ble_bms_config bms_cfg = {
 		.evt_handler = bms_evt_handler,
-#if defined(CONFIG_BLE_BMS_USE_AUTHORIZATION_CODE)
+#if defined(CONFIG_SAMPLE_BLE_BMS_USE_AUTHORIZATION_CODE)
 		/* Do not require auth to delete requesting. */
 		.feature.delete_requesting = true,
 		.feature.delete_all_auth = true,

subsys/bluetooth/services/ble_bms/Kconfig

@@ -12,14 +12,6 @@ menuconfig BLE_BMS
 
 if BLE_BMS
 
-config BLE_BMS_USE_AUTHORIZATION_CODE
-	bool "Use authorization code"
-	default y
-
-config BLE_BMS_AUTHORIZATION_CODE
-	string "Authorization code"
-	default "ABCD"
-
 module=BLE_BMS
 module-str=BLE_BMS
 source "$(ZEPHYR_BASE)/subsys/logging/Kconfig.template.log_config"