lib: peer_manager: refactor PM_SERVICE_CHANGED dependencies

If not using a GATT server, or using a server without a service changed
characteristic, this Kconfig option should be disabled to save code space.
Refactors this Kconfig option in order to represent this relationship
accordingly.

Signed-off-by: Mirko Covizzi <[email protected]>

Author: MirkoCovizzi

doc/nrf-bm/release_notes/release_notes_changelog.rst

@@ -65,6 +65,7 @@ Libraries
      * The ``CONFIG_PM_PEER_RANKS_ENABLED`` Kconfig option is renamed to :kconfig:option:`CONFIG_PM_PEER_RANKS`.
      * The ``CONFIG_PM_LESC_ENABLED`` Kconfig option is renamed to :kconfig:option:`CONFIG_PM_LESC`.
      * The ``CONFIG_PM_RA_PROTECTION_ENABLED`` Kconfig option is renamed to :kconfig:option:`CONFIG_PM_RA_PROTECTION`.
+     * The :kconfig:option:`CONFIG_PM_SERVICE_CHANGED` Kconfig option to depend on the :kconfig:option:`CONFIG_NRF_SDH_BLE_SERVICE_CHANGED` Kconfig option.
 
 Samples
 =======

lib/peer_manager/Kconfig

@@ -39,6 +39,7 @@ config PM_FLASH_BUFFERS
 
 config PM_SERVICE_CHANGED
 	bool "Service changed management for GATT server"
+	depends on NRF_SDH_BLE_SERVICE_CHANGED
 	default y
 	help
 	  Disable this option to reduce memory usage if not using a GATT server, or using a server

lib/peer_manager/modules/gatt_cache_manager.c

@@ -127,15 +127,6 @@ static int m_flag_car_handle_queried;
  */
 static int m_flag_car_value_queried;
 
-#ifdef CONFIG_PM_SERVICE_CHANGED
-BUILD_ASSERT(IS_ENABLED(CONFIG_PM_SERVICE_CHANGED) ||
-	     !IS_ENABLED(CONFIG_NRF_SDH_BLE_SERVICE_CHANGED),
-	"CONFIG_PM_SERVICE_CHANGED should be enabled "
-	"if NRF_SDH_BLE_SERVICE_CHANGED is enabled.");
-#else
-#define CONFIG_PM_SERVICE_CHANGED 1
-#endif
-
 /**
  * @brief Function for resetting the module variable(s) of the GSCM module.
  *