lib: ble_adv: remove TODOs

The todos will be addressed at a later point.

Signed-off-by: Andreas Moltumyr <[email protected]>

Author: anhmolt

include/ble_adv.h

@@ -27,17 +27,11 @@
 extern "C" {
 #endif
 
-/** TODO: Are we gonna need priorities again?
- *  If so, this should be a Kconfig!
+/**
+ * @brief Advertising module BLE event observer priority.
  */
 #define BLE_ADV_BLE_OBSERVER_PRIO 0
 
-/** TODO: what is the purpose of this library being multi-instance?
- *  If it's not multi-instace, then let it define its own BLE observer
- *  and let the application register a handler instead of defining an
- *  instance with a macro..
- */
-
 /**
  * @brief Declare an instance of a BLE advertising library.
  */
@@ -188,7 +182,6 @@ struct ble_adv {
 	 */
 	ble_gap_adv_params_t adv_params;
 
-	/** TODO: Kconfig */
 #ifdef BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED
 	/** Advertising data sets in encoded form. Current and swap buffer */
 	uint8_t enc_adv_data[2][BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED];
@@ -345,11 +338,6 @@ int ble_adv_whitelist_reply(struct ble_adv *ble_adv,
  */
 int ble_adv_restart_without_whitelist(struct ble_adv *ble_adv);
 
-/** TODO: do we even need this function ?
- *  It doesn't provide much value on it's only used in one sample in nRF5.
- *  It's probably just one SD call..
- */
-
 /**@brief   Function for updating advertising data.
  *
  * @details This function can be called if you wish to reconfigure the advertising data The update

lib/ble_adv/ble_adv.c

@@ -491,16 +491,12 @@ int ble_adv_whitelist_reply(struct ble_adv *ble_adv,
 		return -EPERM;
 	}
 
-	/** TODO: what does whitelist support in this module really do?
-	 *  it only seems to change the filter policy...
-	 */
 	ble_adv->whitelist_reply_expected = false;
 	ble_adv->whitelist_in_use = (addr_cnt > 0 || irk_cnt > 0);
 
 	return 0;
 }
 
-/** TODO: can this be removed? */
 int ble_adv_restart_without_whitelist(struct ble_adv *ble_adv)
 {
 	int err;
@@ -524,7 +520,6 @@ int ble_adv_restart_without_whitelist(struct ble_adv *ble_adv)
 	return 0;
 }
 
-/** TODO: can this be removed? */
 int ble_adv_data_update(struct ble_adv *ble_adv, const struct ble_adv_data *adv_data,
 			const struct ble_adv_data *sr_data)
 {