scripts: hid_configurator: Fix pylint issues

Change fixes issues reported by pylint.

Jira:DESK-593

Signed-off-by: Marek Pieta <[email protected]>

Author: MarekPieta

scripts/hid_configurator/configurator_cli.py

@@ -164,17 +164,17 @@ def parse_arguments():
         device_config = DEVICE[device_name]['config']
 
         if device_config is not None:
-            assert type(device_config) == dict
+            assert isinstance(device_config, dict)
             parser_config = sp_commands.add_parser('config', help='Configuration option get/set')
 
             sp_config = parser_config.add_subparsers(dest='module')
             sp_config.required = True
 
             for module_name in device_config:
                 module_config = device_config[module_name]
-                assert type(module_config) == dict
+                assert isinstance(module_config, dict)
                 module_opts = module_config['options']
-                assert type(module_opts) == dict
+                assert isinstance(module_opts, dict)
 
                 parser_config_module = sp_config.add_parser(module_name, help='{} module options'.format(module_name))
                 sp_config_module = parser_config_module.add_subparsers(dest='option')

scripts/hid_configurator/configurator_core.py

@@ -11,7 +11,7 @@
 
 import logging
 
-from devices import get_device_pid, get_device_vid, get_device_type
+from devices import get_device_pid, get_device_vid
 
 REPORT_ID = 6
 REPORT_SIZE = 30

scripts/hid_configurator/gui/gui_backend.py

@@ -31,8 +31,8 @@ def list_devices():
             device_type = get_device_type(device['product_id'])
             if device_type is not None and \
                get_device_vid(device_type) == device['vendor_id']:
-                    print("Add {} to device list".format(device_type))
-                    device_list.append(device_type)
+                print("Add {} to device list".format(device_type))
+                device_list.append(device_type)
 
         return device_list
 
@@ -64,7 +64,7 @@ def perform_dfu_fwreboot(self, update_animation):
             print('DFU completed')
         else:
             print('Cannot connect to device after reboot')
-        return (self.dev is not None)
+        return self.dev is not None
 
     def setcpi(self, value):
         config_name = 'cpi'
@@ -95,7 +95,8 @@ def perform_dfu(self, file, update_progressbar):
         dfu_image = file
         return dfu_transfer(self.dev, self.pid, dfu_image, update_progressbar)
 
-    def dfu_image_version(self, filepath):
+    @staticmethod
+    def dfu_image_version(filepath):
         ver = get_dfu_image_version(filepath)
         if ver is None:
             return "Wrong image"

scripts/hid_configurator/modules/dfu.py

@@ -7,6 +7,7 @@
 import zlib
 import os
 import imgtool.image as img
+import time
 import logging
 
 from configurator_core import GROUP_FIELD_POS, TYPE_FIELD_POS, EVENT_GROUP_DFU

scripts/hid_configurator/modules/music_led_stream.py

@@ -11,10 +11,10 @@
 import threading
 import queue
 
-from .led_stream import MS_PER_SEC
-from .led_stream import Step
-from .led_stream import validate_params
-from .led_stream import fetch_free_steps_buffer_info, led_send_single_step
+from modules.led_stream import MS_PER_SEC
+from modules.led_stream import Step
+from modules.led_stream import validate_params
+from modules.led_stream import fetch_free_steps_buffer_info, led_send_single_step
 
 
 class MusicLedStream():
@@ -67,7 +67,8 @@ def __init__(self, dev, recipient, DEVICE_CONFIG, led_id, freq, filename):
 
     @staticmethod
     def peak_to_hue(peak):
-        assert peak >= 0 and peak <= 1
+        assert peak >= 0
+        assert peak <= 1
 
         G = 120
         B = 240
@@ -90,7 +91,7 @@ def send_led_effects(self):
         while True:
             data = self.queue.get()
 
-            if data == None:
+            if data is None:
                 # LED stream ended
                 return
 
@@ -124,7 +125,7 @@ def send_led_effects(self):
 
             if not success:
                 print("Device communication problem")
-                send_error_event.set()
+                self.send_error_event.set()
                 return
 
             self.led_effects['sent_cnt'] += 1
@@ -205,7 +206,6 @@ def stream_start(self):
 
         except KeyboardInterrupt:
             print("Music LED stream interrupted by user")
-            pass
 
         self.stream_term()