Skip to content

Commit 371ff9d

Browse files
adigierlubos
authored andcommitted
cmake: Prevent regenerating dfu multi image on every build
* Move running dfu_multi_image_tool.py out of custom target to stop regenerating the image on every build. * Fix DEPENDS for dfu_multi_image_package. Signed-off-by: Adrian Gielniewski <[email protected]>
1 parent 588f19d commit 371ff9d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

cmake/dfu_multi_image.cmake

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,18 @@ function(dfu_multi_image_package TARGET_NAME)
3737
string(REPLACE ";" "\n" SCRIPT_ARGS "${SCRIPT_ARGS}")
3838
file(GENERATE OUTPUT ${ARG_OUTPUT}.args CONTENT ${SCRIPT_ARGS})
3939

40-
add_custom_target(${TARGET_NAME} ALL
40+
add_custom_command(
4141
COMMAND
4242
${Python3_EXECUTABLE}
4343
${ZEPHYR_NRF_MODULE_DIR}/scripts/bootloader/dfu_multi_image_tool.py
4444
@${ARG_OUTPUT}.args
45-
BYPRODUCTS
45+
OUTPUT
4646
${ARG_OUTPUT}
4747
DEPENDS
4848
${ARG_DEPENDS}
4949
)
50+
add_custom_target(${TARGET_NAME} ALL
51+
DEPENDS
52+
${ARG_OUTPUT}
53+
)
5054
endfunction()

subsys/bootloader/cmake/packaging.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ if(SB_CONFIG_DFU_MULTI_IMAGE_PACKAGE_BUILD)
1818

1919
list(APPEND dfu_multi_image_ids 0)
2020
list(APPEND dfu_multi_image_paths "${${DEFAULT_IMAGE}_image_dir}/zephyr/${${DEFAULT_IMAGE}_kernel_name}.signed.bin")
21-
list(APPEND dfu_multi_image_targets ${DEFAULT_IMAGE}_extra_byproducts)
21+
list(APPEND dfu_multi_image_targets ${DEFAULT_IMAGE}_extra_byproducts ${dfu_multi_image_paths})
2222
endif()
2323

2424
if(SB_CONFIG_DFU_MULTI_IMAGE_PACKAGE_NET)

0 commit comments

Comments
 (0)