modules: openthread: start using NCS implementation of OT platform

- Start using NCS implementation of OT platform
- align license allowlist
- remove sourcing files that have not been copied from upstream
- update CODEOWNERS
- clean compliance issues
- update test spec

Signed-off-by: Maciej Baczmanski <[email protected]>

Author: maciejbaczmanski

.github/test-spec.yml

@@ -376,6 +376,7 @@
   - "drivers/hw_cc3xx/*"
   - "drivers/entropy/*"
   - "modules/nrfxlib/nrf_802154/**/*"
+  - "modules/openthread/**/*"
 
 "CI-nfc-test":
   - "subsys/nfc/**/*"

CODEOWNERS

@@ -430,6 +430,7 @@
 /modules/mcuboot/                         @nrfconnect/ncs-pluto
 /modules/memfault-firmware-sdk/           @nrfconnect/ncs-cia
 /modules/nrfxlib/                         @nrfconnect/ncs-code-owners
+/modules/openthread/                      @nrfconnect/ncs-thread
 /modules/trusted-firmware-m/              @nrfconnect/ncs-aegir
 /modules/wfa-qt/                          @nrfconnect/ncs-wifi
 

modules/modules.cmake

@@ -7,6 +7,8 @@ set(ZEPHYR_COREMARK_KCONFIG   ${CMAKE_CURRENT_LIST_DIR}/coremark/Kconfig)
 set(ZEPHYR_TRUSTED_FIRMWARE_M_KCONFIG ${CMAKE_CURRENT_LIST_DIR}/trusted-firmware-m/Kconfig)
 set(ZEPHYR_AZURE_SDK_FOR_C_KCONFIG ${CMAKE_CURRENT_LIST_DIR}/azure-sdk-for-c/Kconfig)
 set(ZEPHYR_AZURE_SDK_FOR_C_CMAKE_DIR ${CMAKE_CURRENT_LIST_DIR}/azure-sdk-for-c)
+set(ZEPHYR_OPENTHREAD_CMAKE_DIR ${CMAKE_CURRENT_LIST_DIR}/openthread)
+set(ZEPHYR_OPENTHREAD_KCONFIG ${CMAKE_CURRENT_LIST_DIR}/openthread/Kconfig)
 
 # Those are modules with Kconfig tree's inside the module repo but where
 # nRF Connect SDK extend those trees.

modules/openthread/platform/CMakeLists.txt

@@ -6,17 +6,10 @@ zephyr_library_sources(
   entropy.c
   misc.c
   platform.c
-  )
-
-zephyr_library_sources_ifndef(CONFIG_HDLC_RCP_IF
   radio.c
   spi.c
   )
 
-zephyr_library_sources_ifdef(CONFIG_HDLC_RCP_IF
-  radio_spinel.cpp
-  hdlc_interface.cpp
-  )
 
 zephyr_library_sources_ifdef(CONFIG_OPENTHREAD_BLE_TCAT ble.c)
 zephyr_library_sources_ifdef(CONFIG_OPENTHREAD_DIAG diag.c)

modules/openthread/platform/alarm.c

@@ -67,12 +67,9 @@ void platformAlarmProcess(otInstance *aInstance)
 #endif
 	if (timer_ms_fired) {
 		timer_ms_fired = false;
-#if defined(CONFIG_OPENTHREAD_DIAG)
-		if (otPlatDiagModeGet()) {
+		if (IS_ENABLED(CONFIG_OPENTHREAD_DIAG) && otPlatDiagModeGet()) {
 			otPlatDiagAlarmFired(aInstance);
-		} else
-#endif
-		{
+		} else {
 			otPlatAlarmMilliFired(aInstance);
 		}
 	}

modules/openthread/platform/radio.c

@@ -502,6 +502,7 @@ static void openthread_handle_received_frame(otInstance *instance,
 					     struct net_pkt *pkt)
 {
 	otRadioFrame recv_frame;
+
 	memset(&recv_frame, 0, sizeof(otRadioFrame));
 
 	recv_frame.mPsdu = net_buf_frag_last(pkt->buffer)->data;
@@ -942,6 +943,7 @@ int8_t otPlatRadioGetRssi(otInstance *aInstance)
 	int error = 0;
 	const uint16_t detection_time = 1;
 	enum ieee802154_hw_caps radio_caps;
+
 	ARG_UNUSED(aInstance);
 
 	radio_caps = radio_api->get_capabilities(radio_dev);
@@ -973,8 +975,8 @@ int8_t otPlatRadioGetRssi(otInstance *aInstance)
 otRadioCaps otPlatRadioGetCaps(otInstance *aInstance)
 {
 	otRadioCaps caps = OT_RADIO_CAPS_NONE;
-
 	enum ieee802154_hw_caps radio_caps;
+
 	ARG_UNUSED(aInstance);
 	__ASSERT(radio_api,
 	    "platformRadioInit needs to be called prior to otPlatRadioGetCaps");

scripts/ci/license_allow_list.yaml

@@ -48,6 +48,7 @@ Apache-2.0: |
   ^nrf/tests/bluetooth/tester/src/bttester.c$
   ^nrf/subsys/nrf_security/src/legacy
   ^nrf/modules/trusted-firmware-m/fault.c
+  ^nrf/modules/openthread/
   ^nrf/samples/net/http_server/src/main.c
   ^nrf/tests/subsys/suit/common/tls_config/user-tls-conf.h
 curl: "^nrf/ext/"

scripts/ci/tags.yaml

@@ -275,6 +275,7 @@ ci_samples_openthread:
     - nrf/drivers/hw_cc3xx/
     - nrf/drivers/mpsl/
     - nrf/modules/nrfxlib/nrf_802154/
+    - nrf/modules/openthread/
     - nrf/samples/openthread/
     - nrf/subsys/ieee802154/
     - nrf/subsys/mpsl/
@@ -290,7 +291,6 @@ ci_samples_openthread:
     - nrfxlib/openthread/
     - zephyr/include/zephyr/net/
     - zephyr/modules/mbedtls/
-    - zephyr/modules/openthread/
     - zephyr/soc/nordic/
     - zephyr/subsys/net/
     - zephyr/subsys/settings/
@@ -1461,6 +1461,7 @@ ci_applications_protocols_serialization:
     - nrf/applications/protocols_serialization/
     - nrf/drivers/mpsl/
     - nrf/modules/nrfxlib/nrf_802154/
+    - nrf/modules/openthread/
     - nrf/subsys/bluetooth/
     - nrf/subsys/ieee802154/
     - nrf/subsys/logging/
@@ -1473,7 +1474,6 @@ ci_applications_protocols_serialization:
     - nrfxlib/nrf_802154/
     - nrfxlib/nrf_rpc/
     - zephyr/drivers/ieee802154/
-    - zephyr/modules/openthread/
     - zephyr/subsys/bluetooth/
     - zephyr/subsys/net/
     - zephyr/subsys/retention/