Skip to content

Commit 4364c4f

Browse files
nvlsianpurlubos
authored andcommitted
childimage/NSIB: Remove non-functional environmental key support
Removes non-workable possibility for configuring signing key using either environmental or command-line variable (SB_SIGNING_KEY_FILE). This has never worked. ref.: NCSDK-28124 Signed-off-by: Andrzej Puzdrowski <[email protected]>
1 parent 5319a8c commit 4364c4f

File tree

2 files changed

+0
-19
lines changed

2 files changed

+0
-19
lines changed

subsys/bootloader/Kconfig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ config SB_SIGNING_KEY_FILE
7575
Specifies the private key used for signing the firmware image.
7676
The hash of the corresponding public key is stored as the first
7777
entry in the list of public key hashes in the provision hex file.
78-
This value can also be set by exporting an environment variable
79-
named 'SB_SIGNING_KEY_FILE' or passing
80-
'-DSB_SIGNING_KEY_FILE=/path/to/my/pem' when running cmake.
8178
See also SB_PUBLIC_KEY_FILES.
8279

8380
config SB_SIGNING_COMMAND

subsys/bootloader/cmake/debug_keys.cmake

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,6 @@ set(PUB_CMD
1616
)
1717

1818
# Check if PEM file is specified by user, if not, create one.
19-
20-
# First, check environment variables. Only use if not specified in command line.
21-
if (DEFINED ENV{SB_SIGNING_KEY_FILE} AND NOT SB_SIGNING_KEY_FILE)
22-
if (NOT EXISTS "$ENV{SB_SIGNING_KEY_FILE}")
23-
message(FATAL_ERROR "ENV points to non-existing PEM file '$ENV{SB_SIGNING_KEY_FILE}'")
24-
else()
25-
set(SIGNATURE_PRIVATE_KEY_FILE $ENV{SB_SIGNING_KEY_FILE})
26-
endif()
27-
endif()
28-
29-
# Next, check command line arguments
30-
if (DEFINED SB_SIGNING_KEY_FILE)
31-
set(SIGNATURE_PRIVATE_KEY_FILE ${SB_SIGNING_KEY_FILE})
32-
endif()
33-
34-
# Check if debug sign key should be generated.
3519
if( "${CONFIG_SB_SIGNING_KEY_FILE}" STREQUAL "")
3620
message(WARNING "
3721
--------------------------------------------------------------

0 commit comments

Comments
 (0)