Skip to content

Commit 55a0bb7

Browse files
nordic-haninordicjm
authored andcommitted
net: Clean up kconfigs
- Some documentation was referring to kconfigs that have been removed. - Some kconfig names has changed. - Some kconfigs never existed in the first place. - Some defines used CONFIG_ in the name without being a kconfig. Signed-off-by: Håvard Vermeer <[email protected]>
1 parent 29c2b12 commit 55a0bb7

File tree

15 files changed

+32
-35
lines changed

15 files changed

+32
-35
lines changed

applications/serial_lte_modem/doc/CARRIER_AT_commands.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ The ``<cmd>`` command is a string, and can be used as follows:
448448
* ``all`` - Any network allowed.
449449
* ``0`` - :kconfig:option:`CONFIG_LWM2M_CARRIER_GENERIC`.
450450
* ``1`` - :kconfig:option:`CONFIG_LWM2M_CARRIER_VERIZON`.
451-
* ``2`` - :kconfig:option:`CONFIG_LWM2M_CARRIER_ATT`.
451+
* ``2`` - :kconfig:option:`CONFIG_LWM2M_CARRIER_BELL_CA`.
452452
* ``3`` - :kconfig:option:`CONFIG_LWM2M_CARRIER_LG_UPLUS`.
453453
* ``4`` - :kconfig:option:`CONFIG_LWM2M_CARRIER_T_MOBILE`.
454454
* ``5`` - :kconfig:option:`CONFIG_LWM2M_CARRIER_SOFTBANK`.
@@ -551,7 +551,6 @@ The ``<cmd>`` command is a string, and can be used as follows:
551551
* ``"N"`` - :kconfig:option:`LWM2M_CARRIER_SERVER_BINDING_N`.
552552

553553
Additionally, an empty ``<binding>`` resets the configuration to default setting (factory configuration).
554-
For details, see the :kconfig:option:`CONFIG_LWM2M_SERVER_BINDING_CHOICE` Kconfig option.
555554

556555
* ``AT#XCARRIERCFG="is_bootstrap"[,<0|1>]``
557556

doc/nrf/libraries/bin/lwm2m_carrier/CHANGELOG.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,8 @@ Changes
504504

505505
* This function allows the LwM2M carrier library to disconnect gracefully and it is mandatory to use when the Subscriber ID is LG U+.
506506

507+
* Updated the name of the ``CONFIG_LWM2M_CARRIER_IS_SERVER_BOOTSTRAP`` Kconfig option to :kconfig:option:`CONFIG_LWM2M_CARRIER_IS_BOOTSTRAP_SERVER`.
508+
507509
liblwm2m_carrier 0.30.2
508510
***********************
509511

doc/nrf/libraries/bin/lwm2m_carrier/app_integration.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ Following are some of the server Kconfig options that you can configure.
155155
See the :ref:`enabled carriers <general_options_enabled_carriers>` under :ref:`general_options_lwm2m` for when the option is relevant.
156156

157157
For :kconfig:option:`CONFIG_LWM2M_CARRIER_GENERIC`, no valid factory configuration has been set.
158-
At a minimum, a URI must be set, unless the :kconfig:option:`CONFIG_LWM2M_SERVER_BINDING_CHOICE` Kconfig option value is non-IP.
158+
At a minimum, a URI must be set, unless the :kconfig:option:`CONFIG_LWM2M_CARRIER_SERVER_BINDING_NONIP` Kconfig option value is set.
159159

160160
.. note::
161161
Changing one or more server options will trigger a factory reset (resulting in a new bootstrap sequence).
@@ -189,15 +189,15 @@ At a minimum, a URI must be set, unless the :kconfig:option:`CONFIG_LWM2M_SERVER
189189
This can be different for each supported carrier.
190190
For generic operation (:kconfig:option:`CONFIG_LWM2M_CARRIER_GENERIC`), the default is 1 hour.
191191

192-
* :kconfig:option:`CONFIG_LWM2M_SERVER_BINDING_CHOICE`:
192+
* :kconfig:option:`LWM2M_CARRIER_SERVER_BINDING_UDP`, :kconfig:option:`LWM2M_CARRIER_SERVER_BINDING_NONIP`:
193193

194-
* This configuration can be used to overwrite the factory default by selecting :c:macro:`LWM2M_CARRIER_SERVER_BINDING_UDP` or :c:macro:`LWM2M_CARRIER_SERVER_BINDING_NONIP`).
195-
* This configuration is ignored if a bootstrap server is configured (either by our factory configuration, or by :kconfig:option:`CONFIG_LWM2M_CARRIER_IS_BOOTSTRAP_SERVER`).
194+
* These configurations can be used to overwrite the factory default binding.
195+
If these configurations are left empty (``=n``) the factory configuration is used.
196+
* The factory default can be different for each supported carrier.
197+
For generic operation (:kconfig:option:`CONFIG_LWM2M_CARRIER_GENERIC`), UDP (IP) binding is set as the default.
198+
* These configurations are ignored if a bootstrap server is configured (either by the factory configuration, or by :kconfig:option:`CONFIG_LWM2M_CARRIER_IS_BOOTSTRAP_SERVER`).
196199
* If UDP binding is configured, a URI must also be set (:kconfig:option:`CONFIG_LWM2M_CARRIER_CUSTOM_URI`).
197200
* The APN (either network default, or the one set with :kconfig:option:`CONFIG_LWM2M_CARRIER_CUSTOM_APN`) must be UDP (IP) or non-IP respectively.
198-
* If this configuration is left empty (``0``) the factory configuration is used.
199-
This can be different for each supported carrier.
200-
For generic operation (:kconfig:option:`CONFIG_LWM2M_CARRIER_GENERIC`), the default is :c:macro:`LWM2M_CARRIER_SERVER_BINDING_UDP`.
201201

202202
.. _device_options_lwm2m:
203203

doc/nrf/libraries/modem/lte_lc.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,8 @@ To enable power-saving features, use the following options:
174174

175175
* :kconfig:option:`CONFIG_LTE_LC_PSM_MODULE`
176176
* :kconfig:option:`CONFIG_LTE_LC_EDRX_MODULE`
177-
* :kconfig:option:`CONFIG_LTE_LC_PSM_REQ`
178-
* :kconfig:option:`CONFIG_LTE_LC_EDRX_REQ`
177+
* :kconfig:option:`CONFIG_LTE_PSM_REQ`
178+
* :kconfig:option:`CONFIG_LTE_EDRX_REQ`
179179

180180
PSM and eDRX can also be requested at run time using the :c:func:`lte_lc_psm_req` and :c:func:`lte_lc_edrx_req` function calls.
181181
However, calling the functions during modem initialization can lead to conflicts with the value set by the Kconfig options.

doc/nrf/libraries/networking/nrf_cloud.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ nRF Cloud FOTA enables the following additional features and libraries:
163163
* :kconfig:option:`CONFIG_DFU_TARGET` enables :ref:`lib_dfu_target`
164164
* :kconfig:option:`CONFIG_DOWNLOADER` enables :ref:`lib_downloader`
165165
* :kconfig:option:`CONFIG_FOTA_DOWNLOAD_PROGRESS_EVT`
166-
* :kconfig:option:`CONFIG_FOTA_PROGRESS_EVT_INCREMENT`
167166
* :kconfig:option:`CONFIG_REBOOT`
168167
* :kconfig:option:`CONFIG_CJSON_LIB`
169168
* :kconfig:option:`CONFIG_SETTINGS`

include/net/rest_client.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ struct rest_client_req_context {
9898
* for socket connection creation and data transfer meaning REST request can take
9999
* longer than this given timeout. To disable, set the timeout duration to SYS_FOREVER_MS.
100100
* A value of zero will result in an immediate timeout.
101-
* Default: @kconfig{CONFIG_REST_CLIENT_REST_REQUEST_TIMEOUT}.
101+
* Default: @kconfig{CONFIG_REST_CLIENT_REQUEST_TIMEOUT}.
102102
*/
103103
int32_t timeout_ms;
104104

samples/cellular/lwm2m_client/src/events/include/location_events.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ struct pgps_data_request_event {
4141
};
4242

4343
APP_EVENT_TYPE_DECLARE(pgps_data_request_event);
44-
#endif /* CONFIG_LWM2M_CLIEN_UTILS_LOCATION_ASSIST_PGPS */
44+
#endif /* CONFIG_LWM2M_CLIENT_UTILS_LOCATION_ASSIST_PGPS */
4545

4646
#endif /* LOCATION_EVENTS_H__ */

samples/cellular/lwm2m_client/src/ipso/ipso_colour_sensor.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ LOG_MODULE_DECLARE(app_sensors, CONFIG_APP_LOG_LEVEL);
3030
#else
3131
#define COLOUR_VERSION_MINOR 0
3232
#define NUMBER_OF_OBJECT_FIELDS 3
33-
#endif /* ifdef CONFIG_LWM2M_IPSO_APP_COLOUR_VERSION_1_1 */
33+
#endif /* CONFIG_LWM2M_IPSO_APP_COLOUR_SENSOR_VERSION_1_1 */
3434

3535
#define RESOURCE_INSTANCE_COUNT NUMBER_OF_OBJECT_FIELDS
3636

samples/cellular/lwm2m_client/src/modules/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ menuconfig SENSOR_MODULE_LIGHT
6565
server.
6666

6767

68-
menuconfig SENSOR_MODULE_COLOUR
68+
menuconfig SENSOR_MODULE_COLOR
6969
bool "Enable value tracking of colour"
7070
depends on APP_LIGHT_SENSOR
7171
default y if BOARD_THINGY91_NRF9160_NS

samples/cellular/lwm2m_client/src/modules/sensor_module.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ static int sensor_module_init(void)
216216
k_work_schedule(&light_work, K_NO_WAIT);
217217
}
218218

219-
if (IS_ENABLED(CONFIG_SENSOR_MODULE_COLOUR)) {
219+
if (IS_ENABLED(CONFIG_SENSOR_MODULE_COLOR)) {
220220
k_work_init_delayable(&colour_work, colour_work_cb);
221221
k_work_schedule(&colour_work, K_NO_WAIT);
222222
}

0 commit comments

Comments
 (0)