samples: cellular: modem_shell: Fix modem coredump handling

After a modem fault, the application halted execution too early,
because of which a part of the coredump was not sent. This commit
waits until all trace data has been processed before halting the
application core. It also uses k_oops() to halt the system instead
of an assert.

Signed-off-by: Tommi Kangas <[email protected]>

Author: tokangas

samples/cellular/modem_shell/src/main.c

@@ -132,14 +132,27 @@ static const char *modem_crash_reason_get(uint32_t reason)
 	}
 }
 
+static void modem_crash_work_fn(struct k_work *work)
+{
+	mosh_error("Modem crash detected, halting application execution");
+
+#if defined(CONFIG_NRF_MODEM_LIB_TRACE)
+	nrf_modem_lib_trace_processing_done_wait(K_SECONDS(5));
+#endif
+
+	k_oops();
+}
+
+K_WORK_DEFINE(modem_crash_work, modem_crash_work_fn);
+
 void nrf_modem_fault_handler(struct nrf_modem_fault_info *fault_info)
 {
 	printk("Modem crash reason: 0x%x (%s), PC: 0x%x\n",
 		fault_info->reason,
 		modem_crash_reason_get(fault_info->reason),
 		fault_info->program_counter);
 
-	__ASSERT(false, "Modem crash detected, halting application execution");
+	k_work_submit(&modem_crash_work);
 }
 
 #if defined(CONFIG_NRF_MODEM_LIB_SHELL_TRACE)