Skip to content

Commit 68490ae

Browse files
glarsennordicrlubos
authored andcommitted
samples: mss: Update to picolib
hostap now supports picolib, so we can switch to it. Increase relevant stack sizes slightly to avoid stack overflow on connect. Also remove unnecessary newlibc requirement on NRF_CLOUD_JWT_SOURCE_CUSTOM IRIS-7458 Signed-off-by: Georges Oates_Larsen <[email protected]>
1 parent ded993e commit 68490ae

File tree

4 files changed

+9
-16
lines changed

4 files changed

+9
-16
lines changed

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,10 @@ Cellular samples
250250

251251
* Added support for setting the FOTA update check interval using the config section in the shadow.
252252

253+
* :ref:`nrf_cloud_multi_service` sample:
254+
255+
* Updated Wi-Fi overlays from newlibc to picolib.
256+
253257
Cryptography samples
254258
--------------------
255259

samples/cellular/nrf_cloud_multi_service/overlay_nrf7002ek_wifi_coap_no_lte.conf

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ CONFIG_WIFI_CREDENTIALS_SHELL=y
6262
CONFIG_TLS_CREDENTIALS_SHELL=y
6363
CONFIG_TLS_CREDENTIALS_BACKEND_PROTECTED_STORAGE=y
6464
# Increased stack size needed for wifi_cred auto_connect command
65-
CONFIG_SHELL_STACK_SIZE=4400
65+
CONFIG_SHELL_STACK_SIZE=4500
6666
# nRFCloud credentials can exceed 1024 bytes
6767
CONFIG_TLS_CREDENTIALS_SHELL_CRED_BUF_SIZE=3072
6868
# Needed by the TLS credentials shell
@@ -160,18 +160,13 @@ CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=4096
160160
CONFIG_NET_MGMT_EVENT_QUEUE_SIZE=20
161161
CONFIG_APPLICATION_THREAD_STACK_SIZE=3072
162162
CONFIG_MESSAGE_THREAD_STACK_SIZE=3072
163-
CONFIG_CONNECTION_THREAD_STACK_SIZE=4096
163+
CONFIG_CONNECTION_THREAD_STACK_SIZE=4500
164164
CONFIG_DATE_TIME_THREAD_STACK_SIZE=2048
165165
CONFIG_NET_TX_STACK_SIZE=2048
166166
CONFIG_NET_RX_STACK_SIZE=2048
167167
CONFIG_POSIX_MAX_FDS=16
168168
CONFIG_NET_SOCKETS_POLL_MAX=8
169169

170-
# Disable PICOLIBC since hostap currently is not compatible with it
171-
CONFIG_NEWLIB_LIBC=y
172-
CONFIG_NEWLIB_LIBC_FLOAT_PRINTF=y
173-
CONFIG_PICOLIBC=n
174-
175170
# nRF Cloud: CoAP
176171
CONFIG_NRF_CLOUD_MQTT=n
177172
CONFIG_NRF_CLOUD_COAP=y

samples/cellular/nrf_cloud_multi_service/overlay_nrf7002ek_wifi_no_lte.conf

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ CONFIG_WIFI_CREDENTIALS_SHELL=y
6161
CONFIG_TLS_CREDENTIALS_SHELL=y
6262
CONFIG_TLS_CREDENTIALS_BACKEND_PROTECTED_STORAGE=y
6363
# Increased stack size needed for wifi_cred auto_connect command
64-
CONFIG_SHELL_STACK_SIZE=4400
64+
CONFIG_SHELL_STACK_SIZE=4500
6565
# nRFCloud credentials can exceed 1024 bytes
6666
CONFIG_TLS_CREDENTIALS_SHELL_CRED_BUF_SIZE=2048
6767
# Needed by the TLS credentials shell
@@ -158,14 +158,9 @@ CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=4096
158158
CONFIG_NRF_CLOUD_CONNECTION_POLL_THREAD_STACK_SIZE=8192
159159
CONFIG_APPLICATION_THREAD_STACK_SIZE=3072
160160
CONFIG_MESSAGE_THREAD_STACK_SIZE=3072
161-
CONFIG_CONNECTION_THREAD_STACK_SIZE=4096
161+
CONFIG_CONNECTION_THREAD_STACK_SIZE=4500
162162
CONFIG_DATE_TIME_THREAD_STACK_SIZE=2048
163163
CONFIG_NET_TX_STACK_SIZE=2048
164164
CONFIG_NET_RX_STACK_SIZE=2048
165165
CONFIG_POSIX_MAX_FDS=16
166166
CONFIG_NET_SOCKETS_POLL_MAX=8
167-
168-
# Disable PICOLIBC since hostap currently is not compatible with it
169-
CONFIG_NEWLIB_LIBC=y
170-
CONFIG_NEWLIB_LIBC_FLOAT_PRINTF=y
171-
CONFIG_PICOLIBC=n

subsys/net/lib/nrf_cloud/Kconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ config NRF_CLOUD_JWT_SOURCE_CUSTOM
138138
select TINYCRYPT_CTR_PRNG
139139
select TINYCRYPT_AES
140140
select CJSON_LIB
141-
depends on NEWLIB_LIBC
142-
depends on NEWLIB_LIBC_FLOAT_PRINTF
141+
depends on NEWLIB_LIBC_FLOAT_PRINTF || PICOLIBC_IO_FLOAT
143142
depends on DATE_TIME
144143
help
145144
JWTs are created and signed by the nRF Cloud library, not the modem.

0 commit comments

Comments
 (0)