Skip to content

Commit 6f52c67

Browse files
tomchyrlubos
authored andcommitted
cmake: Fix VID and CID values in Direct XIP on 54
Fix typos in nRF54H20-specific signing file to correctly pass the VID and CID values to the signing command in Direct XIP modes. Signed-off-by: Tomasz Chyrowicz <[email protected]>
1 parent 25ae44a commit 6f52c67

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

cmake/sysbuild/sign_nrf54h20.cmake

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,15 +127,25 @@ function(mcuboot_sign_merged_nrf54h20 merged_hex main_image)
127127
# Fetch VID and CID values from the main image Kconfig.
128128
set(CONFIG_MCUBOOT_IMGTOOL_UUID_VID)
129129
set(CONFIG_MCUBOOT_IMGTOOL_UUID_CID)
130-
sysbuild_get(CONFIG_MCUBOOT_IMGTOOL_UUID_VID IMAGE ${main_image} VAR CONFIG_MCUBOOT_IMGTOOL_UUID_VID KCONFIG)
131-
sysbuild_get(CONFIG_MCUBOOT_IMGTOOL_UUID_CID IMAGE ${main_image} VAR CONFIG_MCUBOOT_IMGTOOL_UUID_CID KCONFIG)
130+
set(CONFIG_MCUBOOT_IMGTOOL_UUID_VID_NAME)
131+
set(CONFIG_MCUBOOT_IMGTOOL_UUID_CID_NAME)
132+
sysbuild_get(CONFIG_MCUBOOT_IMGTOOL_UUID_VID IMAGE ${main_image} VAR
133+
CONFIG_MCUBOOT_IMGTOOL_UUID_VID KCONFIG)
134+
sysbuild_get(CONFIG_MCUBOOT_IMGTOOL_UUID_CID IMAGE ${main_image} VAR
135+
CONFIG_MCUBOOT_IMGTOOL_UUID_CID KCONFIG)
136+
sysbuild_get(CONFIG_MCUBOOT_IMGTOOL_UUID_VID_NAME IMAGE ${main_image} VAR
137+
CONFIG_MCUBOOT_IMGTOOL_UUID_VID_NAME KCONFIG)
138+
sysbuild_get(CONFIG_MCUBOOT_IMGTOOL_UUID_CID_NAME IMAGE ${main_image} VAR
139+
CONFIG_MCUBOOT_IMGTOOL_UUID_CID_NAME KCONFIG)
132140

133141
if(CONFIG_MCUBOOT_IMGTOOL_UUID_VID)
134-
set(imgtool_extra ${imgtool_extra} --vid "${CONFIG_MCUBOOT_IMGTOOL_UUID_VID_NAME}")
142+
set(imgtool_args ${imgtool_args} --vid
143+
"${CONFIG_MCUBOOT_IMGTOOL_UUID_VID_NAME}")
135144
endif()
136145

137146
if(CONFIG_MCUBOOT_IMGTOOL_UUID_CID)
138-
set(imgtool_extra ${imgtool_extra} --cid "${CONFIG_MCUBOOT_IMGTOOL_UUID_CID_NAME}")
147+
set(imgtool_args ${imgtool_args} --cid
148+
"${CONFIG_MCUBOOT_IMGTOOL_UUID_CID_NAME}")
139149
endif()
140150

141151
# Fetch version and flags from the main image Kconfig.

0 commit comments

Comments
 (0)