bluetooth: controller: Remove hci_internal_le_supported_features

Use sdc_hci_cmd_le_read_local_supported_features instead
to save having to have similar information in the sdc and in
nrf.

Signed-off-by: Sean Madigan <[email protected]>

Author: sean-madigan

subsys/bluetooth/controller/hci_driver.c

@@ -878,6 +878,13 @@ static int configure_supported_features(void)
 		}
 	}
 
+	if (IS_ENABLED(CONFIG_BT_CTLR_DF_ADV_CTE_TX)) {
+		err = sdc_support_le_connectionless_cte_transmitter();
+		if (err) {
+			return -ENOTSUP;
+		}
+	}
+
 	if (IS_ENABLED(CONFIG_BT_CTLR_LE_POWER_CONTROL)) {
 		if (IS_ENABLED(CONFIG_BT_CENTRAL)) {
 			err = sdc_support_le_power_control_central();

subsys/bluetooth/controller/hci_internal.c

@@ -688,118 +688,6 @@ static void supported_features(sdc_hci_ip_lmp_features_t *features)
 	features->le_supported = 1;
 }
 
-void hci_internal_le_supported_features(
-	sdc_hci_cmd_le_read_local_supported_features_return_t *features)
-{
-	memset(features, 0, sizeof(*features));
-
-	features->params.le_encryption = 1;
-	features->params.extended_reject_indication = 1;
-	features->params.slave_initiated_features_exchange = 1;
-	features->params.le_ping = 1;
-
-#ifdef CONFIG_BT_CTLR_DATA_LENGTH
-	features->params.le_data_packet_length_extension = 1;
-#endif
-
-#ifdef CONFIG_BT_CTLR_PRIVACY
-	features->params.ll_privacy = 1;
-#endif
-
-#ifdef CONFIG_BT_CTLR_EXT_SCAN_FP
-	features->params.extended_scanner_filter_policies = 1;
-#endif
-
-#ifdef CONFIG_BT_CTLR_PHY_2M
-	features->params.le_2m_phy = 1;
-#endif
-
-#ifdef CONFIG_BT_CTLR_PHY_CODED
-	features->params.le_coded_phy = 1;
-#endif
-
-#ifdef CONFIG_BT_CTLR_ADV_EXT
-	features->params.le_extended_advertising = 1;
-#ifdef CONFIG_BT_CTLR_PHY_CODED
-	features->params.advertising_coding_selection = 1;
-#endif
-#endif
-
-#if defined(CONFIG_BT_CTLR_ADV_PERIODIC) || defined(CONFIG_BT_CTLR_SYNC_PERIODIC)
-	features->params.le_periodic_advertising = 1;
-#ifdef CONFIG_BT_CTLR_SYNC_TRANSFER_SENDER
-	features->params.periodic_advertising_sync_transfer_sender = 1;
-#endif
-#ifdef CONFIG_BT_CTLR_SYNC_TRANSFER_RECEIVER
-	features->params.periodic_advertising_sync_transfer_recipient = 1;
-#endif
-#endif
-
-#if defined(CONFIG_BT_CTLR_DF_ADV_CTE_TX)
-	features->params.connectionless_cte_transmitter = 1;
-#endif
-
-	features->params.channel_selection_algorithm_2 = 1;
-
-#if defined(CONFIG_BT_CTLR_LE_POWER_CONTROL)
-	features->params.le_power_control_request = 1;
-	features->params.le_power_change_indication = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_LE_PATH_LOSS_MONITORING)
-	features->params.le_path_loss_monitoring = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_ADV_PERIODIC_ADI_SUPPORT)
-	features->params.periodic_advertising_adi_support = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_DF_CONN_CTE_RSP)
-	features->params.connection_cte_response = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_SCA_UPDATE)
-	features->params.sleep_clock_accuracy_updates = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_PERIPHERAL_ISO)
-	features->params.connected_isochronous_stream_slave = 1;
-#endif
-#if defined(CONFIG_BT_CTLR_CENTRAL_ISO)
-	features->params.connected_isochronous_stream_master = 1;
-#endif
-#if defined(CONFIG_BT_CTLR_SYNC_ISO)
-	features->params.synchronized_receiver = 1;
-#endif
-#if defined(CONFIG_BT_CTLR_ADV_ISO)
-	features->params.isochronous_broadcaster = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_SDC_PAWR_ADV)
-	features->params.periodic_advertising_with_responses_advertiser = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_SDC_PAWR_SYNC)
-	features->params.periodic_advertising_with_responses_scanner = 1;
-#endif
-
-#if defined(CONFIG_BT_CTLR_SUBRATING)
-	features->params.connection_subrating = 1;
-#endif
-#if defined(CONFIG_BT_CTLR_CHANNEL_SOUNDING)
-	features->params.channel_sounding = 1;
-	features->params.channel_sounding_tone_quality_indication = 1;
-#endif /* CONFIG_BT_CTLR_CHANNEL_SOUNDING */
-
-#if defined(CONFIG_BT_CTLR_EXTENDED_FEAT_SET)
-	features->params.ll_extended_feature_set = 1;
-#endif /* CONFIG_BT_CTLR_EXTENDED_FEAT_SET */
-
-#if defined(CONFIG_BT_CTLR_SDC_LE_POWER_CLASS_1)
-	features->params.le_Power_class_1 = 1;
-#endif /* CONFIG_BT_CTLR_SDC_LE_POWER_CLASS_1 */
-}
-
 static void le_read_supported_states(uint8_t *buf)
 {
 	/* Use 2*uint32_t instead of uint64_t to reduce code size. */
@@ -1011,8 +899,7 @@ static uint8_t le_controller_cmd_put(uint8_t const * const cmd,
 
 	case SDC_HCI_OPCODE_CMD_LE_READ_LOCAL_SUPPORTED_FEATURES:
 		*param_length_out += sizeof(sdc_hci_cmd_le_read_local_supported_features_return_t);
-		hci_internal_le_supported_features((void *)event_out_params);
-		return 0;
+		return sdc_hci_cmd_le_read_local_supported_features((void *)event_out_params);
 
 	case SDC_HCI_OPCODE_CMD_LE_SET_RANDOM_ADDRESS:
 		return sdc_hci_cmd_le_set_random_address((void *)cmd_params);

subsys/bluetooth/controller/hci_internal.h

@@ -95,11 +95,4 @@ int hci_internal_msg_get(uint8_t *msg_out, sdc_hci_msg_type_t *msg_type_out);
 void hci_internal_supported_commands(
 	sdc_hci_ip_supported_commands_t *cmds);
 
-/** @brief Retrieve the list of supported LE features configured for this build
- *
- * @param[out] features The list of supported features
- */
-void hci_internal_le_supported_features(
-	sdc_hci_cmd_le_read_local_supported_features_return_t *features);
-
 #endif