Skip to content

Commit 7dd13f2

Browse files
committed
tree: Update sdk-zephyr,sdk-mcuboot and partition macro usage
Includes the new zephyr,mapped-binding and conversion of Nordic parts to use this new compatible. Also included is an update to the flash map PM file to support the new macros Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
1 parent f0b98e2 commit 7dd13f2

File tree

35 files changed

+150
-140
lines changed

35 files changed

+150
-140
lines changed

applications/nrf_desktop/src/modules/dfu.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,18 +130,18 @@ LOG_MODULE_REGISTER(MODULE, CONFIG_DESKTOP_CONFIG_CHANNEL_DFU_LOG_LEVEL);
130130
#define MCUBOOT_PRIMARY_NODE DT_NODELABEL(slot0_partition)
131131
#define MCUBOOT_SECONDARY_NODE DT_NODELABEL(slot1_partition)
132132

133-
BUILD_ASSERT(UTIL_OR(DT_FIXED_PARTITION_EXISTS(MCUBOOT_PRIMARY_NODE),
133+
BUILD_ASSERT(UTIL_OR(DT_PARTITION_EXISTS(MCUBOOT_PRIMARY_NODE),
134134
DT_FIXED_SUBPARTITION_EXISTS(MCUBOOT_PRIMARY_NODE)),
135135
"Missing primary partition definition in DTS.");
136-
BUILD_ASSERT(UTIL_OR(DT_FIXED_PARTITION_EXISTS(MCUBOOT_SECONDARY_NODE),
136+
BUILD_ASSERT(UTIL_OR(DT_PARTITION_EXISTS(MCUBOOT_SECONDARY_NODE),
137137
DT_FIXED_SUBPARTITION_EXISTS(MCUBOOT_SECONDARY_NODE)),
138138
"Missing secondary partition definition in DTS.");
139139

140140

141141
#define NVM_ADDRESS(node) \
142142
(COND_CODE_1(DT_FIXED_SUBPARTITION_EXISTS(node), \
143143
(DT_FIXED_SUBPARTITION_ADDR(node)), \
144-
(DT_FIXED_PARTITION_ADDR(node))))
144+
(DT_PARTITION_ADDR(node))))
145145
#define CODE_PARTITION_START_ADDR NVM_ADDRESS(CODE_PARTITION_NODE)
146146
#define MCUBOOT_PRIMARY_START_ADDR NVM_ADDRESS(MCUBOOT_PRIMARY_NODE)
147147
#define MCUBOOT_SECONDARY_START_ADDR NVM_ADDRESS(MCUBOOT_SECONDARY_NODE)
@@ -154,8 +154,8 @@ LOG_MODULE_REGISTER(MODULE, CONFIG_DESKTOP_CONFIG_CHANNEL_DFU_LOG_LEVEL);
154154
#error Primary and secondary partitions cannot have the same address.
155155
#endif
156156

157-
#define MCUBOOT_PRIMARY_SLOT_ID DT_FIXED_PARTITION_ID(MCUBOOT_PRIMARY_NODE)
158-
#define MCUBOOT_SECONDARY_SLOT_ID DT_FIXED_PARTITION_ID(MCUBOOT_SECONDARY_NODE)
157+
#define MCUBOOT_PRIMARY_SLOT_ID DT_PARTITION_ID(MCUBOOT_PRIMARY_NODE)
158+
#define MCUBOOT_SECONDARY_SLOT_ID DT_PARTITION_ID(MCUBOOT_SECONDARY_NODE)
159159

160160
#if BUILD_TIME_DFU_SLOT_ID_INFO_IS_AVAILABLE
161161
/* Use range check to allow for placing MCUboot header in a separate

applications/nrf_desktop/src/modules/failsafe.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ static int failsafe_check(bool *failure_detected)
3838
static int failsafe_erase(void)
3939
{
4040
const struct flash_area *flash_area;
41-
int err = flash_area_open(FIXED_PARTITION_ID(storage_partition),
41+
int err = flash_area_open(PARTITION_ID(storage_partition),
4242
&flash_area);
4343
if (!err) {
4444
err = flash_area_erase(flash_area, 0,
45-
FIXED_PARTITION_SIZE(storage_partition));
45+
PARTITION_SIZE(storage_partition));
4646
flash_area_close(flash_area);
4747
}
4848

include/flash_map_pm.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,40 +50,50 @@
5050
#define FLASH_AREA_LABEL_STR(label) #label
5151

5252
#define FIXED_PARTITION_ID(label) PM_ID(label)
53+
#define PARTITION_ID(label) FIXED_PARTITION_ID(label)
5354
#define FLASH_AREA_ID(label) FIXED_PARTITION_ID(label)
5455

5556
#define FIXED_PARTITION_DATA_FIELD(label, x) \
5657
UTIL_CAT(PM_, UTIL_CAT(UTIL_CAT(PM_, UTIL_CAT(PM_ID(label), _LABEL)), x))
58+
#define PARTITION_DATA_FIELD(label, x) FIXED_PARTITION_DATA_FIELD(label, x)
5759
#define FLASH_DATA_FIELD(label, x) FIXED_PARTITION_DATA_FIELD(label, x)
5860

5961
#define FIXED_PARTITION_OFFSET(label) FIXED_PARTITION_DATA_FIELD(label, _OFFSET)
62+
#define PARTITION_OFFSET(label) FIXED_PARTITION_OFFSET(label)
6063
#define FLASH_AREA_OFFSET(label) FIXED_PARTITION_OFFSET(label)
6164

6265
#define FIXED_PARTITION_SIZE(label) FIXED_PARTITION_DATA_FIELD(label, _SIZE)
66+
#define PARTITION_SIZE(label) FIXED_PARTITION_SIZE(label)
6367
#define FLASH_AREA_SIZE(label) FIXED_PARTITION_SIZE(label)
6468

6569
#define FIXED_PARTITION_DEVICE(label) \
6670
COND_CODE_1(DT_NODE_EXISTS(FIXED_PARTITION_DATA_FIELD(label, _DEV)), \
6771
(DEVICE_DT_GET_OR_NULL(FIXED_PARTITION_DATA_FIELD(label, _DEV))), \
6872
(DEVICE_DT_GET_OR_NULL(DT_NODELABEL(FIXED_PARTITION_DATA_FIELD(label, _DEV)))))
73+
#define PARTITION_DEVICE(label) FIXED_PARTITION_DEVICE(label)
6974
#define FLASH_AREA_DEVICE(label) FIXED_PARTITION_DEVICE(label)
7075

7176
#define FIXED_PARTITION_MTD(label) \
7277
COND_CODE_1(DT_NODE_EXISTS(FIXED_PARTITION_DATA_FIELD(label, _DEV)), \
7378
(FIXED_PARTITION_DATA_FIELD(label, _DEV)), \
7479
(DT_NODELABEL(FIXED_PARTITION_DATA_FIELD(label, _DEV))))
80+
#define PARTITION_MTD(label) FIXED_PARTITION_MTD(label)
7581
#define FIXED_PARTITION_NODE_MTD(node) \
7682
COND_CODE_1( \
7783
DT_FIXED_SUBPARTITION_EXISTS(node), \
7884
(DT_MTD_FROM_FIXED_SUBPARTITION(node)), \
7985
(DT_MTD_FROM_FIXED_PARTITION(node)))
86+
#define PARTITION_NODE_MTD(node) FIXED_PARTITION_NODE_MTD(node)
8087

8188
#define FIXED_PARTITION_EXISTS(label) IS_ENABLED(PM_IS_ENABLED(label))
89+
#define PARTITION_EXISTS(label) FIXED_PARTITION_EXISTS(label)
8290
#define FLASH_AREA_LABEL_EXISTS(label) FIXED_PARTITION_EXISTS(label)
8391
#define FIXED_PARTITION_ADDRESS(label) FIXED_PARTITION_DATA_FIELD(label, _ADDRESS)
92+
#define PARTITION_ADDRESS(label) FIXED_PARTITION_ADDRESS(label)
8493

8594
#define FIXED_PARTITION(label) \
8695
((const struct flash_area *)&UTIL_CAT(global_pm_partition_, label))
96+
#define PARTITION(label) FIXED_PARTITION(label)
8797

8898
#define DECLARE_PARTITION(label) \
8999
extern const struct flash_area UTIL_CAT(global_pm_partition_, label)

lib/fprotect/sys_init_fprotect.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
#define AREA_SIZE PM_SIZE
1717
#else
1818
#define CODE_PARTITION DT_CHOSEN(zephyr_code_partition)
19-
#define AREA_ADDRESS FIXED_PARTITION_NODE_OFFSET(CODE_PARTITION)
20-
#define AREA_SIZE FIXED_PARTITION_NODE_SIZE(CODE_PARTITION)
19+
#define AREA_ADDRESS PARTITION_NODE_OFFSET(CODE_PARTITION)
20+
#define AREA_SIZE PARTITION_NODE_SIZE(CODE_PARTITION)
2121
#endif
2222

2323
#define PRIORITY_LEVEL 0 /* Locking should be performed as soon as possible */

lib/hw_unique_key/hw_unique_key_cc3xx_acl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ static const uint32_t huk_magic[4] = {
2929
#ifdef CONFIG_PARTITION_MANAGER_ENABLED
3030
static uint32_t huk_addr = PM_HW_UNIQUE_KEY_PARTITION_ADDRESS;
3131
#else
32-
static uint32_t huk_addr = FIXED_PARTITION_ADDRESS(hw_unique_key_partition);
32+
static uint32_t huk_addr = PARTITION_ADDRESS(hw_unique_key_partition);
3333
#endif
3434

3535
int hw_unique_key_write(enum hw_unique_key_slot key_slot, const uint8_t *key)

lib/nrf_modem_lib/trace_backends/flash/flash.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ int trace_backend_init(trace_backend_processed_cb trace_processed_cb)
221221

222222
trace_processed_callback = trace_processed_cb;
223223

224-
err = flash_area_open(FIXED_PARTITION_ID(MODEM_TRACE_PARTITION), &modem_trace_area);
224+
err = flash_area_open(PARTITION_ID(MODEM_TRACE_PARTITION), &modem_trace_area);
225225
if (err) {
226226
LOG_ERR("flash_area_open error: %d", err);
227227
return -ENODEV;
@@ -258,7 +258,7 @@ int trace_backend_init(trace_backend_processed_cb trace_processed_cb)
258258
uint32_t f_sector_cnt = sizeof(trace_flash_sectors) / sizeof(struct flash_sector);
259259

260260
err = flash_area_get_sectors(
261-
FIXED_PARTITION_ID(MODEM_TRACE_PARTITION), &f_sector_cnt, trace_flash_sectors);
261+
PARTITION_ID(MODEM_TRACE_PARTITION), &f_sector_cnt, trace_flash_sectors);
262262
if (err) {
263263
LOG_ERR("flash_area_get_sectors error: %d", err);
264264

@@ -275,7 +275,7 @@ int trace_backend_init(trace_backend_processed_cb trace_processed_cb)
275275
LOG_DBG("Sectors: %d, first sector: %p, sector size: %d",
276276
f_sector_cnt, trace_flash_sectors, trace_flash_sectors[0].fs_size);
277277

278-
err = fcb_init(FIXED_PARTITION_ID(MODEM_TRACE_PARTITION), &trace_fcb);
278+
err = fcb_init(PARTITION_ID(MODEM_TRACE_PARTITION), &trace_fcb);
279279
if (err) {
280280
LOG_ERR("fcb_init error: %d", err);
281281
return err;

modules/memfault-firmware-sdk/memfault_flash_coredump_storage.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ static bool last_coredump_cleared;
3030
void memfault_platform_coredump_storage_get_info(sMfltCoredumpStorageInfo *info)
3131
{
3232
*info = (sMfltCoredumpStorageInfo) {
33-
.size = FIXED_PARTITION_SIZE(MEMFAULT_STORAGE),
33+
.size = PARTITION_SIZE(MEMFAULT_STORAGE),
3434
};
3535
}
3636

@@ -53,7 +53,7 @@ bool memfault_platform_coredump_storage_read(uint32_t offset, void *data, size_t
5353
}
5454

5555
/* Note: internal flash is memory mapped so we can just memcpy it out */
56-
const uint32_t address = FIXED_PARTITION_OFFSET(MEMFAULT_STORAGE) + offset;
56+
const uint32_t address = PARTITION_OFFSET(MEMFAULT_STORAGE) + offset;
5757

5858
memcpy(data, (void *)address, read_len);
5959
return true;
@@ -75,7 +75,7 @@ bool memfault_platform_coredump_storage_erase(uint32_t offset, size_t erase_size
7575
}
7676

7777
for (size_t page = offset; page < erase_size; page += page_size) {
78-
const uint32_t address = FIXED_PARTITION_OFFSET(MEMFAULT_STORAGE) + page;
78+
const uint32_t address = PARTITION_OFFSET(MEMFAULT_STORAGE) + page;
7979

8080
nrfx_nvmc_page_erase(address);
8181
}
@@ -88,7 +88,7 @@ bool memfault_platform_coredump_storage_erase(uint32_t offset, size_t erase_size
8888
*/
8989
bool memfault_platform_coredump_storage_buffered_write(sCoredumpWorkingBuffer *blk)
9090
{
91-
const uint32_t start_addr = FIXED_PARTITION_OFFSET(MEMFAULT_STORAGE);
91+
const uint32_t start_addr = PARTITION_OFFSET(MEMFAULT_STORAGE);
9292
const uint32_t addr = start_addr + blk->write_offset;
9393

9494
if (!prv_op_within_flash_bounds(blk->write_offset, MEMFAULT_COREDUMP_STORAGE_WRITE_SIZE)) {
@@ -122,7 +122,7 @@ void memfault_platform_coredump_storage_clear(void)
122122
const struct flash_area *flash_area;
123123
int err;
124124

125-
err = flash_area_open(FIXED_PARTITION_ID(MEMFAULT_STORAGE), &flash_area);
125+
err = flash_area_open(PARTITION_ID(MEMFAULT_STORAGE), &flash_area);
126126
if (err) {
127127
MEMFAULT_LOG_ERROR("Unable to open coredump storage: 0x%x", err);
128128
return;

samples/bluetooth/mesh/dfu/common/src/dfu_target.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ static int dfu_meta_check(struct bt_mesh_dfu_srv *srv,
133133
return -EINVAL;
134134
}
135135

136-
if (flash_area_size_get(FIXED_PARTITION_ID(slot0_partition)) < metadata.fw_size ||
137-
flash_area_size_get(FIXED_PARTITION_ID(slot1_partition)) < metadata.fw_size) {
136+
if (flash_area_size_get(PARTITION_ID(slot0_partition)) < metadata.fw_size ||
137+
flash_area_size_get(PARTITION_ID(slot1_partition)) < metadata.fw_size) {
138138
printk("New firmware won't fit into flash.");
139139
return -EINVAL;
140140
}
@@ -251,7 +251,7 @@ static void image_version_load(void)
251251
struct mcuboot_img_header img_header;
252252
int err;
253253

254-
err = boot_read_bank_header(FIXED_PARTITION_ID(slot0_partition), &img_header,
254+
err = boot_read_bank_header(PARTITION_ID(slot0_partition), &img_header,
255255
sizeof(img_header));
256256
if (err) {
257257
printk("Failed to read image header: %d\n", err);

samples/bluetooth/mesh/dfu/distributor/src/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ int main(void)
147147

148148
printk("Initializing...\n");
149149

150-
err = bt_mesh_blob_io_flash_init(&blob_flash_stream, FIXED_PARTITION_ID(slot1_partition),
150+
err = bt_mesh_blob_io_flash_init(&blob_flash_stream, PARTITION_ID(slot1_partition),
151151
0);
152152
if (err) {
153153
printk("Failed to init BLOB IO Flash module: %d\n", err);

samples/bluetooth/mesh/dfu/target/src/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ int main(void)
138138

139139
printk("Initializing...\n");
140140

141-
err = bt_mesh_blob_io_flash_init(&blob_flash_stream, FIXED_PARTITION_ID(slot1_partition),
141+
err = bt_mesh_blob_io_flash_init(&blob_flash_stream, PARTITION_ID(slot1_partition),
142142
0);
143143
if (err) {
144144
printk("Failed to init BLOB IO Flash module: %d\n", err);

0 commit comments

Comments
 (0)