Skip to content

Commit b266253

Browse files
jtguggedalrlubos
authored andcommitted
modules: memfault: Add cell ID and TAC metrics
Add collection of cell ID and tracking area code metrics when a cell update event is received. Signed-off-by: Jan Tore Guggedal <[email protected]>
1 parent da81a34 commit b266253

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

modules/memfault-firmware-sdk/config/memfault_metrics_heartbeat_extra.def

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ MEMFAULT_METRICS_KEY_DEFINE(ncs_lte_edrx_ptw_ms, kMemfaultMetricType_Unsigned)
3131
MEMFAULT_METRICS_KEY_DEFINE(ncs_lte_mode, kMemfaultMetricType_Unsigned)
3232
MEMFAULT_METRICS_KEY_DEFINE(ncs_lte_on_time_ms, kMemfaultMetricType_Timer)
3333
MEMFAULT_METRICS_KEY_DEFINE(ncs_lte_reset_loop_detected_count, kMemfaultMetricType_Unsigned)
34+
MEMFAULT_METRICS_KEY_DEFINE(ncs_lte_cell_id, kMemfaultMetricType_Signed)
35+
MEMFAULT_METRICS_KEY_DEFINE(ncs_lte_tracking_area_code, kMemfaultMetricType_Signed)
3436
#endif /* CONFIG_MEMFAULT_NCS_LTE_METRICS */
3537

3638
#ifdef CONFIG_MEMFAULT_NCS_BT_METRICS

modules/memfault-firmware-sdk/memfault_lte_metrics.c

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ static void modem_params_get(void)
9999

100100
err = modem_info_get_snr(&snr);
101101
if (err) {
102-
LOG_DBG("Failed to get SNR")
102+
LOG_DBG("Failed to get SNR");
103103
return;
104104
}
105105

@@ -120,6 +120,17 @@ static void lte_handler(const struct lte_lc_evt *const evt)
120120
}
121121

122122
switch (evt->type) {
123+
case LTE_LC_EVT_CELL_UPDATE:
124+
err = MEMFAULT_METRIC_SET_SIGNED(ncs_lte_cell_id, evt->cell.id);
125+
if (err) {
126+
LOG_ERR("Failed to set ncs_lte_cell_id");
127+
}
128+
129+
err = MEMFAULT_METRIC_SET_SIGNED(ncs_lte_tracking_area_code, evt->cell.tac);
130+
if (err) {
131+
LOG_ERR("Failed to set ncs_lte_tracking_area_code");
132+
}
133+
break;
123134
case LTE_LC_EVT_NW_REG_STATUS:
124135
switch (evt->nw_reg_status) {
125136

0 commit comments

Comments
 (0)