samples: cellular: nrf_cloud_multi_service: Fix at cmd handling

plskeggs · rlubos · commit bb55a3b33c01 · 2025-01-08T12:36:43.000+01:00
In handle_at_cmd_requests() we need to initialize msg_obj so
that the parser used in nrf_cloud_obj_input_decode() operates correctly.

Jira: IRIS-9984

Signed-off-by: Pete Skeggs &lt;peter.skeggs@nordicsemi.no&gt;
diff --git a/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst b/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
@@ -294,6 +294,10 @@ Cellular samples
   * Removed the ``CONFIG_MOSH_LINK`` Kconfig option.
     The link control functionality is now always enabled and cannot be disabled.
 
+* :ref:`nrf_cloud_multi_service` sample:
+
+  * Fixed an issue with an uninitialized variable in the :c:func:`handle_at_cmd_requests` function.
+
 Cryptography samples
 --------------------
 
diff --git a/samples/cellular/nrf_cloud_multi_service/src/application.c b/samples/cellular/nrf_cloud_multi_service/src/application.c
@@ -212,7 +212,7 @@ static void on_location_update(const struct location_event_data * const location
 static void handle_at_cmd_requests(const struct nrf_cloud_data *const dev_msg)
 {
 	char *cmd;
-	struct nrf_cloud_obj msg_obj;
+	NRF_CLOUD_OBJ_DEFINE(msg_obj, NRF_CLOUD_OBJ_TYPE__UNDEFINED);
 	int err = nrf_cloud_obj_input_decode(&msg_obj, dev_msg);
 
 	if (err) {

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ static void on_location_update(const struct location_event_data * const location`
`212`	`212`	`static void handle_at_cmd_requests(const struct nrf_cloud_data *const dev_msg)`
`213`	`213`	`{`
`214`	`214`	`char *cmd;`
`215`		`- struct nrf_cloud_obj msg_obj;`
	`215`	`+ NRF_CLOUD_OBJ_DEFINE(msg_obj, NRF_CLOUD_OBJ_TYPE__UNDEFINED);`
`216`	`216`	`int err = nrf_cloud_obj_input_decode(&msg_obj, dev_msg);`
`217`	`217`
`218`	`218`	`if (err) {`