Skip to content

Commit bef08fc

Browse files
bjarki-andreasencarlescufi
authored andcommitted
benchmarks: multicore: idle_pwm_loopback: Remove GD freq changes
Global domain frequency (hsfll120) is no longer managed by drivers. Test shall not request global domain frequency change. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
1 parent 8fea36c commit bef08fc

File tree

5 files changed

+0
-141
lines changed

5 files changed

+0
-141
lines changed

tests/benchmarks/multicore/idle_pwm_loopback/boards/nrf54h20dk_nrf54h20_cpuapp.overlay

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,3 @@
5858
pinctrl-names = "default", "sleep";
5959
memory-regions = <&cpuapp_dma_region>;
6060
};
61-
62-
&hsfll120 {
63-
status = "okay";
64-
};

tests/benchmarks/multicore/idle_pwm_loopback/boards/nrf54h20dk_nrf54h20_cpuapp_fast_p7_1.overlay

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,3 @@
6565
&pwm130 {
6666
status = "disabled";
6767
};
68-
69-
&hsfll120 {
70-
status = "okay";
71-
};

tests/benchmarks/multicore/idle_pwm_loopback/boards/nrf54h20dk_nrf54h20_cpuapp_fast_slow_pins.overlay

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,3 @@
8989
current-speed = <115200>;
9090
/delete-property/ hw-flow-control;
9191
};
92-
93-
&hsfll120 {
94-
status = "okay";
95-
};

tests/benchmarks/multicore/idle_pwm_loopback/src/main.c

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ LOG_MODULE_REGISTER(idle_pwm_loop, LOG_LEVEL_INF);
1313
#include <zephyr/drivers/gpio.h>
1414
#include <zephyr/pm/device_runtime.h>
1515

16-
#if defined(CONFIG_CLOCK_CONTROL)
17-
#include <zephyr/devicetree/clocks.h>
18-
#include <zephyr/drivers/clock_control/nrf_clock_control.h>
19-
#endif
20-
2116
#if !DT_NODE_EXISTS(DT_NODELABEL(pwm_to_gpio_loopback))
2217
#error "Unsupported board: pwm_to_gpio_loopback node is not defined"
2318
#endif
@@ -42,34 +37,6 @@ static volatile uint32_t high, low;
4237
static struct k_timer my_timer;
4338
static bool timer_expired;
4439

45-
46-
#if defined(CONFIG_CLOCK_CONTROL)
47-
const uint32_t freq[] = {320, 256, 128, 64};
48-
49-
/*
50-
* Set Global Domain frequency (HSFLL120)
51-
*/
52-
void set_global_domain_frequency(uint32_t freq)
53-
{
54-
int err;
55-
int res;
56-
struct onoff_client cli;
57-
const struct device *hsfll_dev = DEVICE_DT_GET(DT_NODELABEL(hsfll120));
58-
const struct nrf_clock_spec clk_spec_global_hsfll = {.frequency = MHZ(freq)};
59-
60-
printk("Requested frequency [Hz]: %d\n", clk_spec_global_hsfll.frequency);
61-
sys_notify_init_spinwait(&cli.notify);
62-
err = nrf_clock_control_request(hsfll_dev, &clk_spec_global_hsfll, &cli);
63-
__ASSERT((err >= 0 && err < 3), "Wrong nrf_clock_control_request return code");
64-
do {
65-
err = sys_notify_fetch_result(&cli.notify, &res);
66-
k_yield();
67-
} while (err == -EAGAIN);
68-
__ASSERT(err == 0, "Wrong clock control request return code");
69-
__ASSERT(res == 0, "Wrong clock control request response");
70-
}
71-
#endif /* CONFIG_CLOCK_CONTROL */
72-
7340
void my_timer_handler(struct k_timer *dummy)
7441
{
7542
timer_expired = true;
@@ -108,10 +75,6 @@ int main(void)
10875
/* Wait a bit to solve NRFS request timeout issue. */
10976
k_msleep(100);
11077

111-
#if defined(CONFIG_CLOCK_CONTROL)
112-
set_global_domain_frequency(CONFIG_GLOBAL_DOMAIN_CLOCK_FREQUENCY_MHZ);
113-
#endif
114-
11578
/* Set PWM fill ratio to 50% */
11679
pulse = pwm_out.period >> 1;
11780

@@ -229,10 +192,6 @@ int main(void)
229192
}
230193
__ASSERT_NO_MSG(ret == 0);
231194

232-
#if defined(CONFIG_GLOBAL_DOMAIN_CLOCK_FREQUENCY_SWITCHING)
233-
k_busy_wait(100000);
234-
set_global_domain_frequency(freq[counter % ARRAY_SIZE(freq)]);
235-
#endif
236195
/* Keep PWM active for ~ 1 second */
237196
while (!timer_expired) {
238197
/* GPIOTE shall count edges here */

tests/benchmarks/multicore/idle_pwm_loopback/testcase.yaml

Lines changed: 0 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -137,94 +137,6 @@ tests:
137137
pytest_root:
138138
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_pwm_and_s2ram"
139139

140-
benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.s2ram_fast.remote_gd_freq_switching:
141-
filter: not CONFIG_COVERAGE
142-
tags: ppk_power_measure
143-
extra_args:
144-
- idle_pwm_loopback_CONF_FILE=prj_s2ram.conf
145-
- idle_pwm_loopback_DTC_OVERLAY_FILE="boards/nrf54h20dk_nrf54h20_cpuapp_fast_p7_1.overlay"
146-
- SB_CONFIG_REMOTE_GLOBAL_DOMAIN_CLOCK_FREQUENCY_SWITCHING=y
147-
harness: pytest
148-
harness_config:
149-
fixture: spi_loopback
150-
pytest_root:
151-
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_pwm_and_s2ram"
152-
153-
benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.s2ram_fast.gd_freq_320MHz:
154-
filter: not CONFIG_COVERAGE
155-
tags: ppk_power_measure
156-
extra_args:
157-
- idle_pwm_loopback_CONF_FILE=prj_s2ram.conf
158-
- remote_CONF_FILE=prj_s2ram.conf
159-
- idle_pwm_loopback_DTC_OVERLAY_FILE="boards/nrf54h20dk_nrf54h20_cpuapp_fast_p7_1.overlay"
160-
- idle_pwm_loopback_CONFIG_CLOCK_CONTROL=y
161-
- idle_pwm_loopback_CONFIG_GLOBAL_DOMAIN_CLOCK_FREQUENCY_OPTION_320MHZ=y
162-
harness: pytest
163-
harness_config:
164-
fixture: spi_loopback
165-
pytest_root:
166-
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_pwm_and_s2ram_with_clock_control"
167-
168-
benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.s2ram_fast.gd_freq_256MHz:
169-
filter: not CONFIG_COVERAGE
170-
tags: ppk_power_measure
171-
extra_args:
172-
- idle_pwm_loopback_CONF_FILE=prj_s2ram.conf
173-
- remote_CONF_FILE=prj_s2ram.conf
174-
- idle_pwm_loopback_DTC_OVERLAY_FILE="boards/nrf54h20dk_nrf54h20_cpuapp_fast_p7_1.overlay"
175-
- idle_pwm_loopback_CONFIG_CLOCK_CONTROL=y
176-
- idle_pwm_loopback_CONFIG_GLOBAL_DOMAIN_CLOCK_FREQUENCY_OPTION_256MHZ=y
177-
harness: pytest
178-
harness_config:
179-
fixture: spi_loopback
180-
pytest_root:
181-
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_pwm_and_s2ram_with_clock_control"
182-
183-
benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.s2ram_fast.gd_freq_128MHz:
184-
filter: not CONFIG_COVERAGE
185-
tags: ppk_power_measure
186-
extra_args:
187-
- idle_pwm_loopback_CONF_FILE=prj_s2ram.conf
188-
- remote_CONF_FILE=prj_s2ram.conf
189-
- idle_pwm_loopback_DTC_OVERLAY_FILE="boards/nrf54h20dk_nrf54h20_cpuapp_fast_p7_1.overlay"
190-
- idle_pwm_loopback_CONFIG_CLOCK_CONTROL=y
191-
- idle_pwm_loopback_CONFIG_GLOBAL_DOMAIN_CLOCK_FREQUENCY_OPTION_128MHZ=y
192-
harness: pytest
193-
harness_config:
194-
fixture: spi_loopback
195-
pytest_root:
196-
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_pwm_and_s2ram_with_clock_control"
197-
198-
benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.s2ram_fast.gd_freq_64MHz:
199-
filter: not CONFIG_COVERAGE
200-
tags: ppk_power_measure
201-
extra_args:
202-
- idle_pwm_loopback_CONF_FILE=prj_s2ram.conf
203-
- remote_CONF_FILE=prj_s2ram.conf
204-
- idle_pwm_loopback_DTC_OVERLAY_FILE="boards/nrf54h20dk_nrf54h20_cpuapp_fast_p7_1.overlay"
205-
- idle_pwm_loopback_CONFIG_CLOCK_CONTROL=y
206-
- idle_pwm_loopback_CONFIG_GLOBAL_DOMAIN_CLOCK_FREQUENCY_OPTION_64MHZ=y
207-
harness: pytest
208-
harness_config:
209-
fixture: spi_loopback
210-
pytest_root:
211-
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_pwm_and_s2ram_with_clock_control"
212-
213-
benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.s2ram_fast.gd_freq_switching:
214-
filter: not CONFIG_COVERAGE
215-
tags: ppk_power_measure
216-
extra_args:
217-
- idle_pwm_loopback_CONF_FILE=prj_s2ram.conf
218-
- remote_CONF_FILE=prj_s2ram.conf
219-
- idle_pwm_loopback_DTC_OVERLAY_FILE="boards/nrf54h20dk_nrf54h20_cpuapp_fast_p7_1.overlay"
220-
- idle_pwm_loopback_CONFIG_CLOCK_CONTROL=y
221-
- CONFIG_GLOBAL_DOMAIN_CLOCK_FREQUENCY_SWITCHING=y
222-
harness: pytest
223-
harness_config:
224-
fixture: spi_loopback
225-
pytest_root:
226-
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_pwm_and_s2ram_with_clock_control"
227-
228140
benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.coverage:
229141
filter: CONFIG_COVERAGE
230142
extra_args:

0 commit comments

Comments
 (0)