applications: nrf_desktop: Align initialization of keys_state utility

Change updates the utility to rely on runtime assertions ensuring that
the initialization function is called only once and other APIs of the
utility are called after the utility was initialized. This is done to
align the utility with other application utilities.

Jira: NCSDK-35363

Signed-off-by: Marek Pieta <[email protected]>
Signed-off-by: Pekka Niskanen <[email protected]>

Author: MarekPieta

applications/nrf_desktop/src/util/keys_state.c

@@ -27,6 +27,8 @@ void keys_state_init(struct keys_state *ks, uint8_t key_cnt_max)
 {
 	LOG_DBG("ks:%p, key_cnt_max:%" PRIu8, (void *)ks, key_cnt_max);
 
+	ARG_UNUSED(keys_state_is_initialized);
+
 	__ASSERT_NO_MSG(!keys_state_is_initialized(ks));
 	__ASSERT_NO_MSG((key_cnt_max > 0) && (key_cnt_max <= ARRAY_SIZE(ks->keys)));
 
@@ -112,6 +114,7 @@ int keys_state_key_update(struct keys_state *ks, uint16_t key_id, bool pressed,
 		(void *)ks, key_id, pressed ? "press" : "release");
 
 	__ASSERT_NO_MSG(ks_changed);
+	__ASSERT_NO_MSG(keys_state_is_initialized(ks));
 
 	int err = 0;
 	uint8_t prev_cnt = ks->cnt;
@@ -152,10 +155,10 @@ void keys_state_clear(struct keys_state *ks)
 {
 	LOG_DBG("ks:%p", (void *)ks);
 
-	if (keys_state_is_initialized(ks)) {
-		memset(ks->keys, 0, sizeof(ks->keys));
-		ks->cnt = 0;
-	}
+	__ASSERT_NO_MSG(keys_state_is_initialized(ks));
+
+	memset(ks->keys, 0, sizeof(ks->keys));
+	ks->cnt = 0;
 }
 
 size_t keys_state_keys_get(const struct keys_state *ks, uint16_t *res, size_t res_size)
@@ -166,6 +169,8 @@ size_t keys_state_keys_get(const struct keys_state *ks, uint16_t *res, size_t re
 	__ASSERT_NO_MSG(res_size >= ks->cnt_max);
 	ARG_UNUSED(res_size);
 
+	__ASSERT_NO_MSG(keys_state_is_initialized(ks));
+
 	for (uint8_t i = 0; i < ks->cnt; i++) {
 		res[i] = ks->keys[i].id;
 	}

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

@@ -408,6 +408,8 @@ nRF Desktop
     * Application image configurations to explicitly specify the LED driver used by the :ref:`nrf_desktop_leds` (:kconfig:option:`CONFIG_CAF_LEDS_GPIO` or :kconfig:option:`CONFIG_CAF_LEDS_PWM`).
       Also, disabled unused LED drivers enabled by default to reduce memory footprint.
     * The :ref:`nrf_desktop_hid_forward` to allow using the module when configuration channel support (:ref:`CONFIG_DESKTOP_CONFIG_CHANNEL_ENABLE <config_desktop_app_options>`) is disabled in the application configuration.
+    * The :ref:`nrf_desktop_keys_state` to rely on runtime assertions, ensuring that the initialization function is called only once and other APIs of the utility are called after the utility was initialized.
+      This is done to align the utility with other application utilities.
 
 nRF Machine Learning (Edge Impulse)
 -----------------------------------