Bluetooth: Mesh: Fixed reported coverity issues

Fixed High/Medium/Low covertiy reported issues:
- Out-of-bounds access
- Unchecked return values
- Logically dead code
- Defererence null return value
- Unnecessary header file
- Recursion in included headers
- Uninitialized scalar variable

Signed-off-by: Ingar Kulbrandstad <[email protected]>

Author: Balaklaka

samples/bluetooth/mesh/dfu/distributor/src/main.c

@@ -11,7 +11,6 @@
 #include <zephyr/storage/flash_map.h>
 #include <zephyr/bluetooth/bluetooth.h>
 #include <zephyr/bluetooth/mesh.h>
-#include <zephyr/bluetooth/mesh/shell.h>
 #include <bluetooth/mesh/vnd/le_pair_resp.h>
 #include <bluetooth/mesh/dk_prov.h>
 #include <dk_buttons_and_leds.h>

samples/bluetooth/mesh/light_ctrl/src/lc_pwm_led.c

@@ -31,5 +31,5 @@ void lc_pwm_led_set(uint16_t desired_lvl)
 		(PWM_PERIOD * desired_lvl) /
 		BT_MESH_LIGHTNESS_MAX;
 
-	pwm_set_dt(&led0, PWM_USEC(PWM_PERIOD), PWM_USEC(scaled_lvl));
+	(void)pwm_set_dt(&led0, PWM_USEC(PWM_PERIOD), PWM_USEC(scaled_lvl));
 }

samples/bluetooth/mesh/light_ctrl/src/model_handler.c

@@ -200,11 +200,11 @@ static int energy_use_get(struct bt_mesh_sensor_srv *srv,
 			 struct bt_mesh_sensor_value *rsp)
 {
 	/* Report energy usage as dummy value, and increase it by one every time
-	 * a get callback is triggered. The logic and hardware for mesuring
+	 * a get callback is triggered. The logic and hardware for measuring
 	 * the actual energy usage of the device should be implemented here.
 	 */
-	bt_mesh_sensor_value_from_micro(sensor->type->channels[0].format,
-					dummy_energy_use * 1000000LL, rsp);
+	(void)bt_mesh_sensor_value_from_micro(sensor->type->channels[0].format,
+					      dummy_energy_use * 1000000LL, rsp);
 	dummy_energy_use++;
 
 	return 0;

samples/bluetooth/mesh/sensor_server/src/model_handler.c

@@ -1103,7 +1103,9 @@ const struct bt_mesh_comp *model_handler_init(void)
 	dk_button_handler_add(&button_handler);
 
 	if (IS_ENABLED(CONFIG_BT_SETTINGS)) {
-		settings_subsys_init();
+		if (!settings_subsys_init()) {
+			printf("Failed to initialize setting subsystem");
+		}
 		settings_register(&temp_range_conf);
 		settings_register(&presence_motion_threshold_conf);
 		settings_register(&amb_light_level_gain_conf);

samples/bluetooth/mesh/silvair_enocean/src/model_handler.c

@@ -14,7 +14,6 @@
  */
 #include <zephyr/bluetooth/bluetooth.h>
 #include <bluetooth/mesh/models.h>
-#include <bluetooth/enocean.h>
 #include <bluetooth/mesh/vnd/silvair_enocean_srv.h>
 #include <dk_buttons_and_leds.h>
 #include "model_handler.h"

subsys/bluetooth/enocean.c

@@ -458,7 +458,7 @@ static void adv_recv(const struct bt_le_scan_recv_info *info,
 
 static void store_dirty(struct k_work *work)
 {
-	int err;
+	int err = 0;
 
 	for (int i = 0; i < ARRAY_SIZE(devices); ++i) {
 		if (!(devices[i].flags & FLAG_DIRTY)) {
@@ -617,12 +617,12 @@ void bt_enocean_decommission(struct bt_enocean_device *dev)
 
 	if (IS_ENABLED(CONFIG_BT_ENOCEAN_STORE)) {
 		encode_tag(name, dev - &devices[0], ENTRY_TAG_DEVICE);
-		settings_delete(name);
+		(void)settings_delete(name);
 	}
 
 	if (IS_ENABLED(CONFIG_BT_ENOCEAN_STORE_SEQ)) {
 		encode_tag(name, dev - &devices[0], ENTRY_TAG_SEQ);
-		settings_delete(name);
+		(void)settings_delete(name);
 	}
 
 	dev->flags = 0;

subsys/bluetooth/mesh/gen_prop_srv.c

@@ -9,7 +9,6 @@
 #include "gen_prop_internal.h"
 #include "model_utils.h"
 #include "mesh/net.h"
-#include "mesh/transport.h"
 
 #define LOG_LEVEL CONFIG_BT_MESH_MODEL_LOG_LEVEL
 #include "zephyr/logging/log.h"

subsys/bluetooth/mesh/model_utils.c

@@ -5,7 +5,6 @@
  */
 #include <bluetooth/mesh/models.h>
 #include "model_utils.h"
-#include "mesh/mesh.h"
 
 #define LOG_LEVEL CONFIG_BT_MESH_MODEL_LOG_LEVEL
 #include "zephyr/logging/log.h"

subsys/bluetooth/mesh/scheduler_srv.c

@@ -6,7 +6,6 @@
 
 #include <stdio.h>
 #include <bluetooth/mesh/models.h>
-#include <zephyr/sys/byteorder.h>
 #include <zephyr/sys/util.h>
 #include <zephyr/sys/math_extras.h>
 #include <zephyr/random/random.h>

subsys/bluetooth/mesh/sensor_cli.c

@@ -6,11 +6,9 @@
 
 #include <stdlib.h>
 #include <bluetooth/mesh/sensor_cli.h>
-#include <bluetooth/mesh/properties.h>
 #include "model_utils.h"
 #include "sensor.h"
 #include "mesh/net.h"
-#include "mesh/transport.h"
 
 #define LOG_LEVEL CONFIG_BT_MESH_MODEL_LOG_LEVEL
 #include "zephyr/logging/log.h"