Skip to content

Commit e02bc61

Browse files
committed
applications: zigbee_weather_station: fix negative values logging
A fix for logging negative temperature values and logging unification. Signed-off-by: Michal Leksinski <[email protected]>
1 parent d464236 commit e02bc61

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

applications/zigbee_weather_station/src/sensor.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,8 @@ int sensor_get_temperature(float *temperature)
9191
if (err) {
9292
LOG_ERR("Failed to get sensor channel: %d", err);
9393
} else {
94-
LOG_INF("Sensor T:%3d.%06d [*C]",
95-
sensor_temperature.val1, sensor_temperature.val2);
9694
*temperature = convert_sensor_value(sensor_temperature);
95+
LOG_INF("Sensor T:%9.3f [*C]", (double)(*temperature));
9796
}
9897
} else {
9998
LOG_ERR("Sensor not initialized");
@@ -121,9 +120,8 @@ int sensor_get_pressure(float *pressure)
121120
if (err) {
122121
LOG_ERR("Failed to get sensor channel: %d", err);
123122
} else {
124-
LOG_INF("Sensor P:%3d.%06d [kPa]",
125-
sensor_pressure.val1, sensor_pressure.val2);
126123
*pressure = convert_sensor_value(sensor_pressure);
124+
LOG_INF("Sensor P:%9.3f [kPa]", (double)(*pressure));
127125
}
128126
} else {
129127
LOG_ERR("Sensor not initialized");
@@ -151,9 +149,8 @@ int sensor_get_humidity(float *humidity)
151149
if (err) {
152150
LOG_ERR("Failed to get sensor channel: %d", err);
153151
} else {
154-
LOG_INF("Sensor H:%3d.%06d [%%]",
155-
sensor_humidity.val1, sensor_humidity.val2);
156152
*humidity = convert_sensor_value(sensor_humidity);
153+
LOG_INF("Sensor H:%9.3f [%%]", (double)(*humidity));
157154
}
158155
} else {
159156
LOG_ERR("Sensor not initialized");

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,14 @@ Thingy:53: Matter weather station
220220

221221
|no_changes_yet_note|
222222

223+
Thingy:53: Zigbee weather station
224+
---------------------------------
225+
226+
* Added:
227+
228+
* A fix for logging negative temperature values.
229+
* Logging unification.
230+
223231
Samples
224232
=======
225233

0 commit comments

Comments
 (0)