Skip to content

nrf_cc310: Added description for cc310 drivers #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

nrf_cc310: Added description for cc310 drivers #1349

merged 1 commit into from
Nov 7, 2019

Conversation

@tejlmand
Copy link
Contributor

@tejlmand tejlmand commented Oct 29, 2019

Doc commit from: #1268

nrf_cc310: Added description for cc310 drivers

Added description for:

  • cc310 entropy driver
  • cc310 hw initialization

Signed-off-by: Torsten Rasmussen [email protected]

@tejlmand tejlmand requested review from b-gent and frkv October 29, 2019 11:01
@tejlmand tejlmand requested a review from pdunaj as a code owner October 30, 2019 10:47
@b-gent
Copy link
Contributor

b-gent commented Nov 6, 2019

I'm assuming this is for 1.1.0? If yes, please add the backport label @tejlmand @frkv

@b-gent
Copy link
Contributor

b-gent commented Nov 6, 2019

I added another commit as a result of Frank's comments. @frkv , please check the diff.

Also, as part of this PR, a file rtt_README.rst was moved from nrf/drivers/net to doc/nrf/drivers. I reverted this change, this RST file is not reviewed and I don't want it to show up in the output.

@b-gent
Copy link
Contributor

b-gent commented Nov 6, 2019

The APIs in nrf_cc310_mbedcrypto are also usable

For this, I just provided a link to library description as we don't have API doc for this (header files do not have any doxygen groups defined)

frkv
frkv approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes accepted, LGTM

@tejlmand
Copy link
Contributor Author

tejlmand commented Nov 6, 2019

Also, as part of this PR, a file rtt_README.rst was moved from nrf/drivers/net to doc/nrf/drivers. I reverted this change, this RST file is not reviewed and I don't want it to show up in the output.

This is fine with me.
The main reason for including this file, was because the initial PR has the entropy_cc310.rst and hw_cc310.rst located in drivers/* and not in doc/nrf/drivers/* and this caused rtt_README.rst to show up during doc build with a warning it was not included in the docs.

When rst files has been moved to doc/nrf/drivers, this is no longer an issue.

@b-gent
Copy link
Contributor

b-gent commented Nov 6, 2019

looking good, thanks

@tejlmand
nrf_cc310: Added description for cc310 drivers
14868c4 
Added description for:
- cc310 entropy driver
- cc310 hw initialization

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand
Copy link
Contributor Author

tejlmand commented Nov 6, 2019

@b-gent squashed commits.

@carlescufi
Copy link
Contributor

carlescufi commented Nov 7, 2019

@b-gent will you merge this?

@b-gent b-gent merged commit 35dfc43 into nrfconnect:master Nov 7, 2019
@b-gent
Copy link
Contributor

b-gent commented Nov 7, 2019

merged

@backporting backporting bot mentioned this pull request Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frkv frkv frkv approved these changes

@b-gent b-gent b-gent approved these changes

@anangl anangl Awaiting requested review from anangl

@carlescufi carlescufi Awaiting requested review from carlescufi

@ru-fu ru-fu Awaiting requested review from ru-fu

@pdunaj pdunaj Awaiting requested review from pdunaj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tejlmand @b-gent @carlescufi @frkv