Skip to content

sdp: egpio: backends functionality improvements #17946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

sdp: egpio: backends functionality improvements #17946

merged 1 commit into from
Oct 29, 2024

Conversation

@jaz1-nordic
Copy link
Contributor

@jaz1-nordic jaz1-nordic commented Oct 16, 2024 •
edited
Loading

  • Add MBOX improvements to ensuring that data has been read by the remote core.
  • Add general structure code improvements to header files.

@jaz1-nordic jaz1-nordic requested review from a team as code owners October 16, 2024 15:34
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 16, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 16, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: e1c135aab6ae78ce0420a8c039ccf319390f5202

more details

sdk-nrf:

PR head: e1c135aab6ae78ce0420a8c039ccf319390f5202
merge base: 370f44ffed4f4199b375cf80c276296e5361e68c
target head (main): 370f44ffed4f4199b375cf80c276296e5361e68c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6) 
applications
│  ├── sdp
│  │  ├── gpio
│  │  │  ├── src
│  │  │  │  ├── backend
│  │  │  │  │  ├── backend.h
│  │  │  │  │  │ backend_mbox.c
drivers
│  ├── gpio
│  │  ├── gpio_nrfe_icmsg.c
│  │  │ gpio_nrfe_mbox.c
include
│  ├── drivers
│  │  ├── gpio
│  │  │  │ nrfe_gpio.h
│  ├── sdp
│  │  │ nrfe_common.h

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 36
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@masz-nordic masz-nordic added this to the 2.8.0 milestone Oct 21, 2024
magp-nordic
magp-nordic reviewed Oct 22, 2024
View reviewed changes
@jaz1-nordic
sdp: egpio: backends functionality improvements
e1c135a 
Add MBOX improvements to ensuring that data has been read
by the remote core.
Add general structure code improvements to header files.

Signed-off-by: Jakub Zymelka <[email protected]>
@jaz1-nordic jaz1-nordic force-pushed the nrfx-6518-egpio-cleanup branch from ab43314 to e1c135a Compare October 22, 2024 18:16
@jaz1-nordic jaz1-nordic changed the title sdp: egpio: extend data lock states for mbox backend sdp: egpio: backends functionality improvements Oct 22, 2024
@jaz1-nordic
Copy link
Contributor Author

@nrfconnect/ncs-co-drivers Could you please take a look?

masz-nordic
masz-nordic reviewed Oct 23, 2024
View reviewed changes
@masz-nordic masz-nordic added bugfix Fixes a known bug backport v2.8-branch auto-create a PR with same commits to v2.8-branch labels Oct 24, 2024
@rlubos
Copy link
Contributor

rlubos commented Oct 28, 2024

@nrfconnect/ncs-co-drivers Please review

@nordic-segl
Copy link
Contributor

@nrfconnect/ncs-co-drivers Please review
This is needed for NCS 2.8.0.

anangl
anangl reviewed Oct 29, 2024
View reviewed changes
@rlubos rlubos merged commit b9c115e into nrfconnect:main Oct 29, 2024
17 checks passed
@NordicBuilder NordicBuilder mentioned this pull request Oct 29, 2024
Merged
@jaz1-nordic jaz1-nordic deleted the nrfx-6518-egpio-cleanup branch October 29, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anangl anangl anangl approved these changes

@masz-nordic masz-nordic masz-nordic approved these changes

@nordic-segl nordic-segl nordic-segl approved these changes

@magp-nordic magp-nordic magp-nordic approved these changes

Assignees

No one assigned

Labels

backport v2.8-branch auto-create a PR with same commits to v2.8-branch bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jaz1-nordic @NordicBuilder @rlubos @nordic-segl @anangl @masz-nordic @magp-nordic